Skip to content

Commit c0cf4ef

Browse files
committed
Removed useless copying
1 parent ab6ce92 commit c0cf4ef

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

ext/filter/filter.c

+1-9
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,6 @@ static unsigned int php_sapi_filter(int arg, char *var, char **val, unsigned int
404404
{
405405
zval new_var, raw_var;
406406
zval *array_ptr = NULL, *orig_array_ptr = NULL;
407-
char *orig_var = NULL;
408407
int retval = 0;
409408

410409
assert(*val != NULL);
@@ -445,10 +444,6 @@ static unsigned int php_sapi_filter(int arg, char *var, char **val, unsigned int
445444
}
446445

447446
if (array_ptr) {
448-
/* Make a copy of the variable name, as php_register_variable_ex seems to
449-
* modify it */
450-
orig_var = estrdup(var);
451-
452447
/* Store the RAW variable internally */
453448
Z_STRLEN(raw_var) = val_len;
454449
Z_STRVAL(raw_var) = estrndup(*val, val_len);
@@ -477,10 +472,7 @@ static unsigned int php_sapi_filter(int arg, char *var, char **val, unsigned int
477472
}
478473

479474
if (orig_array_ptr) {
480-
php_register_variable_ex(orig_var, &new_var, orig_array_ptr TSRMLS_CC);
481-
}
482-
if (array_ptr) {
483-
efree(orig_var);
475+
php_register_variable_ex(var, &new_var, orig_array_ptr TSRMLS_CC);
484476
}
485477

486478
if (retval) {

0 commit comments

Comments
 (0)