Skip to content

Commit 8153286

Browse files
committed
Drop zend_indent() as it was never used, complete or working
1 parent c64f5e3 commit 8153286

File tree

12 files changed

+4
-249
lines changed

12 files changed

+4
-249
lines changed

Makefile.frag

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ $(srcdir)/zend_ini_parser.c: $(srcdir)/zend_ini_parser.y
2020
$(srcdir)/zend_ini_scanner.c: $(srcdir)/zend_ini_scanner.l
2121
@(cd $(top_srcdir); $(RE2C) $(RE2C_FLAGS) --no-generation-date --case-inverted -cbdFt Zend/zend_ini_scanner_defs.h -oZend/zend_ini_scanner.c Zend/zend_ini_scanner.l)
2222

23-
$(builddir)/zend_indent.lo $(builddir)/zend_highlight.lo $(builddir)/zend_compile.lo: $(srcdir)/zend_language_parser.h
23+
$(builddir)/zend_highlight.lo $(builddir)/zend_compile.lo: $(srcdir)/zend_language_parser.h

Zend/Makefile.am

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ libZend_la_SOURCES=\
1212
zend_execute.c zend_execute_API.c zend_highlight.c zend_llist.c \
1313
zend_vm_opcodes.c zend_opcode.c zend_operators.c zend_ptr_stack.c zend_stack.c \
1414
zend_variables.c zend.c zend_API.c zend_extensions.c zend_hash.c \
15-
zend_list.c zend_indent.c zend_builtin_functions.c zend_sprintf.c \
15+
zend_list.c zend_builtin_functions.c zend_sprintf.c \
1616
zend_ini.c zend_sort.c zend_objects.c zend_object_handlers.c \
1717
zend_objects_API.c zend_ts_hash.c zend_stream.c \
1818
zend_default_classes.c \

Zend/zend_indent.c

-155
This file was deleted.

Zend/zend_indent.h

-37
This file was deleted.

configure.in

+1-1
Original file line numberDiff line numberDiff line change
@@ -1489,7 +1489,7 @@ PHP_ADD_SOURCES(Zend, \
14891489
zend_execute_API.c zend_highlight.c zend_llist.c \
14901490
zend_vm_opcodes.c zend_opcode.c zend_operators.c zend_ptr_stack.c zend_stack.c \
14911491
zend_variables.c zend.c zend_API.c zend_extensions.c zend_hash.c \
1492-
zend_list.c zend_indent.c zend_builtin_functions.c zend_sprintf.c \
1492+
zend_list.c zend_builtin_functions.c zend_sprintf.c \
14931493
zend_ini.c zend_sort.c zend_multibyte.c zend_ts_hash.c zend_stream.c \
14941494
zend_iterators.c zend_interfaces.c zend_exceptions.c zend_strtod.c zend_gc.c \
14951495
zend_closures.c zend_float.c zend_string.c zend_signal.c zend_generators.c \

ext/readline/readline_cli.c

-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@
5858
#include "zend_compile.h"
5959
#include "zend_execute.h"
6060
#include "zend_highlight.h"
61-
#include "zend_indent.h"
6261
#include "zend_exceptions.h"
6362

6463
#include "sapi/cli/cli.h"

main/main.c

-11
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@
8080
#include "zend_compile.h"
8181
#include "zend_execute.h"
8282
#include "zend_highlight.h"
83-
#include "zend_indent.h"
8483
#include "zend_extensions.h"
8584
#include "zend_ini.h"
8685
#include "zend_dtrace.h"
@@ -2660,16 +2659,6 @@ PHPAPI int php_lint_script(zend_file_handle *file)
26602659
}
26612660
/* }}} */
26622661

2663-
#ifdef PHP_WIN32
2664-
/* {{{ dummy_indent
2665-
just so that this symbol gets exported... */
2666-
PHPAPI void dummy_indent(void)
2667-
{
2668-
zend_indent();
2669-
}
2670-
/* }}} */
2671-
#endif
2672-
26732662
/*
26742663
* Local variables:
26752664
* tab-width: 4

sapi/cgi/cgi_main.c

-18
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ int __riscosify_control = __RISCOSIFY_STRICT_UNIX_SPECS;
8787
#include "zend_compile.h"
8888
#include "zend_execute.h"
8989
#include "zend_highlight.h"
90-
#include "zend_indent.h"
9190

9291
#include "php_getopt.h"
9392

@@ -127,7 +126,6 @@ static pid_t pgroup;
127126

128127
#define PHP_MODE_STANDARD 1
129128
#define PHP_MODE_HIGHLIGHT 2
130-
#define PHP_MODE_INDENT 3
131129
#define PHP_MODE_LINT 4
132130
#define PHP_MODE_STRIP 5
133131

@@ -2180,12 +2178,6 @@ consult the installation file that came with this distribution, or visit \n\
21802178
exit_status = 0;
21812179
goto out;
21822180

2183-
#if 0 /* not yet operational, see also below ... */
2184-
case '': /* generate indented source mode*/
2185-
behavior=PHP_MODE_INDENT;
2186-
break;
2187-
#endif
2188-
21892181
case 'q': /* do not generate HTTP headers */
21902182
no_headers = 1;
21912183
break;
@@ -2471,16 +2463,6 @@ consult the installation file that came with this distribution, or visit \n\
24712463
return SUCCESS;
24722464
}
24732465
break;
2474-
#if 0
2475-
/* Zeev might want to do something with this one day */
2476-
case PHP_MODE_INDENT:
2477-
open_file_for_scanning(&file_handle);
2478-
zend_indent();
2479-
zend_file_handle_dtor(&file_handle);
2480-
php_output_teardown();
2481-
return SUCCESS;
2482-
break;
2483-
#endif
24842466
}
24852467

24862468
fastcgi_request_done:

sapi/cli/php_cli.c

-21
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@
7777
#include "zend_compile.h"
7878
#include "zend_execute.h"
7979
#include "zend_highlight.h"
80-
#include "zend_indent.h"
8180
#include "zend_exceptions.h"
8281

8382
#include "php_getopt.h"
@@ -109,7 +108,6 @@ ZEND_TSRMLS_CACHE_DEFINE();
109108

110109
#define PHP_MODE_STANDARD 1
111110
#define PHP_MODE_HIGHLIGHT 2
112-
#define PHP_MODE_INDENT 3
113111
#define PHP_MODE_LINT 4
114112
#define PHP_MODE_STRIP 5
115113
#define PHP_MODE_CLI_DIRECT 6
@@ -770,16 +768,6 @@ static int do_cli(int argc, char **argv) /* {{{ */
770768
behavior=PHP_MODE_LINT;
771769
break;
772770

773-
#if 0 /* not yet operational, see also below ... */
774-
case '': /* generate indented source mode*/
775-
if (behavior == PHP_MODE_CLI_DIRECT || behavior == PHP_MODE_PROCESS_STDIN) {
776-
param_error = "Source indenting only works for files.\n";
777-
break;
778-
}
779-
behavior=PHP_MODE_INDENT;
780-
break;
781-
#endif
782-
783771
case 'q': /* do not generate HTTP headers */
784772
/* This is default so NOP */
785773
break;
@@ -1005,15 +993,6 @@ static int do_cli(int argc, char **argv) /* {{{ */
1005993
goto out;
1006994
}
1007995
break;
1008-
#if 0
1009-
/* Zeev might want to do something with this one day */
1010-
case PHP_MODE_INDENT:
1011-
open_file_for_scanning(&file_handle);
1012-
zend_indent();
1013-
zend_file_handle_dtor(file_handle.handle);
1014-
goto out;
1015-
break;
1016-
#endif
1017996
case PHP_MODE_CLI_DIRECT:
1018997
cli_register_file_handles();
1019998
if (zend_eval_string_ex(exec_direct, NULL, "Command line code", 1) == FAILURE) {

sapi/cli/php_cli_server.c

-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@
7373
#include "zend_compile.h"
7474
#include "zend_execute.h"
7575
#include "zend_highlight.h"
76-
#include "zend_indent.h"
7776
#include "zend_exceptions.h"
7877

7978
#include "php_getopt.h"

sapi/fpm/fpm/fpm_main.c

-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ int __riscosify_control = __RISCOSIFY_STRICT_UNIX_SPECS;
9393
#include "zend_compile.h"
9494
#include "zend_execute.h"
9595
#include "zend_highlight.h"
96-
#include "zend_indent.h"
9796

9897
#include "php_getopt.h"
9998

win32/build/config.w32

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ ADD_SOURCES("Zend", "zend_language_parser.c zend_language_scanner.c \
128128
zend_execute_API.c zend_highlight.c \
129129
zend_llist.c zend_vm_opcodes.c zend_opcode.c zend_operators.c zend_ptr_stack.c \
130130
zend_stack.c zend_variables.c zend.c zend_API.c zend_extensions.c \
131-
zend_hash.c zend_list.c zend_indent.c zend_builtin_functions.c \
131+
zend_hash.c zend_list.c zend_builtin_functions.c \
132132
zend_sprintf.c zend_ini.c zend_sort.c zend_multibyte.c zend_ts_hash.c \
133133
zend_stream.c zend_iterators.c zend_interfaces.c zend_objects.c \
134134
zend_object_handlers.c zend_objects_API.c \

0 commit comments

Comments
 (0)