MFH: Overflow comment

Matt Wilmas · Matt Wilmas · commit 645e15c2eae2 · 2009-02-17T15:15:18.000Z
diff --git a/Zend/zend_operators.c b/Zend/zend_operators.c
@@ -1006,6 +1006,7 @@ ZEND_API int mod_function(zval *result, zval *op1, zval *op2 TSRMLS_DC)
 	}
 
 	if (Z_LVAL_P(op2) == -1) {
+		/* Prevent overflow error/crash if op1==LONG_MIN */
 		ZVAL_LONG(result, 0);
 		return SUCCESS;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1006,6 +1006,7 @@ ZEND_API int mod_function(zval result, zval op1, zval *op2 TSRMLS_DC)`
`1006`	`1006`	`}`
`1007`	`1007`
`1008`	`1008`	`if (Z_LVAL_P(op2) == -1) {`
	`1009`	`+ /* Prevent overflow error/crash if op1==LONG_MIN */`
`1009`	`1010`	`ZVAL_LONG(result, 0);`
`1010`	`1011`	`return SUCCESS;`
`1011`	`1012`	`}`