Fix GH-15742: php_hash_sha.h incompatible with C++

cmb69 · cmb69 · commit 5d1181fb3fe6 · 2024-09-04T17:25:43.000+02:00
Not only MSVC doesn't support this construct, but apparently it is generally not supported by C++ compilers. Closes GH-15745.
diff --git a/NEWS b/NEWS
@@ -30,6 +30,9 @@ PHP                                                                        NEWS
 - GD:
   . Added gdImageClone to bundled libgd. (David Carlier)
 
+- Hash:
+  . Fixed bug GH-15742 (php_hash_sha.h incompatible with C++). (cmb)
+
 - OpenSSL:
   . Implement GH-13514 PASSWORD_ARGON2 from OpenSSL 3.2. (Remi)
 
diff --git a/ext/hash/php_hash_sha.h b/ext/hash/php_hash_sha.h
@@ -45,7 +45,7 @@ typedef struct {
 PHP_HASH_API void PHP_SHA256InitArgs(PHP_SHA256_CTX *, ZEND_ATTRIBUTE_UNUSED HashTable *);
 PHP_HASH_API void PHP_SHA256Update(PHP_SHA256_CTX *, const unsigned char *, size_t);
 
-#ifdef _MSC_VER
+#if defined(__cplusplus) || defined(_MSC_VER)
 # define PHP_STATIC_RESTRICT
 #else
 # define PHP_STATIC_RESTRICT static restrict
