- Fix mem. leak

felipensp · felipensp · commit 54fc4537c66b · 2010-03-13T20:26:51.000Z
diff --git a/ext/xmlrpc/xmlrpc-epi-php.c b/ext/xmlrpc/xmlrpc-epi-php.c
@@ -795,7 +795,8 @@ zval* decode_request_worker(char *xml_in, int xml_in_len, char *encoding_in, zva
 					Z_TYPE_P(method_name_out) = IS_STRING;
 					Z_STRVAL_P(method_name_out) = estrdup(method_name);
 					Z_STRLEN_P(method_name_out) = strlen(Z_STRVAL_P(method_name_out));
-				} else {
+				} else if (retval) {
+					zval_ptr_dtor(&retval);
 					retval = NULL;
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -795,7 +795,8 @@ zval* decode_request_worker(char xml_in, int xml_in_len, char encoding_in, zva`
`795`	`795`	`Z_TYPE_P(method_name_out) = IS_STRING;`
`796`	`796`	`Z_STRVAL_P(method_name_out) = estrdup(method_name);`
`797`	`797`	`Z_STRLEN_P(method_name_out) = strlen(Z_STRVAL_P(method_name_out));`
`798`		`- } else {`
	`798`	`+ } else if (retval) {`
	`799`	`+ zval_ptr_dtor(&retval);`
`799`	`800`	`retval = NULL;`
`800`	`801`	`}`
`801`	`802`	`}`