Altering tests to follow is_iterable and isIterable reflection class behaviours to what foreach expects: foreach() argument must be of type array|object, %s given

Author: kstalega

ext/opcache/tests/iterable_type_optimization.phpt

@@ -49,7 +49,7 @@ Is IteratorImpl iterable? bool(true)
 Is IteratorAggregateImpl iterable? bool(true)
 Is ExtendsIteratorImpl iterable? bool(true)
 Is ExtendsIteratorAggregateImpl iterable? bool(true)
-Is A iterable? bool(false)
+Is A iterable? bool(true)
 
 Test static invocation:
 

ext/reflection/tests/ReflectionClass_isIterateable_001.phpt

@@ -14,14 +14,14 @@ class IteratorClass implements Iterator {
     function rewind(): void {}
 }
 class DerivedClass extends IteratorClass {}
-class NonIterator {}
+class RegularClass {}
 
 function dump_iterateable($class) {
     $reflection = new ReflectionClass($class);
     var_dump($reflection->isIterateable());
 }
 
-$classes = array("ArrayObject", "IteratorClass", "DerivedClass", "NonIterator");
+$classes = array("ArrayObject", "IteratorClass", "DerivedClass", "RegularClass");
 foreach ($classes as $class) {
     echo "Is $class iterateable? ";
     dump_iterateable($class);
@@ -31,4 +31,4 @@ foreach ($classes as $class) {
 Is ArrayObject iterateable? bool(true)
 Is IteratorClass iterateable? bool(true)
 Is DerivedClass iterateable? bool(true)
-Is NonIterator iterateable? bool(false)
+Is RegularClass iterateable? bool(true)

ext/reflection/tests/ReflectionClass_isIterateable_basic.phpt

@@ -21,5 +21,5 @@ dump_iterateable($stdClass);
 
 ?>
 --EXPECT--
-bool(false)
-bool(false)
+bool(true)
+bool(true)

ext/reflection/tests/ReflectionClass_isIterateable_variation1.phpt

@@ -21,4 +21,4 @@ bool(true)
 bool(true)
 bool(false)
 bool(false)
-bool(false)
+bool(true)