Fix -Wtype-limits warning by using correct type declaration in JIT trace

Girgias · Girgias · commit 3e6667d3389b · 2020-03-26T00:01:59.000+01:00
Namely int as that is the type of 'definition' Closes GH-5299
diff --git a/ext/opcache/jit/zend_jit_trace.c b/ext/opcache/jit/zend_jit_trace.c
@@ -774,7 +774,7 @@ static int find_call_num_args(zend_jit_trace_rec *p)
 static int is_checked_guard(const zend_ssa *tssa, const zend_op **ssa_opcodes, uint32_t var, uint32_t phi_var)
 {
 	if ((tssa->var_info[phi_var].type & MAY_BE_ANY) == MAY_BE_LONG) {
-		uint32_t idx = tssa->vars[var].definition;
+		int idx = tssa->vars[var].definition;
 
 		if (idx >= 0) {
 			if (tssa->ops[idx].op1_def == var) {

Original file line number	Diff line number	Diff line change
`@@ -774,7 +774,7 @@ static int find_call_num_args(zend_jit_trace_rec *p)`
`774`	`774`	`static int is_checked_guard(const zend_ssa tssa, const zend_op *ssa_opcodes, uint32_t var, uint32_t phi_var)`
`775`	`775`	`{`
`776`	`776`	`if ((tssa->var_info[phi_var].type & MAY_BE_ANY) == MAY_BE_LONG) {`
`777`		`- uint32_t idx = tssa->vars[var].definition;`
	`777`	`+ int idx = tssa->vars[var].definition;`
`778`	`778`
`779`	`779`	`if (idx >= 0) {`
`780`	`780`	`if (tssa->ops[idx].op1_def == var) {`