Fixed bug #43457 (Prepared statement with incorrect parms doens't

Ilia Alshanetsky · Ilia Alshanetsky · commit 39f37ce950d8 · 2007-12-02T20:58:14.000Z
throw exception with pdo_pgsql driver)
diff --git a/ext/pdo_pgsql/pgsql_statement.c b/ext/pdo_pgsql/pgsql_statement.c
@@ -238,7 +238,7 @@ static int pgsql_stmt_param_hook(pdo_stmt_t *stmt, struct pdo_bound_param_data *
 								param->name, param->namelen + 1, (void**)&nameptr)) {
 							param->paramno = atoi(nameptr + 1) - 1;
 						} else {
-							pdo_pgsql_error_stmt(stmt, PGRES_FATAL_ERROR, "HY093");
+							pdo_raise_impl_error(stmt->dbh, stmt, "HY093", param->name TSRMLS_CC);
 							return 0;
 						}
 					}
diff --git a/ext/pdo_pgsql/tests/bug36727.phpt b/ext/pdo_pgsql/tests/bug36727.phpt
@@ -19,5 +19,6 @@ var_dump($stmt->bindValue(':test', 1, PDO::PARAM_INT));
 echo "Done\n";
 ?>
 --EXPECT--
+Warning: PDOStatement::bindValue(): SQLSTATE[HY093]: Invalid parameter number: :test in %s/bug36727.php on line %d
 bool(false)
-Done
+Done

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ static int pgsql_stmt_param_hook(pdo_stmt_t stmt, struct pdo_bound_param_data `
`238`	`238`	`param->name, param->namelen + 1, (void**)&nameptr)) {`
`239`	`239`	`param->paramno = atoi(nameptr + 1) - 1;`
`240`	`240`	`} else {`
`241`		`- pdo_pgsql_error_stmt(stmt, PGRES_FATAL_ERROR, "HY093");`
	`241`	`+ pdo_raise_impl_error(stmt->dbh, stmt, "HY093", param->name TSRMLS_CC);`
`242`	`242`	`return 0;`
`243`	`243`	`}`
`244`	`244`	`}`