Skip to content

Commit 33ec9c9

Browse files
committed
Address code review comments
1 parent 0e2793d commit 33ec9c9

File tree

219 files changed

+454
-442
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

219 files changed

+454
-442
lines changed

Zend/tests/018.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var_dump(constant("TEST_CONST2"));
1818
echo "Done\n";
1919
?>
2020
--EXPECT--
21-
Undefined constant
21+
Undefined constant ""
2222
int(1)
2323
string(4) "test"
2424
Done

Zend/tests/037.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ var_dump($x::$x);
1616
--EXPECTF--
1717
int(1)
1818

19-
Fatal error: Uncaught Error: Access to undeclared static property: Closure::$x in %s:%d
19+
Fatal error: Uncaught Error: Access to undeclared static property "Closure::$x" in %s:%d
2020
Stack trace:
2121
#0 {main}
2222
thrown in %s on line %d

Zend/tests/access_modifiers_010.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ new c;
2828

2929
?>
3030
--EXPECTF--
31-
Fatal error: Uncaught Error: Call to private method d::test2() from context "a" in %s:%d
31+
Fatal error: Uncaught Error: Call to private method d::test2() from scope a in %s:%d
3232
Stack trace:
3333
#0 %s(%d): a->test()
3434
#1 %s(%d): c->__construct()

Zend/tests/attributes/003_ast_nodes.phpt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,5 @@ array(1) {
104104
}
105105

106106
int(1)
107-
string(30) "Class 'MissingClass' not found"
108-
string(30) "Class 'MissingClass' not found"
109-
107+
string(30) "Class "MissingClass" not found"
108+
string(30) "Class "MissingClass" not found"

Zend/tests/attributes/005_objects.phpt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,13 @@ string(7) "ERROR 2"
108108
string(74) "A1::__construct(): Argument #1 ($name) must be of type string, array given"
109109

110110
string(7) "ERROR 3"
111-
string(30) "Attribute class 'A2' not found"
111+
string(30) "Attribute class "A2" not found"
112112

113113
string(7) "ERROR 4"
114-
string(50) "Attribute constructor of class 'A3' must be public"
114+
string(48) "Attribute constructor of class A3 must be public"
115115

116116
string(7) "ERROR 5"
117-
string(71) "Attribute class 'A4' does not have a constructor, cannot pass arguments"
117+
string(69) "Attribute class A4 does not have a constructor, cannot pass arguments"
118118

119119
string(7) "ERROR 6"
120-
string(78) "Attempting to use class 'A5' as attribute that does not have <<PhpAttribute>>."
120+
string(76) "Attempting to use class A5 as attribute that does not have <<PhpAttribute>>."

Zend/tests/attributes/006_filter.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,4 +109,4 @@ Array
109109
string(7) "ERROR 1"
110110
string(103) "ReflectionFunctionAbstract::getAttributes(): Argument #2 ($flags) must be a valid attribute filter flag"
111111
string(7) "ERROR 2"
112-
string(34) "Class 'SomeMissingClass' not found"
112+
string(34) "Class "SomeMissingClass" not found"

Zend/tests/attributes/013_class_scope.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ Array
109109
[1] => bar
110110
)
111111
string(7) "ERROR 1"
112-
string(34) "Undefined class constant self::FOO"
112+
string(28) "Undefined constant self::FOO"
113113

114114
bool(true)
115115
string(3) "bar"

Zend/tests/bug30519.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class test implements a {
66
}
77
?>
88
--EXPECTF--
9-
Fatal error: Uncaught Error: Interface 'a' not found in %s:%d
9+
Fatal error: Uncaught Error: Interface "a" not found in %s:%d
1010
Stack trace:
1111
#0 {main}
1212
thrown in %s on line %d

Zend/tests/bug30922.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ var_dump($a instanceOf A);
1010
echo "ok\n";
1111
?>
1212
--EXPECTF--
13-
Fatal error: Uncaught Error: Interface 'RecurisiveFooFar' not found in %s:%d
13+
Fatal error: Uncaught Error: Interface "RecurisiveFooFar" not found in %s:%d
1414
Stack trace:
1515
#0 {main}
1616
thrown in %s on line %d

Zend/tests/bug31102.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Caught: Test1::__construct
4343
Caught: {closure}
4444
{closure}(Test3,3)
4545

46-
Fatal error: Uncaught Error: Class 'Test3' not found in %sbug31102.php(%d) : eval()'d code:1
46+
Fatal error: Uncaught Error: Class "Test3" not found in %s:%d
4747
Stack trace:
4848
#0 %s(%d): eval()
4949
#1 {main}

0 commit comments

Comments
 (0)