- We can constify in 5.4+

felipensp · felipensp · commit 256867269137 · 2011-11-15T12:34:59.000Z
diff --git a/ext/dba/dba_db4.c b/ext/dba/dba_db4.c
@@ -48,7 +48,7 @@ static void php_dba_db4_errcall_fcn(
 /* Bug 51086, Berkeley DB 4.8.26 */
 /* This code suppresses a BDB 4.8+ error message, thus keeping PHP test compatibility */
 	{
-		char *function = get_active_function_name(TSRMLS_C);
+		const char *function = get_active_function_name(TSRMLS_C);
 		if (function && (!strcmp(function,"dba_popen") || !strcmp(function,"dba_open"))
 			&& (!strncmp(msg, "fop_read_meta", sizeof("fop_read_meta")-1)
 				|| !strncmp(msg, "BDB0004 fop_read_meta", sizeof("BDB0004 fop_read_meta")-1))) {

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ static void php_dba_db4_errcall_fcn(`
`48`	`48`	`/* Bug 51086, Berkeley DB 4.8.26 */`
`49`	`49`	`/* This code suppresses a BDB 4.8+ error message, thus keeping PHP test compatibility */`
`50`	`50`	`{`
`51`		`- char *function = get_active_function_name(TSRMLS_C);`
	`51`	`+ const char *function = get_active_function_name(TSRMLS_C);`
`52`	`52`	`if (function && (!strcmp(function,"dba_popen") \|\| !strcmp(function,"dba_open"))`
`53`	`53`	`&& (!strncmp(msg, "fop_read_meta", sizeof("fop_read_meta")-1)`
`54`	`54`	`\|\| !strncmp(msg, "BDB0004 fop_read_meta", sizeof("BDB0004 fop_read_meta")-1))) {`