Skip to content

Commit 2247d61

Browse files
author
Sascha Schumann
committed
Move autoconf-2.13 check into buildcheck.sh where we already have
version parsing code and (more importantly) proper error checking for missing autoconf.
1 parent 71e7b5c commit 2247d61

File tree

3 files changed

+15
-23
lines changed

3 files changed

+15
-23
lines changed

build/build.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ generated_lists:
4040
$(ZENDDIR)/acinclude.m4 ext/*/config*.m4 sapi/*/config.m4 >> $@
4141

4242
$(STAMP): build/buildcheck.sh
43-
@build/buildcheck.sh && touch $(STAMP)
43+
@build/buildcheck.sh $(STAMP)
4444

4545
snapshot:
4646
distname='$(DISTNAME)'; \

build/buildcheck.sh

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,13 @@
1616
# | Sascha Schumann <sascha@schumann.cx> |
1717
# +----------------------------------------------------------------------+
1818
#
19-
# $Id: buildcheck.sh,v 1.18 2002-06-26 18:42:50 sniper Exp $
19+
# $Id: buildcheck.sh,v 1.19 2002-07-21 13:09:07 sas Exp $
2020
#
2121

2222
echo "buildconf: checking installation..."
2323

24+
stamp=$1
25+
2426
# autoconf 2.13 or newer
2527
ac_version=`autoconf --version 2>/dev/null|head -1|sed -e 's/^[^0-9]*//' -e 's/[a-z]* *$//'`
2628
if test -z "$ac_version"; then
@@ -40,6 +42,15 @@ echo "buildconf: autoconf version $ac_version (ok)"
4042
fi
4143

4244

45+
if test "$1" = "2" && test "$2" -ge "50"; then
46+
echo "buildconf: Your version of autoconf likely contains buggy cache code."
47+
echo " Running cvsclean for you."
48+
echo " To avoid this, install autoconf-2.13 and automake-1.5."
49+
./cvsclean
50+
stamp=
51+
fi
52+
53+
4354
# automake 1.4 or newer
4455
am_version=`automake --version 2>/dev/null|head -1|sed -e 's/^[^0-9]*//' -e 's/[a-z]* *$//'`
4556
am_version_clean=`echo $am_version|sed -e 's/-p[0-9]*$//'`
@@ -91,4 +102,6 @@ if test "$am_prefix" != "$lt_prefix"; then
91102
echo " continuing anyway"
92103
fi
93104

105+
test -n "$stamp" && touch $stamp
106+
94107
exit 0

buildconf

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
11
#!/bin/sh
22
# $Id$
33

4-
acv=`autoconf --version | grep GNU |cut -d ' ' -f 4`
5-
res=`expr $acv '>=' 2.5`
6-
7-
if test $res = 1; then
8-
echo "cleaning checkout to force rebuild, due to bad autoconf"
9-
./cvsclean
10-
fi
11-
124
while test $# -gt 0; do
135
if test "$1" = "--copy"; then
146
automake_flags=--copy
@@ -27,19 +19,6 @@ if test -z "$ZENDDIR"; then
2719
echo "using default Zend directory"
2820
fi
2921

30-
## build.mk does not check aclocal exit status yet
31-
##
32-
#mv aclocal.m4 aclocal.m4.old 2>/dev/null
33-
#aclocal
34-
#if test "$?" != "0" -a "$am_prefix" != "$lt_prefix"; then
35-
# echo "buildconf: ERROR: aclocal failed, probably because automake and"
36-
# echo " libtool are installed with different prefixes;"
37-
# echo " automake is installed in $am_prefix, but libtool in $lt_prefix."
38-
# echo " Please re-install automake and/or libtool with a common prefix"
39-
# echo " and try again."
40-
# exit 1
41-
#fi
42-
4322
rm -f generated_lists
4423

4524
${MAKE:-make} -s -f build/build.mk AMFLAGS="$automake_flags" ZENDDIR="$ZENDDIR"

0 commit comments

Comments
 (0)