Delete empty temporary files if file upload hook forbids the upload

Stefan Esser · Stefan Esser · commit 1e8fc23095ad · 2006-09-19T11:34:19.000Z
diff --git a/main/rfc1867.c b/main/rfc1867.c
@@ -1033,6 +1033,14 @@ SAPI_API SAPI_POST_HANDLER_FUNC(rfc1867_post_handler)
 				event_file_start.filename = &filename;
 				if (php_rfc1867_callback(MULTIPART_EVENT_FILE_START, &event_file_start, &event_extra_data TSRMLS_CC) == FAILURE) {
 					skip_upload = 1;
+					if (temp_filename) {
+						if (cancel_upload != UPLOAD_ERROR_E) { /* file creation failed */
+							close(fd);
+							unlink(temp_filename);
+						}
+						efree(temp_filename);
+					}
+					temp_filename="";
 				}
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -1033,6 +1033,14 @@ SAPI_API SAPI_POST_HANDLER_FUNC(rfc1867_post_handler)`
`1033`	`1033`	`event_file_start.filename = &filename;`
`1034`	`1034`	`if (php_rfc1867_callback(MULTIPART_EVENT_FILE_START, &event_file_start, &event_extra_data TSRMLS_CC) == FAILURE) {`
`1035`	`1035`	`skip_upload = 1;`
	`1036`	`+ if (temp_filename) {`
	`1037`	`+ if (cancel_upload != UPLOAD_ERROR_E) { /* file creation failed */`
	`1038`	`+ close(fd);`
	`1039`	`+ unlink(temp_filename);`
	`1040`	`+ }`
	`1041`	`+ efree(temp_filename);`
	`1042`	`+ }`
	`1043`	`+ temp_filename="";`
`1036`	`1044`	`}`
`1037`	`1045`	`}`
`1038`	`1046`