Skip to content

Commit 0563dfe

Browse files
committed
Merge branch 'PHP-7.4'
* PHP-7.4: Fix #79174: cookie values with spaces fail to round-trip
2 parents d91b166 + addc3c9 commit 0563dfe

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

ext/standard/head.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ PHPAPI int php_setcookie(zend_string *name, zend_string *value, time_t expires,
123123
smart_str_append(&buf, name);
124124
smart_str_appendc(&buf, '=');
125125
if (url_encode) {
126-
zend_string *encoded_value = php_url_encode(ZSTR_VAL(value), ZSTR_LEN(value));
126+
zend_string *encoded_value = php_raw_url_encode(ZSTR_VAL(value), ZSTR_LEN(value));
127127
smart_str_append(&buf, encoded_value);
128128
zend_string_release_ex(encoded_value, 0);
129129
} else {

ext/standard/tests/network/setcookie.phpt

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ $expected = array(
2424
'Set-Cookie: name=deleted; expires='.date('D, d-M-Y H:i:s', 1).' GMT; Max-Age=0',
2525
'Set-Cookie: name=deleted; expires='.date('D, d-M-Y H:i:s', 1).' GMT; Max-Age=0',
2626
'Set-Cookie: name=value',
27-
'Set-Cookie: name=space+value',
27+
'Set-Cookie: name=space%20value',
2828
'Set-Cookie: name=value',
2929
'Set-Cookie: name=value; expires='.date('D, d-M-Y H:i:s', $tsp).' GMT; Max-Age=5',
3030
'Set-Cookie: name=value; expires='.date('D, d-M-Y H:i:s', $tsn).' GMT; Max-Age=0',

0 commit comments

Comments
 (0)