Skip to content

Commit 70ed1c2

Browse files
committedMay 21, 2019
Fix phpsdk_pgo for multiple CRT support
If dependencies for multiple CRTs are available, phpsdk_pgo didn't know which one to use, since Config::$currentCrtName is not initialized. Instead of adding an argument to phpsdk_pgo, we simply get the CRT to use from the environment.
1 parent 8d1df4a commit 70ed1c2

File tree

1 file changed

+1
-1
lines changed
  • lib/php/libsdk/SDK/Build/PGO/Abstracts

1 file changed

+1
-1
lines changed
 

‎lib/php/libsdk/SDK/Build/PGO/Abstracts/PHP.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ public function exec(string $php_cmd, string $args = NULL, array $extra_env = ar
238238
public function getIdString(): string
239239
{
240240
return $this->getVersion() . "-"
241-
. SDKConfig::getCurrentCrtName() . "-"
241+
. getenv('PHP_SDK_VS') . "-"
242242
. ($this->isThreadSafe() ? "ts" : "nts") . "-"
243243
. ($this->is64bit() ? "x64" : "x86")
244244
. "-" . substr(md5(uniqid()), 0, 8);

0 commit comments

Comments
 (0)
Please sign in to comment.