Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit daf6263

Browse files
committed
Merge branch 'request-timeout--allow-specifying-during-connection' of https://github.com/iFixit/php-webdriver into iFixit-request-timeout--allow-specifying-during-connection
2 parents 58223ee + c84d655 commit daf6263

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

lib/chrome/ChromeDriver.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ public function startSession($desired_capabilities) {
4747
public static function create(
4848
$url = 'http://localhost:4444/wd/hub',
4949
$desired_capabilities = null,
50-
$timeout_in_ms = 300000
50+
$timeout_in_ms = 300000,
51+
$request_timeout_in_ms = 300000
5152
) {
5253
throw new WebDriverException('Please use ChromeDriver::start() instead.');
5354
}

lib/remote/RemoteWebDriver.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,14 @@ protected function __construct() {}
4747
* @param string $url The url of the remote server
4848
* @param DesiredCapabilities $desired_capabilities The desired capabilities
4949
* @param int $connection_timeout_in_ms
50+
* @param int $request_timeout_in_ms
5051
* @return RemoteWebDriver
5152
*/
5253
public static function create(
5354
$url = 'http://localhost:4444/wd/hub',
5455
$desired_capabilities = null,
55-
$connection_timeout_in_ms = 300000
56+
$connection_timeout_in_ms = 300000,
57+
$request_timeout_in_ms = 300000
5658
) {
5759
$url = preg_replace('#/+$#', '', $url);
5860

@@ -64,6 +66,7 @@ public static function create(
6466

6567
$executor = new HttpCommandExecutor($url);
6668
$executor->setConnectionTimeout($connection_timeout_in_ms);
69+
$executor->setRequestTimeout($request_timeout_in_ms);
6770

6871
$command = new WebDriverCommand(
6972
null,

0 commit comments

Comments
 (0)