Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit 96bacb4

Browse files
committed
Merge pull request #258 from phelipealves/community
Method call uses 2 parameters, but method signature uses 1 parameters
2 parents 266e4bd + 1d82823 commit 96bacb4

File tree

6 files changed

+16
-5
lines changed

6 files changed

+16
-5
lines changed

lib/Firefox/FirefoxProfile.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ public function addExtension($extension) {
4545
* @param string $key
4646
* @param string|bool|int $value
4747
* @return FirefoxProfile
48+
* @throws WebDriverException
4849
*/
4950
public function setPreference($key, $value) {
5051
if (is_string($value)) {

lib/Remote/DesiredCapabilities.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ public function isJavascriptEnabled() {
115115
* This is a htmlUnit-only option.
116116
*
117117
* @param bool $enabled
118+
* @throws Exception
118119
* @return DesiredCapabilities
119120
* @see https://code.google.com/p/selenium/wiki/DesiredCapabilities#Read-write_capabilities
120121
*/

lib/Remote/ExecuteMethod.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515

1616
namespace Facebook\WebDriver\Remote;
1717

18-
use Facebook\WebDriver\Remote\WebDriverResponse;
19-
2018
interface ExecuteMethod {
2119

2220
/**

lib/Remote/LocalFileDetector.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515

1616
namespace Facebook\WebDriver\Remote;
1717

18-
use Facebook\WebDriver\Remote\FileDetector;
19-
2018
class LocalFileDetector implements FileDetector {
2119
/**
2220
* @param string $file

lib/Remote/Service/DriverCommandExecutor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public function execute(WebDriverCommand $command, $curl_opts = array()) {
5050
}
5151

5252
try {
53-
$value = parent::execute($command, $curl_opts);
53+
$value = parent::execute($command);
5454
if ($command->getName() === DriverCommand::QUIT) {
5555
$this->service->stop();
5656
}

lib/WebDriverSelect.php

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ public function getAllSelectedOptions() {
6868
}
6969

7070
/**
71+
* @throws NoSuchElementException
72+
*
7173
* @return WebDriverElement The first selected option in this select tag (or
7274
* the currently selected option in a normal select)
7375
*/
@@ -84,6 +86,8 @@ public function getFirstSelectedOption() {
8486
/**
8587
* Deselect all options in multiple select tag.
8688
*
89+
* @throws UnsupportedOperationException
90+
*
8791
* @return void
8892
*/
8993
public function deselectAll() {
@@ -104,6 +108,9 @@ public function deselectAll() {
104108
* Select the option at the given index.
105109
*
106110
* @param int $index The index of the option. (0-based)
111+
*
112+
* @throws NoSuchElementException
113+
*
107114
* @return void
108115
*/
109116
public function selectByIndex($index) {
@@ -133,6 +140,9 @@ public function selectByIndex($index) {
133140
* <option value="foo">Bar</option>;
134141
*
135142
* @param string $value The value to match against.
143+
*
144+
* @throws NoSuchElementException
145+
*
136146
* @return void
137147
*/
138148
public function selectByValue($value) {
@@ -164,6 +174,9 @@ public function selectByValue($value) {
164174
* <option value="foo">Bar</option>;
165175
*
166176
* @param string $text The visible text to match against.
177+
*
178+
* @throws NoSuchElementException
179+
*
167180
* @return void
168181
*/
169182
public function selectByVisibleText($text) {

0 commit comments

Comments
 (0)