Update phpstan

Author: OndraM

.travis.yml

@@ -26,7 +26,7 @@ matrix:
         - phpenv config-rm xdebug.ini
       before_script: ~
       script:
-        - composer require phpstan/phpstan-shim # Not part of require-dev, because it won't install on PHP 5.6
+        - composer require phpstan/phpstan # Not part of require-dev, because it won't install on PHP 5.6
         - composer analyze
         - composer codestyle:check
       after_script: ~

lib/WebDriverExpectedCondition.php

@@ -522,21 +522,23 @@ function () use ($element_or_by, $selected) {
                     return $element_or_by->isSelected() === $selected;
                 }
             );
-        } else {
-            if ($element_or_by instanceof WebDriverBy) {
-                return new static(
-                    function (WebDriver $driver) use ($element_or_by, $selected) {
-                        try {
-                            $element = $driver->findElement($element_or_by);
-
-                            return $element->isSelected() === $selected;
-                        } catch (StaleElementReferenceException $e) {
-                            return null;
-                        }
+        }
+
+        if ($element_or_by instanceof WebDriverBy) {
+            return new static(
+                function (WebDriver $driver) use ($element_or_by, $selected) {
+                    try {
+                        $element = $driver->findElement($element_or_by);
+
+                        return $element->isSelected() === $selected;
+                    } catch (StaleElementReferenceException $e) {
+                        return null;
                     }
-                );
-            }
+                }
+            );
         }
+
+        throw new \InvalidArgumentException('Instance of either WebDriverElement or WebDriverBy must be given');
     }
 
     /**

phpstan.neon

@@ -8,3 +8,6 @@ parameters:
         - '#Call to an undefined method Facebook\\WebDriver\\WebDriver::getTouch\(\)#'
         - '#Call to an undefined method Facebook\\WebDriver\\WebDriverElement::getCoordinates\(\)#'
         - '#Call to an undefined method Facebook\\WebDriver\\WebDriverElement::equals\(\)#'
+        - '#Unsafe usage of new static\(\)#'
+
+    inferPrivatePropertyTypeFromConstructor: true