Improve screenshot tests

OndraM · OndraM · commit 1ad0697c6ada · 2019-11-30T17:53:33.000+01:00
diff --git a/lib/WebDriverOptions.php b/lib/WebDriverOptions.php
@@ -76,7 +76,7 @@ public function deleteAllCookies()
     }
 
     /**
-     * Delete the cookie with the give name.
+     * Delete the cookie with the given name.
      *
      * @param string $name
      * @return WebDriverOptions The current instance.
diff --git a/tests/functional/RemoteWebDriverTest.php b/tests/functional/RemoteWebDriverTest.php
@@ -270,6 +270,18 @@ public function testShouldSaveScreenshotToFile()
         $this->assertGreaterThan(0, imagesx($image));
         $this->assertGreaterThan(0, imagesy($image));
 
+        // Validate expected red box is present on the screenshot
+        $this->assertSame(
+            ['red' => 255, 'green' => 0, 'blue' => 0, 'alpha' => 0],
+            imagecolorsforindex($image, imagecolorat($image, 5, 5))
+        );
+
+        // And whitespace has expected background color
+        $this->assertSame(
+            ['red' => 250, 'green' => 250, 'blue' => 255, 'alpha' => 0],
+            imagecolorsforindex($image, imagecolorat($image, 15, 5))
+        );
+
         unlink($screenshotPath);
         rmdir(dirname($screenshotPath));
     }
diff --git a/tests/functional/web/index.html b/tests/functional/web/index.html
@@ -3,9 +3,22 @@
 <head>
     <meta charset="utf-8">
     <title>php-webdriver test page</title>
+    <style>
+        #red-box {
+            position: absolute;
+            top: 5px;
+            left: 5px;
+            width: 5px;
+            height: 5px;
+            background-color: #ff0000;
+        }
+    </style>
 </head>
-<body>
-    <h1 id='welcome'>Welcome to the facebook/php-webdriver testing page.</h1>
+<body style="background-color: #fafaff;">
+
+    <div id="red-box"></div>
+
+    <h1 id="welcome">Welcome to the facebook/php-webdriver testing page.</h1>
 
     <a href="form.html" id="a-form">Form test page</a>
     |

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function deleteAllCookies()`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`/**`
`79`		`- * Delete the cookie with the give name.`
	`79`	`+ * Delete the cookie with the given name.`
`80`	`80`	`*`
`81`	`81`	`* @param string $name`
`82`	`82`	`* @return WebDriverOptions The current instance.`