Added error reporting to session code (#301)

dyeldandi · sodabrew · commit e1932dceb687 · 2017-01-24T11:37:37.000Z
diff --git a/php_memcached_session.c b/php_memcached_session.c
@@ -442,6 +442,7 @@ PS_READ_FUNC(memcached)
 		*val = ZSTR_EMPTY_ALLOC();
 		return SUCCESS;
 	} else {
+		php_error_docref(NULL TSRMLS_CC, E_WARNING, "error getting session from memcached: %s", memcached_last_error_message(memc));
 		return FAILURE;
 	}
 }
@@ -470,6 +471,8 @@ PS_WRITE_FUNC(memcached)
 	do {
 		if (memcached_set(memc, key->val, key->len, val->val, val->len, expiration, 0) == MEMCACHED_SUCCESS) {
 			return SUCCESS;
+		} else {
+			php_error_docref(NULL TSRMLS_CC, E_WARNING, "error saving session to memcached: %s", memcached_last_error_message(memc));
 		}
 	} while (--retries > 0);
 

Original file line number	Diff line number	Diff line change
`@@ -442,6 +442,7 @@ PS_READ_FUNC(memcached)`
`442`	`442`	`*val = ZSTR_EMPTY_ALLOC();`
`443`	`443`	`return SUCCESS;`
`444`	`444`	`} else {`
	`445`	`+ php_error_docref(NULL TSRMLS_CC, E_WARNING, "error getting session from memcached: %s", memcached_last_error_message(memc));`
`445`	`446`	`return FAILURE;`
`446`	`447`	`}`
`447`	`448`	`}`
`@@ -470,6 +471,8 @@ PS_WRITE_FUNC(memcached)`
`470`	`471`	`do {`
`471`	`472`	`if (memcached_set(memc, key->val, key->len, val->val, val->len, expiration, 0) == MEMCACHED_SUCCESS) {`
`472`	`473`	`return SUCCESS;`
	`474`	`+ } else {`
	`475`	`+ php_error_docref(NULL TSRMLS_CC, E_WARNING, "error saving session to memcached: %s", memcached_last_error_message(memc));`
`473`	`476`	`}`
`474`	`477`	`} while (--retries > 0);`
`475`	`478`