Set TCP_NODELAY when setting binary protocol (#421)

* Set TCP_NODELAY when setting binary protocol
* Add braces to the check_set_behavior macro

Author: sodabrew

php_memcached.c

@@ -1286,6 +1286,11 @@ static PHP_METHOD(Memcached, __construct)
 		if (rc != MEMCACHED_SUCCESS) {
 			php_error_docref(NULL, E_WARNING, "Failed to turn on binary protocol: %s", memcached_strerror(intern->memc, rc));
 		}
+		/* Also enable TCP_NODELAY when binary protocol is enabled */
+		rc = memcached_behavior_set(intern->memc, MEMCACHED_BEHAVIOR_TCP_NODELAY, 1);
+		if (rc != MEMCACHED_SUCCESS) {
+			php_error_docref(NULL, E_WARNING, "Failed to set TCP_NODELAY: %s", memcached_strerror(intern->memc, rc));
+		}
 	}
 
 	if (MEMC_G(default_behavior.connect_timeout)) {

php_memcached_session.c

@@ -178,7 +178,9 @@ void s_unlock_session(memcached_st *memc)
 static
 zend_bool s_configure_from_ini_values(memcached_st *memc, zend_bool silent)
 {
+/* This macro looks like a function but returns errors directly */
 #define check_set_behavior(behavior, value) \
+{ \
 	int b = (behavior); \
 	uint64_t v = (value); \
 	if (v != memcached_behavior_get(memc, b)) { \
@@ -189,10 +191,13 @@ zend_bool s_configure_from_ini_values(memcached_st *memc, zend_bool silent)
 			} \
 			return 0; \
 		} \
-	}
+	} \
+}
 
 	if (MEMC_SESS_INI(binary_protocol_enabled)) {
 		check_set_behavior(MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1);
+		/* Also enable TCP_NODELAY when binary protocol is enabled */
+		check_set_behavior(MEMCACHED_BEHAVIOR_TCP_NODELAY, 1);
 	}
 
 	if (MEMC_SESS_INI(consistent_hash_enabled)) {