Rename metadata err (#12)

nick-zh · web-flow · commit 902a00f28014 · 2020-12-28T12:59:43.000+01:00
* rename metadata err

* rename getTopic
diff --git a/configuration_arginfo.h b/configuration_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 2a9fd8de9f13ef85f4c02373cc6f2dc87114edd0 */
+ * Stub hash: f629d931de4ad3a347583a46a7fce628f567f8ee */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Kafka_Configuration___construct, 0, 0, 0)
 ZEND_END_ARG_INFO()
diff --git a/metadata_partition.c b/metadata_partition.c
@@ -102,9 +102,9 @@ ZEND_METHOD(Kafka_Metadata_Partition, getId)
 }
 /* }}} */
 
-/* {{{ proto int Kafka\Metadata\Partition::getErr()
+/* {{{ proto int Kafka\Metadata\Partition::getErrorCode()
    Partition error reported by broker */
-ZEND_METHOD(Kafka_Metadata_Partition, getErr)
+ZEND_METHOD(Kafka_Metadata_Partition, getErrorCode)
 {
     object_intern *intern;
 
diff --git a/metadata_partition.stub.php b/metadata_partition.stub.php
@@ -8,7 +8,7 @@ class Partition
 {
     public function getId(): int {}
 
-    public function getErr(): int {}
+    public function getErrorCode(): int {}
 
     public function getLeader(): int {}
 
diff --git a/metadata_partition_arginfo.h b/metadata_partition_arginfo.h
@@ -1,10 +1,10 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: e34e94f591ac3caf4ed3916d8d15252f96c8fc6b */
+ * Stub hash: 934cef11a377e54b4d5f8cea75e6d590ec071d50 */
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_Kafka_Metadata_Partition_getId, 0, 0, IS_LONG, 0)
 ZEND_END_ARG_INFO()
 
-#define arginfo_class_Kafka_Metadata_Partition_getErr arginfo_class_Kafka_Metadata_Partition_getId
+#define arginfo_class_Kafka_Metadata_Partition_getErrorCode arginfo_class_Kafka_Metadata_Partition_getId
 
 #define arginfo_class_Kafka_Metadata_Partition_getLeader arginfo_class_Kafka_Metadata_Partition_getId
 
@@ -15,15 +15,15 @@ ZEND_END_ARG_INFO()
 
 
 ZEND_METHOD(Kafka_Metadata_Partition, getId);
-ZEND_METHOD(Kafka_Metadata_Partition, getErr);
+ZEND_METHOD(Kafka_Metadata_Partition, getErrorCode);
 ZEND_METHOD(Kafka_Metadata_Partition, getLeader);
 ZEND_METHOD(Kafka_Metadata_Partition, getReplicas);
 ZEND_METHOD(Kafka_Metadata_Partition, getIsrs);
 
 
 static const zend_function_entry class_Kafka_Metadata_Partition_methods[] = {
 	ZEND_ME(Kafka_Metadata_Partition, getId, arginfo_class_Kafka_Metadata_Partition_getId, ZEND_ACC_PUBLIC)
-	ZEND_ME(Kafka_Metadata_Partition, getErr, arginfo_class_Kafka_Metadata_Partition_getErr, ZEND_ACC_PUBLIC)
+	ZEND_ME(Kafka_Metadata_Partition, getErrorCode, arginfo_class_Kafka_Metadata_Partition_getErrorCode, ZEND_ACC_PUBLIC)
 	ZEND_ME(Kafka_Metadata_Partition, getLeader, arginfo_class_Kafka_Metadata_Partition_getLeader, ZEND_ACC_PUBLIC)
 	ZEND_ME(Kafka_Metadata_Partition, getReplicas, arginfo_class_Kafka_Metadata_Partition_getReplicas, ZEND_ACC_PUBLIC)
 	ZEND_ME(Kafka_Metadata_Partition, getIsrs, arginfo_class_Kafka_Metadata_Partition_getIsrs, ZEND_ACC_PUBLIC)
diff --git a/metadata_topic.c b/metadata_topic.c
@@ -92,9 +92,9 @@ static HashTable *get_debug_info(Z_KAFKA_OBJ *object, int *is_temp) /* {{{ */
 }
 /* }}} */
 
-/* {{{ proto string Kafka\MetadataTopic::getTopic()
+/* {{{ proto string Kafka\MetadataTopic::getName()
    Topic name */
-ZEND_METHOD(Kafka_Metadata_Topic, getTopic)
+ZEND_METHOD(Kafka_Metadata_Topic, getName)
 {
     object_intern *intern;
 
@@ -110,9 +110,9 @@ ZEND_METHOD(Kafka_Metadata_Topic, getTopic)
 }
 /* }}} */
 
-/* {{{ proto int Kafka\MetadataTopic::getErr()
+/* {{{ proto int Kafka\MetadataTopic::getErrorCode()
    Error */
-ZEND_METHOD(Kafka_Metadata_Topic, getErr)
+ZEND_METHOD(Kafka_Metadata_Topic, getErrorCode)
 {
     object_intern *intern;
 
diff --git a/metadata_topic.stub.php b/metadata_topic.stub.php
@@ -6,9 +6,9 @@
 
 class Topic
 {
-    public function getTopic(): string {}
+    public function getName(): string {}
 
-    public function getErr(): int {}
+    public function getErrorCode(): int {}
 
     public function getPartitions(): Collection {}
 }
diff --git a/metadata_topic_arginfo.h b/metadata_topic_arginfo.h
@@ -1,24 +1,24 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 3950e26cab1ce664cffda7d6df362e2b488d2fe3 */
+ * Stub hash: 9d73f729b3dca2b6ac7fd5fdc39ba23d768ca792 */
 
-ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_Kafka_Metadata_Topic_getTopic, 0, 0, IS_STRING, 0)
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_Kafka_Metadata_Topic_getName, 0, 0, IS_STRING, 0)
 ZEND_END_ARG_INFO()
 
-ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_Kafka_Metadata_Topic_getErr, 0, 0, IS_LONG, 0)
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_Kafka_Metadata_Topic_getErrorCode, 0, 0, IS_LONG, 0)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_class_Kafka_Metadata_Topic_getPartitions, 0, 0, Kafka\\Metadata\\Collection, 0)
 ZEND_END_ARG_INFO()
 
 
-ZEND_METHOD(Kafka_Metadata_Topic, getTopic);
-ZEND_METHOD(Kafka_Metadata_Topic, getErr);
+ZEND_METHOD(Kafka_Metadata_Topic, getName);
+ZEND_METHOD(Kafka_Metadata_Topic, getErrorCode);
 ZEND_METHOD(Kafka_Metadata_Topic, getPartitions);
 
 
 static const zend_function_entry class_Kafka_Metadata_Topic_methods[] = {
-	ZEND_ME(Kafka_Metadata_Topic, getTopic, arginfo_class_Kafka_Metadata_Topic_getTopic, ZEND_ACC_PUBLIC)
-	ZEND_ME(Kafka_Metadata_Topic, getErr, arginfo_class_Kafka_Metadata_Topic_getErr, ZEND_ACC_PUBLIC)
+	ZEND_ME(Kafka_Metadata_Topic, getName, arginfo_class_Kafka_Metadata_Topic_getName, ZEND_ACC_PUBLIC)
+	ZEND_ME(Kafka_Metadata_Topic, getErrorCode, arginfo_class_Kafka_Metadata_Topic_getErrorCode, ZEND_ACC_PUBLIC)
 	ZEND_ME(Kafka_Metadata_Topic, getPartitions, arginfo_class_Kafka_Metadata_Topic_getPartitions, ZEND_ACC_PUBLIC)
 	ZEND_FE_END
 };
diff --git a/tests/metadata.phpt b/tests/metadata.phpt
@@ -43,7 +43,7 @@ echo $metadata->getOrigBrokerName() . PHP_EOL;
 $topics = $metadata->getTopics();
 
 while ($topics->valid()) {
-    echo $topics->current()->getTopic() . PHP_EOL;
+    echo $topics->current()->getName() . PHP_EOL;
     echo $topics->current()->getPartitions()->count() . PHP_EOL;
     echo $topics->current()->getPartitions()->current()->getLeader() . PHP_EOL;
     $topics->next();

Original file line number	Diff line number	Diff line change
`@@ -102,9 +102,9 @@ ZEND_METHOD(Kafka_Metadata_Partition, getId)`
`102`	`102`	`}`
`103`	`103`	`/* }}} */`
`104`	`104`
`105`		`-/* {{{ proto int Kafka\Metadata\Partition::getErr()`
	`105`	`+/* {{{ proto int Kafka\Metadata\Partition::getErrorCode()`
`106`	`106`	`Partition error reported by broker */`
`107`		`-ZEND_METHOD(Kafka_Metadata_Partition, getErr)`
	`107`	`+ZEND_METHOD(Kafka_Metadata_Partition, getErrorCode)`
`108`	`108`	`{`
`109`	`109`	`object_intern *intern;`
`110`	`110`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ class Partition`
`8`	`8`	`{`
`9`	`9`	`public function getId(): int {}`
`10`	`10`
`11`		`- public function getErr(): int {}`
	`11`	`+ public function getErrorCode(): int {}`
`12`	`12`
`13`	`13`	`public function getLeader(): int {}`
`14`	`14`
Original file line number	Diff line number	Diff line change
`@@ -92,9 +92,9 @@ static HashTable get_debug_info(Z_KAFKA_OBJ object, int is_temp) / {{{ */`
`92`	`92`	`}`
`93`	`93`	`/* }}} */`
`94`	`94`
`95`		`-/* {{{ proto string Kafka\MetadataTopic::getTopic()`
	`95`	`+/* {{{ proto string Kafka\MetadataTopic::getName()`
`96`	`96`	`Topic name */`
`97`		`-ZEND_METHOD(Kafka_Metadata_Topic, getTopic)`
	`97`	`+ZEND_METHOD(Kafka_Metadata_Topic, getName)`
`98`	`98`	`{`
`99`	`99`	`object_intern *intern;`
`100`	`100`
`@@ -110,9 +110,9 @@ ZEND_METHOD(Kafka_Metadata_Topic, getTopic)`
`110`	`110`	`}`
`111`	`111`	`/* }}} */`
`112`	`112`
`113`		`-/* {{{ proto int Kafka\MetadataTopic::getErr()`
	`113`	`+/* {{{ proto int Kafka\MetadataTopic::getErrorCode()`
`114`	`114`	`Error */`
`115`		`-ZEND_METHOD(Kafka_Metadata_Topic, getErr)`
	`115`	`+ZEND_METHOD(Kafka_Metadata_Topic, getErrorCode)`
`116`	`116`	`{`
`117`	`117`	`object_intern *intern;`
`118`	`118`
Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,9 @@`
`6`	`6`
`7`	`7`	`class Topic`
`8`	`8`	`{`
`9`		`- public function getTopic(): string {}`
	`9`	`+ public function getName(): string {}`
`10`	`10`
`11`		`- public function getErr(): int {}`
	`11`	`+ public function getErrorCode(): int {}`
`12`	`12`
`13`	`13`	`public function getPartitions(): Collection {}`
`14`	`14`	`}`