Pimped the README.md;

Adjusted the roscon.bat to return 255 on failure, and the PHP status code otherwise;
Fixed the suggested command in the console's connection error message (needed to include protocol);
Updated wiki;
Added a trailing newline to XML and YAML files, as suggested by SensioLabsInsight.

Author: boenrobot

.scrutinizer.yml

@@ -12,4 +12,5 @@ tools:
     php_cpd: true
     php_code_sniffer:
         config:
-            standard: PEAR
+            standard: PEAR
+

README.md

@@ -1,3 +1,10 @@
-See the project wiki for installation instructions and other documentation.
+Project: [![Total Downloads](https://poser.pugx.org/pear2/net_routeros/downloads)](https://packagist.org/packages/pear2/net_routeros) [![License](https://poser.pugx.org/pear2/net_routeros/license)](https://packagist.org/packages/pear2/net_routeros)
 
-The sources as visible here reflect the development version. They may contain parsing errors, fail to install or have all other sorts of errors. If you want to use this package, download the packaged archives instead.
+Stable: [![Dependency Status](https://www.versioneye.com/php/pear2:net_routeros/dev-master/badge.svg)](https://www.versioneye.com/php/pear2:net_routeros/dev-master)
+
+Unstable: [![Dependency Status](https://www.versioneye.com/php/pear2:net_routeros/dev-develop/badge.svg)](https://www.versioneye.com/php/pear2:net_routeros/dev-develop)
+[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/pear2/Net_RouterOS/badges/quality-score.png?b=develop)](https://scrutinizer-ci.com/g/pear2/Net_RouterOS/?branch=develop)
+
+See [the project wiki](https://github.com/pear2/Net_RouterOS/wiki) for installation instructions and other documentation.
+
+You can download packaged archives (which include dependencies) from [SourceForge](http://sourceforge.net/projects/netrouteros/) or the [releases page on GitHub](https://github.com/pear2/Net_RouterOS/releases).

data/roscon.xml

@@ -108,4 +108,4 @@ Defaults to PHP's default_socket_timeout ini option.</description>
         <description>Turn on multiline mode. Without this mode, every line of input is considered a word. With it, every line is a line within the word, and the end of the word is marked instead by an "end of text" character as the only character on a line. To write out such a character, you can use ALT+Numpad3. If you want to write this character as part of the word, you can write two such characters on a line.</description>
         <action>StoreTrue</action>
     </option>
-</command>
+</command>

docs/phpdoc.dist.xml

@@ -14,4 +14,5 @@
     <transformer>
         <target>Reference/PhpDocumentor/Doc</target>
     </transformer>
-</phpdoc>
+</phpdoc>
+

docs/sami.php

@@ -1,6 +1,5 @@
 <?php
 use Sami\Sami;
-use Sami\Version\GitVersionCollection;
 use Symfony\Component\Finder\Finder;
 
 return new Sami(

docs/wiki

@@ -1,27 +1,29 @@
 @echo off
-REM Prefer PHP binary in the following order:
-REM 1. Whatever %PHPBIN% points to.
-REM 2. "php" from %cd% with one of %pathext% extensions.
-REM 3. "php" from a %path% path with one of %pathext% extensions.
-REM 4. Whatever %PHP_PEAR_PHP_BIN% points to.
-REM
-REM Once a binary is found, a file is looked for that has the same name as
-REM this batch file.
-REM Preferred extensions are ".php" and then no extension.
+:: Prefer PHP binary in the following order:
+:: 1. Whatever %PHPBIN% points to.
+:: 2. "php" from %cd% with one of %pathext% extensions.
+:: 3. "php" from a %path% path with one of %pathext% extensions.
+:: 4. Whatever %PHP_PEAR_PHP_BIN% points to.
+::
+:: Once a binary is found, a file is looked for that has the same name
+:: (including folder) as this batch file.
+:: Preferred extensions are ".php" and then no extension.
+::
+:: On failure to find PHP binary or a PHP file, this batch file returns 255.
 goto SET_BIN
 :PHP_ERR
 echo PHP interpreter not found. Please set the %%PHPBIN%% or %%PHP_PEAR_PHP_BIN%% environment variable to one, or add one to your %%PATH%%.
-goto :eof
+setlocal
+goto :END
 :FILE_ERR
 echo The file to be ran was not found. It should be at either "%~d0%~p0%~n0.php" or "%~d0%~p0%~n0".
-endlocal
-goto :eof
+goto :END
 :SET_BIN
 if "%PHPBIN%" == "" set PHPBIN=php
 where /q %PHPBIN%
 if %ERRORLEVEL% == 0 goto SET_FILE
 if "%PHP_PEAR_PHP_BIN%" == "" goto PHP_ERR
-where /q "%PHP_PEAR_PHP_BIN%"
+where /q "%PHP_PEAR_PHP_BIN%" 2>nul
 if %ERRORLEVEL% neq 0 goto PHP_ERR
 set PHPBIN=%PHP_PEAR_PHP_BIN%
 :SET_FILE
@@ -33,4 +35,7 @@ if exist "%PHPFILE%" goto RUN
 goto FILE_ERR
 :RUN
 "%PHPBIN%" "%PHPFILE%" %*
-endlocal
+set PHPBIN_ERRORLEVEL="%ERRORLEVEL%"
+:END
+if "%PHPBIN_ERRORLEVEL%" == "" set PHPBIN_ERRORLEVEL=255
+exit /B %PHPBIN_ERRORLEVEL%

scripts/roscon.bat

@@ -317,20 +317,20 @@
 6. The router has a firewall filter/mangle/nat rule that overrides the settings
    at the "/ip service" menu.
    Usually, those are rules in the "input" chain.
-   Theoretically, rules in the "prerouting", "dstnat", "output" and/or
-   "postrouting" chains can also cause such an effect.
-   By default, RouterBOARD devices have a filter rule in the "input" chain that
-   drops any incoming connections to the router from its WAN interface, so if
-   your web server is not in the LAN, the connection may be dropped because of
-   that.
-   If that's the case, either disable that rule, or explicitly whitelist the
-   API port. You can whitelist the API port on all interfaces by issuing the
-   following command from a terminal:
+   Theoretically (rarely in practice), rules in the "prerouting", "dstnat",
+   "output" and/or "postrouting" chains can also cause such an effect.
+   By default, many RouterBOARD devices have a filter rule in the "input" chain
+   that drops any incoming connections to the router from its WAN interface,
+   so if your web server is not in the LAN, the connection may be dropped
+   because of that.
+   If that's the case, either disable that rule (not recommended), or
+   explicitly whitelist the API port. You can whitelist the API port on all
+   interfaces by issuing the following command from a terminal:
    ```
-   /ip firewall filter
-       add place-before=[:pick [find where chain="input"] 0] \
-           chain="input" action="accept" \
-           dst-port=[/ip service get "api" "port"]
+   /ip firewall filter add \
+       place-before=[:pick [find where chain="input"] 0] \
+       chain="input" action="accept" \
+       protocol="tcp" dst-port=[/ip service get "api" "port"]
    ```
 
 HEREDOC

scripts/roscon.php

@@ -175,4 +175,5 @@
             <directory suffix=".php">../src/PEAR2/Net/RouterOS</directory>
         </whitelist>
     </filter>
-</phpunit>
+</phpunit>
+