Skip to content

Commit d7383ed

Browse files
authored
Declare ext/tidy constants in stubs (php#9383)
1 parent e6e26b4 commit d7383ed

File tree

3 files changed

+1032
-180
lines changed

3 files changed

+1032
-180
lines changed

ext/tidy/tidy.c

+1-179
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,6 @@
8989
} \
9090
}
9191

92-
93-
#define TIDY_TAG_CONST(tag) REGISTER_LONG_CONSTANT("TIDY_TAG_" #tag, TidyTag_##tag, CONST_CS | CONST_PERSISTENT)
94-
#define TIDY_NODE_CONST(name, type) REGISTER_LONG_CONSTANT("TIDY_NODETYPE_" #name, TidyNode_##type, CONST_CS | CONST_PERSISTENT)
95-
9692
#define TIDY_OPEN_BASE_DIR_CHECK(filename) \
9793
if (php_check_open_basedir(filename)) { \
9894
RETURN_FALSE; \
@@ -157,8 +153,6 @@ static void *php_tidy_get_opt_val(PHPTidyDoc *, TidyOption, TidyOptionType *);
157153
static void php_tidy_create_node(INTERNAL_FUNCTION_PARAMETERS, tidy_base_nodetypes);
158154
static int _php_tidy_set_tidy_opt(TidyDoc, char *, zval *);
159155
static int _php_tidy_apply_config_array(TidyDoc doc, HashTable *ht_options);
160-
static void _php_tidy_register_nodetypes(INIT_FUNC_ARGS);
161-
static void _php_tidy_register_tags(INIT_FUNC_ARGS);
162156
static PHP_INI_MH(php_tidy_set_clean_output);
163157
static void php_tidy_clean_output_start(const char *name, size_t name_len);
164158
static php_output_handler *php_tidy_output_handler_init(const char *handler_name, size_t handler_name_len, size_t chunk_size, int flags);
@@ -850,8 +844,7 @@ static PHP_MINIT_FUNCTION(tidy)
850844
tidy_object_handlers_node.offset = tidy_object_handlers_doc.offset = XtOffsetOf(PHPTidyObj, std);
851845
tidy_object_handlers_node.free_obj = tidy_object_handlers_doc.free_obj = tidy_object_free_storage;
852846

853-
_php_tidy_register_tags(INIT_FUNC_ARGS_PASSTHRU);
854-
_php_tidy_register_nodetypes(INIT_FUNC_ARGS_PASSTHRU);
847+
register_tidy_symbols(module_number);
855848

856849
php_output_handler_alias_register(ZEND_STRL("ob_tidyhandler"), php_tidy_output_handler_init);
857850

@@ -1630,175 +1623,4 @@ PHP_METHOD(tidyNode, __construct)
16301623
}
16311624
/* }}} */
16321625

1633-
static void _php_tidy_register_nodetypes(INIT_FUNC_ARGS)
1634-
{
1635-
TIDY_NODE_CONST(ROOT, Root);
1636-
TIDY_NODE_CONST(DOCTYPE, DocType);
1637-
TIDY_NODE_CONST(COMMENT, Comment);
1638-
TIDY_NODE_CONST(PROCINS, ProcIns);
1639-
TIDY_NODE_CONST(TEXT, Text);
1640-
TIDY_NODE_CONST(START, Start);
1641-
TIDY_NODE_CONST(END, End);
1642-
TIDY_NODE_CONST(STARTEND, StartEnd);
1643-
TIDY_NODE_CONST(CDATA, CDATA);
1644-
TIDY_NODE_CONST(SECTION, Section);
1645-
TIDY_NODE_CONST(ASP, Asp);
1646-
TIDY_NODE_CONST(JSTE, Jste);
1647-
TIDY_NODE_CONST(PHP, Php);
1648-
TIDY_NODE_CONST(XMLDECL, XmlDecl);
1649-
}
1650-
1651-
static void _php_tidy_register_tags(INIT_FUNC_ARGS)
1652-
{
1653-
TIDY_TAG_CONST(UNKNOWN);
1654-
TIDY_TAG_CONST(A);
1655-
TIDY_TAG_CONST(ABBR);
1656-
TIDY_TAG_CONST(ACRONYM);
1657-
TIDY_TAG_CONST(ADDRESS);
1658-
TIDY_TAG_CONST(ALIGN);
1659-
TIDY_TAG_CONST(APPLET);
1660-
TIDY_TAG_CONST(AREA);
1661-
TIDY_TAG_CONST(B);
1662-
TIDY_TAG_CONST(BASE);
1663-
TIDY_TAG_CONST(BASEFONT);
1664-
TIDY_TAG_CONST(BDO);
1665-
TIDY_TAG_CONST(BGSOUND);
1666-
TIDY_TAG_CONST(BIG);
1667-
TIDY_TAG_CONST(BLINK);
1668-
TIDY_TAG_CONST(BLOCKQUOTE);
1669-
TIDY_TAG_CONST(BODY);
1670-
TIDY_TAG_CONST(BR);
1671-
TIDY_TAG_CONST(BUTTON);
1672-
TIDY_TAG_CONST(CAPTION);
1673-
TIDY_TAG_CONST(CENTER);
1674-
TIDY_TAG_CONST(CITE);
1675-
TIDY_TAG_CONST(CODE);
1676-
TIDY_TAG_CONST(COL);
1677-
TIDY_TAG_CONST(COLGROUP);
1678-
TIDY_TAG_CONST(COMMENT);
1679-
TIDY_TAG_CONST(DD);
1680-
TIDY_TAG_CONST(DEL);
1681-
TIDY_TAG_CONST(DFN);
1682-
TIDY_TAG_CONST(DIR);
1683-
TIDY_TAG_CONST(DIV);
1684-
TIDY_TAG_CONST(DL);
1685-
TIDY_TAG_CONST(DT);
1686-
TIDY_TAG_CONST(EM);
1687-
TIDY_TAG_CONST(EMBED);
1688-
TIDY_TAG_CONST(FIELDSET);
1689-
TIDY_TAG_CONST(FONT);
1690-
TIDY_TAG_CONST(FORM);
1691-
TIDY_TAG_CONST(FRAME);
1692-
TIDY_TAG_CONST(FRAMESET);
1693-
TIDY_TAG_CONST(H1);
1694-
TIDY_TAG_CONST(H2);
1695-
TIDY_TAG_CONST(H3);
1696-
TIDY_TAG_CONST(H4);
1697-
TIDY_TAG_CONST(H5);
1698-
TIDY_TAG_CONST(H6);
1699-
TIDY_TAG_CONST(HEAD);
1700-
TIDY_TAG_CONST(HR);
1701-
TIDY_TAG_CONST(HTML);
1702-
TIDY_TAG_CONST(I);
1703-
TIDY_TAG_CONST(IFRAME);
1704-
TIDY_TAG_CONST(ILAYER);
1705-
TIDY_TAG_CONST(IMG);
1706-
TIDY_TAG_CONST(INPUT);
1707-
TIDY_TAG_CONST(INS);
1708-
TIDY_TAG_CONST(ISINDEX);
1709-
TIDY_TAG_CONST(KBD);
1710-
TIDY_TAG_CONST(KEYGEN);
1711-
TIDY_TAG_CONST(LABEL);
1712-
TIDY_TAG_CONST(LAYER);
1713-
TIDY_TAG_CONST(LEGEND);
1714-
TIDY_TAG_CONST(LI);
1715-
TIDY_TAG_CONST(LINK);
1716-
TIDY_TAG_CONST(LISTING);
1717-
TIDY_TAG_CONST(MAP);
1718-
TIDY_TAG_CONST(MARQUEE);
1719-
TIDY_TAG_CONST(MENU);
1720-
TIDY_TAG_CONST(META);
1721-
TIDY_TAG_CONST(MULTICOL);
1722-
TIDY_TAG_CONST(NOBR);
1723-
TIDY_TAG_CONST(NOEMBED);
1724-
TIDY_TAG_CONST(NOFRAMES);
1725-
TIDY_TAG_CONST(NOLAYER);
1726-
TIDY_TAG_CONST(NOSAVE);
1727-
TIDY_TAG_CONST(NOSCRIPT);
1728-
TIDY_TAG_CONST(OBJECT);
1729-
TIDY_TAG_CONST(OL);
1730-
TIDY_TAG_CONST(OPTGROUP);
1731-
TIDY_TAG_CONST(OPTION);
1732-
TIDY_TAG_CONST(P);
1733-
TIDY_TAG_CONST(PARAM);
1734-
TIDY_TAG_CONST(PLAINTEXT);
1735-
TIDY_TAG_CONST(PRE);
1736-
TIDY_TAG_CONST(Q);
1737-
TIDY_TAG_CONST(RB);
1738-
TIDY_TAG_CONST(RBC);
1739-
TIDY_TAG_CONST(RP);
1740-
TIDY_TAG_CONST(RT);
1741-
TIDY_TAG_CONST(RTC);
1742-
TIDY_TAG_CONST(RUBY);
1743-
TIDY_TAG_CONST(S);
1744-
TIDY_TAG_CONST(SAMP);
1745-
TIDY_TAG_CONST(SCRIPT);
1746-
TIDY_TAG_CONST(SELECT);
1747-
TIDY_TAG_CONST(SERVER);
1748-
TIDY_TAG_CONST(SERVLET);
1749-
TIDY_TAG_CONST(SMALL);
1750-
TIDY_TAG_CONST(SPACER);
1751-
TIDY_TAG_CONST(SPAN);
1752-
TIDY_TAG_CONST(STRIKE);
1753-
TIDY_TAG_CONST(STRONG);
1754-
TIDY_TAG_CONST(STYLE);
1755-
TIDY_TAG_CONST(SUB);
1756-
TIDY_TAG_CONST(SUP);
1757-
TIDY_TAG_CONST(TABLE);
1758-
TIDY_TAG_CONST(TBODY);
1759-
TIDY_TAG_CONST(TD);
1760-
TIDY_TAG_CONST(TEXTAREA);
1761-
TIDY_TAG_CONST(TFOOT);
1762-
TIDY_TAG_CONST(TH);
1763-
TIDY_TAG_CONST(THEAD);
1764-
TIDY_TAG_CONST(TITLE);
1765-
TIDY_TAG_CONST(TR);
1766-
TIDY_TAG_CONST(TT);
1767-
TIDY_TAG_CONST(U);
1768-
TIDY_TAG_CONST(UL);
1769-
TIDY_TAG_CONST(VAR);
1770-
TIDY_TAG_CONST(WBR);
1771-
TIDY_TAG_CONST(XMP);
1772-
# ifdef HAVE_TIDYBUFFIO_H
1773-
TIDY_TAG_CONST(ARTICLE);
1774-
TIDY_TAG_CONST(ASIDE);
1775-
TIDY_TAG_CONST(AUDIO);
1776-
TIDY_TAG_CONST(BDI);
1777-
TIDY_TAG_CONST(CANVAS);
1778-
TIDY_TAG_CONST(COMMAND);
1779-
TIDY_TAG_CONST(DATALIST);
1780-
TIDY_TAG_CONST(DETAILS);
1781-
TIDY_TAG_CONST(DIALOG);
1782-
TIDY_TAG_CONST(FIGCAPTION);
1783-
TIDY_TAG_CONST(FIGURE);
1784-
TIDY_TAG_CONST(FOOTER);
1785-
TIDY_TAG_CONST(HEADER);
1786-
TIDY_TAG_CONST(HGROUP);
1787-
TIDY_TAG_CONST(MAIN);
1788-
TIDY_TAG_CONST(MARK);
1789-
TIDY_TAG_CONST(MENUITEM);
1790-
TIDY_TAG_CONST(METER);
1791-
TIDY_TAG_CONST(NAV);
1792-
TIDY_TAG_CONST(OUTPUT);
1793-
TIDY_TAG_CONST(PROGRESS);
1794-
TIDY_TAG_CONST(SECTION);
1795-
TIDY_TAG_CONST(SOURCE);
1796-
TIDY_TAG_CONST(SUMMARY);
1797-
TIDY_TAG_CONST(TEMPLATE);
1798-
TIDY_TAG_CONST(TIME);
1799-
TIDY_TAG_CONST(TRACK);
1800-
TIDY_TAG_CONST(VIDEO);
1801-
# endif
1802-
}
1803-
18041626
#endif

0 commit comments

Comments
 (0)