php_tidy_create_node() expects a fixed set of node_types

cmb69 · cmb69 · commit ce3ff8ec7d10 · 2020-11-30T10:29:46.000+01:00
This static function is not supposed to deal with arbitrary `node_type`s, so there is no need to do so. Closes phpGH-6467.
diff --git a/ext/tidy/tidy.c b/ext/tidy/tidy.c
@@ -770,9 +770,7 @@ static void php_tidy_create_node(INTERNAL_FUNCTION_PARAMETERS, tidy_base_nodetyp
 			node = tidyGetBody(obj->ptdoc->doc);
 			break;
 
-		default:
-			RETURN_NULL();
-			break;
+		EMPTY_SWITCH_DEFAULT_CASE()
 	}
 
 	if (!node) {

Original file line number	Diff line number	Diff line change
`@@ -770,9 +770,7 @@ static void php_tidy_create_node(INTERNAL_FUNCTION_PARAMETERS, tidy_base_nodetyp`
`770`	`770`	`node = tidyGetBody(obj->ptdoc->doc);`
`771`	`771`	`break;`
`772`	`772`
`773`		`- default:`
`774`		`- RETURN_NULL();`
`775`		`- break;`
	`773`	`+ EMPTY_SWITCH_DEFAULT_CASE()`
`776`	`774`	`}`
`777`	`775`
`778`	`776`	`if (!node) {`