Ilia Alshanetsky · Ilia Alshanetsky · commit ae2c5ee7d49a · 2009-06-30T12:20:35.000Z
MFB: Fixed bug #48465 (sys_get_temp_dir() possibly inconsistent when using
TMPDIR).
diff --git a/main/php_open_temporary_file.c b/main/php_open_temporary_file.c
@@ -199,8 +199,15 @@ PHPAPI const char* php_get_temporary_directory(void)
 	/* On Unix use the (usual) TMPDIR environment variable. */
 	{
 		char* s = getenv("TMPDIR");
-		if (s) {
-			temporary_directory = strdup(s);
+		if (s && *s) {
+			int len = strlen(s);
+
+			if (s[len - 1] == DEFAULT_SLASH) {
+				temporary_directory = zend_strndup(s, len - 1);
+			} else {
+				temporary_directory = zend_strndup(s, len);
+			}
+
 			return temporary_directory;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -199,8 +199,15 @@ PHPAPI const char* php_get_temporary_directory(void)`
`199`	`199`	`/* On Unix use the (usual) TMPDIR environment variable. */`
`200`	`200`	`{`
`201`	`201`	`char* s = getenv("TMPDIR");`
`202`		`- if (s) {`
`203`		`- temporary_directory = strdup(s);`
	`202`	`+ if (s && *s) {`
	`203`	`+ int len = strlen(s);`
	`204`	`+`
	`205`	`+ if (s[len - 1] == DEFAULT_SLASH) {`
	`206`	`+ temporary_directory = zend_strndup(s, len - 1);`
	`207`	`+ } else {`
	`208`	`+ temporary_directory = zend_strndup(s, len);`
	`209`	`+ }`
	`210`	`+`
`204`	`211`	`return temporary_directory;`
`205`	`212`	`}`
`206`	`213`	`}`