Skip to content

Commit 6a51062

Browse files
committed
Drop unused, but confusing macro definition (phpGH-15541)
`PHP7DLLTS_EXPORTS` is not used throughout php-src, and it's unlikely that it is used by any extension, especially since it still refers to PHP 7. The symbol had been introduced in 2014[1], but is not even used in latest PHP-7.4; probably it was just supposed to be used, or part of phpng. [1] <php@fc734cf> Since CI already ran for the PR, we can now [skip ci].
1 parent 35fbb00 commit 6a51062

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

win32/build/confutils.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3241,7 +3241,7 @@ function toolset_setup_common_cflags()
32413241
var envCFLAGS = WshShell.Environment("PROCESS").Item("CFLAGS");
32423242

32433243
// CFLAGS for building the PHP dll
3244-
DEFINE("CFLAGS_PHP", "/D _USRDLL /D PHP7DLLTS_EXPORTS /D PHP_EXPORTS \
3244+
DEFINE("CFLAGS_PHP", "/D _USRDLL /D PHP_EXPORTS \
32453245
/D LIBZEND_EXPORTS /D TSRM_EXPORTS /D SAPI_EXPORTS /D WINVER=" + WINVER);
32463246

32473247
DEFINE('CFLAGS_PHP_OBJ', '$(CFLAGS_PHP) $(STATIC_EXT_CFLAGS)');

0 commit comments

Comments
 (0)