-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Inconsistency when converting week PeriodIndex into DatetimeIndex with astype("datetime64[ns]") #61177
Comments
period_index.astype("datetime64[ns]")[0] why is this supposed to return period end not period start. I don't understand why is this an error here |
I think the problem comes from how Pandas converts Period to Timestamp. You try to convert an index of Period to an index of Timestamp and this give the first day of the weekly period. For example when you run: the result will be: but when you run: the result will be: and will convert just first day of each week like this: |
@omaraymanatia , I would like to clarify where the confusion appears. Usually, Pandas uses right border value (Sundays) as a label for a week periods when we working with bins. As @BahramF73 mentioned, converting the period into a single date using
I fully understand that type conversion is not the right way to change the frequency, and we should explicitly use the appropriate period manipulation function instead. However, I believe it would be beneficial if Pandas could provide an informative warning message to the developer to avoid incorrect ways to work with Periods. This is exactly what happened in our case. We have two functions: one returns Mondays and another Sundays, while both look legit at first glance. My current approach is to explicitly convert the values with
It makes the code more readable but may have a performance penalty. |
It may be incorrect for your use case, but is it incorrect for all? If not, then pandas should not warn. At a glance, it does seem like |
Pandas version checks
I have checked that this issue has not already been reported.
I have confirmed this bug exists on the latest version of pandas.
I have confirmed this bug exists on the main branch of pandas.
Reproducible Example
Issue Description
Let's imagine you have a column with dates:
We want to convert them into a week period, with each date replaced with the period label. We will use the default frequency
W
, with each date replaced with the period ending on the preceding Sunday:Let's create a
PeriodIndex
where each date value is replaced withPeriod
objectThen we would like to take only one day instead of
PeriodIndex
. The simplest solution is to convert the column type intodatetime64[ns]
:However, an unexpected day appears. Instead of period end
2018-01-07
, pandas returns period start:Expected Behavior
There is a trick that helps to fix this behavior. Firstly, we convert the
Period
values back to daily frequency and then transform intodatetime64[ns]
:Such behavior should be documented or/and the warning should be raised that direct conversion of the
PeriodIndex
into"datetime64[ns]"
is not aligned with expected behavior.Installed Versions
INSTALLED VERSIONS
commit : 0691c5c
python : 3.11.7
python-bits : 64
OS : Linux
OS-release : 5.15.167.4-microsoft-standard-WSL2
Version : #1 SMP Tue Nov 5 00:21:55 UTC 2024
machine : x86_64
processor : x86_64
byteorder : little
LC_ALL : None
LANG : C.UTF-8
LOCALE : en_US.UTF-8
pandas : 2.2.3
numpy : 1.26.3
pytz : 2025.1
dateutil : 2.8.2
pip : 23.2.1
Cython : None
sphinx : None
IPython : 8.20.0
adbc-driver-postgresql: None
adbc-driver-sqlite : None
bs4 : 4.12.3
blosc : None
bottleneck : None
dataframe-api-compat : None
fastparquet : None
fsspec : 2023.12.2
html5lib : None
hypothesis : None
gcsfs : 2023.12.2post1
jinja2 : 3.1.3
lxml.etree : None
matplotlib : 3.8.2
numba : 0.60.0
numexpr : None
odfpy : None
openpyxl : 3.1.2
pandas_gbq : None
psycopg2 : None
pymysql : None
pyarrow : 14.0.2
pyreadstat : None
pytest : 7.4.4
python-calamine : None
pyxlsb : None
s3fs : 2023.12.2
scipy : 1.12.0
sqlalchemy : 2.0.29
tables : None
tabulate : 0.9.0
xarray : None
xlrd : None
xlsxwriter : None
zstandard : None
tzdata : 2023.4
qtpy : None
pyqt5 : None
The text was updated successfully, but these errors were encountered: