Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: upcasting-fallback in NDFrame.shift #53802

Open
jbrockmendel opened this issue Jun 22, 2023 · 1 comment
Open

DEPR: upcasting-fallback in NDFrame.shift #53802

jbrockmendel opened this issue Jun 22, 2023 · 1 comment
Labels
Datetime Datetime data dtype Deprecate Functionality to remove in pandas Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Jun 22, 2023 •
edited
Loading

Analogous to PDEP-6, I think we should deprecate the fallback behavior of upcasting when an invalid fill_value is passed.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 22, 2023
@lithomas1 lithomas1 added Datetime Datetime data dtype Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Dtype Conversions Unexpected or buggy dtype conversions Deprecate Functionality to remove in pandas and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 23, 2023
@jbrockmendel jbrockmendel mentioned this issue Jun 24, 2023
Merged
@jbrockmendel
Copy link
Member Author

Could keep this for int->float, which is what you'd get if you don't pass a fill_value.

This was referenced Jun 26, 2023
Open
Open
@jbrockmendel jbrockmendel mentioned this issue Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Datetime Datetime data dtype Deprecate Functionality to remove in pandas Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrockmendel @lithomas1