Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation error type SA05 and check in CI #25194

Closed
2 tasks
MarckK opened this issue Feb 6, 2019 · 1 comment
Closed
2 tasks

Fix validation error type SA05 and check in CI #25194

MarckK opened this issue Feb 6, 2019 · 1 comment
Labels
CI Continuous Integration Code Style Code style, linting, code_checks
Milestone

Comments

@MarckK
Copy link
Contributor

MarckK commented Feb 6, 2019

Problem description

In order to have a continuous check by the CI on validation error SA05 (Reference name in See Also section does not need pandas prefix, use correct reference instead), fixing them in the code base enables the addition to the CI for automated testing in the future.

SA05 has just 96 occurrences (see overview of the errors), including:

method file file_line github_link
pandas.CategoricalDtype pandas/core/dtypes/dtypes.py 175.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/dtypes/dtypes.py#L175
pandas.Categorical pandas/core/arrays/categorical.py 215.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/arrays/categorical.py#L215
pandas.api.extensions.ExtensionDtype pandas/core/dtypes/base.py 148.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/dtypes/base.py#L148
pandas.DataFrame.dtypes pandas/core/generic.py 5462.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/generic.py#L5462
pandas.DataFrame.ftypes pandas/core/generic.py 5498.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/generic.py#L5498
pandas.DataFrame.values pandas/core/generic.py 5255.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/generic.py#L5255
pandas.DataFrame.get_values pandas/core/generic.py 5342.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/generic.py#L5342
pandas.DataFrame.memory_usage pandas/core/frame.py 2475.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L2475
pandas.DataFrame.empty pandas/core/generic.py 1849.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/generic.py#L1849
pandas.DataFrame.agg pandas/core/frame.py 6248.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L6248
pandas.DataFrame.aggregate pandas/core/frame.py 6248.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L6248
pandas.DataFrame.cov pandas/core/frame.py 7040.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L7040
pandas.DataFrame.eval pandas/core/frame.py 3082.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L3082
pandas.DataFrame.rename pandas/util/_decorators.py 3922.0 https://github.com/pandas-dev/pandas/blob/master/pandas/util/_decorators.py#L3922
pandas.DataFrame.append pandas/core/frame.py 6532.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L6532
pandas.DataFrame.plot.bar pandas/plotting/_core.py 3005.0 https://github.com/pandas-dev/pandas/blob/master/pandas/plotting/_core.py#L3005
pandas.DataFrame.plot.barh pandas/plotting/_core.py 3090.0 https://github.com/pandas-dev/pandas/blob/master/pandas/plotting/_core.py#L3090
pandas.DataFrame.plot.box pandas/plotting/_core.py 3170.0 https://github.com/pandas-dev/pandas/blob/master/pandas/plotting/_core.py#L3170
pandas.DataFrame.from_csv pandas/core/frame.py 1838.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L1838
pandas.DataFrame.to_gbq pandas/core/frame.py 1324.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L1324
pandas.DataFrame.style pandas/core/frame.py 730.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L730
pandas.cut pandas/core/reshape/tile.py 23.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/reshape/tile.py#L23
pandas.unique pandas/core/algorithms.py 278.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/algorithms.py#L278
pandas.to_numeric pandas/core/tools/numeric.py 14.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/tools/numeric.py#L14
pandas.to_datetime pandas/core/tools/datetimes.py 401.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/tools/datetimes.py#L401
pandas.date_range pandas/core/indexes/datetimes.py 1379.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/indexes/datetimes.py#L1379
pandas.eval pandas/core/computation/eval.py 156.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/computation/eval.py#L156
pandas.errors.DtypeWarning pandas/errors/init.py 38.0 https://github.com/pandas-dev/pandas/blob/master/pandas/errors/__init__.py#L38
pandas.api.types.is_number pandas/core/dtypes/inference.py 29.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/dtypes/inference.py#L29
pandas.core.groupby.GroupBy.pipe pandas/core/groupby/groupby.py 538.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/groupby/groupby.py#L538
... ... ... ...
pandas.read_stata pandas/util/_decorators.py 171.0 https://github.com/pandas-dev/pandas/blob/master/pandas/util/_decorators.py#L171
pandas.tseries.frequencies.to_offset pandas/tseries/frequencies.py 59.0 https://github.com/pandas-dev/pandas/blob/master/pandas/tseries/frequencies.py#L59
pandas.Panel.values pandas/core/generic.py 5255.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/generic.py#L5255
pandas.Panel.dtypes pandas/core/generic.py 5462.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/generic.py#L5462
pandas.Panel.ftypes pandas/core/generic.py 5498.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/generic.py#L5498
pandas.Panel.rename pandas/core/panel.py 1251.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/panel.py#L1251
pandas.plotting.bootstrap_plot pandas/plotting/_misc.py 363.0 https://github.com/pandas-dev/pandas/blob/master/pandas/plotting/_misc.py#L363
pandas.plotting.radviz pandas/plotting/_misc.py 146.0 https://github.com/pandas-dev/pandas/blob/master/pandas/plotting/_misc.py#L146
pandas.core.resample.Resampler.apply pandas/core/resample.py 257.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L257
pandas.core.resample.Resampler.aggregate pandas/core/resample.py 257.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L257
pandas.core.resample.Resampler.pipe pandas/core/resample.py 189.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L189
pandas.core.resample.Resampler.backfill pandas/core/resample.py 492.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L492
pandas.core.resample.Resampler.bfill pandas/core/resample.py 492.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L492
pandas.core.resample.Resampler.fillna pandas/core/resample.py 596.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L596
pandas.core.resample.Resampler.count pandas/core/resample.py 865.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L865
pandas.core.resample.Resampler.mean pandas/core/resample.py 857.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L857
pandas.core.resample.Resampler.median pandas/core/resample.py 857.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L857
pandas.core.resample.Resampler.ohlc pandas/core/resample.py 857.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L857
pandas.core.resample.Resampler.size pandas/core/resample.py 815.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L815
pandas.core.resample.Resampler.sem pandas/core/resample.py 857.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L857
pandas.Series.array pandas/core/series.py 670.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/series.py#L670
pandas.io.formats.style.Styler pandas/io/formats/style.py 55.0 https://github.com/pandas-dev/pandas/blob/master/pandas/io/formats/style.py#L55
pandas.core.window.Rolling.count pandas/core/window.py 1689.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/window.py#L1689
pandas.core.window.Rolling.aggregate pandas/core/window.py 1678.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/window.py#L1678
pandas.core.window.Rolling.quantile pandas/core/window.py 1783.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/window.py#L1783
pandas.core.window.Expanding.count pandas/core/window.py 1967.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/window.py#L1967
pandas.core.window.Expanding.aggregate pandas/core/window.py 1956.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/window.py#L1956
pandas.core.window.Expanding.quantile pandas/core/window.py 2056.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/window.py#L2056
pandas.Panel.empty pandas/core/generic.py 1849.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/generic.py#L1849
pandas.Panel.get_values pandas/core/generic.py 5342.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/generic.py#L5342

Todo:

  • get rid of the errors in the code base
  • update the code_check.sh script to take into account the SS02 type of errors
@MarckK
Copy link
Contributor Author

MarckK commented Feb 6, 2019

I'm working on this. :)

@gfyoung gfyoung added CI Continuous Integration Code Style Code style, linting, code_checks labels Feb 7, 2019
@jreback jreback added this to the 0.25.0 milestone Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Code Style Code style, linting, code_checks
Projects
None yet
Development

No branches or pull requests

3 participants