Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: missing pandas.version submodule #11381

Closed
rgommers opened this issue Oct 20, 2015 · 2 comments
Closed

BUG: missing pandas.version submodule #11381

rgommers opened this issue Oct 20, 2015 · 2 comments
Labels
Compat pandas objects compatability with Numpy or Python functions

Comments

@rgommers
Copy link
Contributor

The public pandas.version submodule seems to have been removed without any deprecation warning beforehand in gh-10370. This causes a number of test failures for statsmodels.

@jreback
Copy link
Contributor

jreback commented Oct 20, 2015

pandas.version was a private, undocumented version string module.

pandas.__version__ has always been (and is) the version tag. the module just implemented it (which is what changed here)

apologize @josef-pkt

@jreback jreback closed this as completed Oct 20, 2015
@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Oct 20, 2015
@rgommers
Copy link
Contributor Author

That's a very strange definition of private. Anything that doesn't start with an underscore and is in the main namespace is public simply by being there in pretty much any Python project I know. And in this case the write_version approach was simply copied from numpy/scipy, where the version module is definitely public.

But well, it's up to you to decide here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

No branches or pull requests

2 participants