Skip to content

Commit 5146b59

Browse files
gfyoungjorisvandenbossche
authored andcommittedApr 16, 2017
MAINT: Remove tm.assertIsNot from testing (#16024)
1 parent f60b914 commit 5146b59

22 files changed

+194
-183
lines changed
 

‎pandas/tests/core/sparse/test_frame.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -422,24 +422,24 @@ def test_iloc(self):
422422

423423
def test_set_value(self):
424424

425-
# ok as the index gets conver to object
425+
# ok, as the index gets converted to object
426426
frame = self.frame.copy()
427427
res = frame.set_value('foobar', 'B', 1.5)
428-
self.assertEqual(res.index.dtype, 'object')
428+
assert res.index.dtype == 'object'
429429

430430
res = self.frame
431431
res.index = res.index.astype(object)
432432

433433
res = self.frame.set_value('foobar', 'B', 1.5)
434-
self.assertIsNot(res, self.frame)
435-
self.assertEqual(res.index[-1], 'foobar')
436-
self.assertEqual(res.get_value('foobar', 'B'), 1.5)
434+
assert res is not self.frame
435+
assert res.index[-1] == 'foobar'
436+
assert res.get_value('foobar', 'B') == 1.5
437437

438438
res2 = res.set_value('foobar', 'qux', 1.5)
439-
self.assertIsNot(res2, res)
440-
self.assert_index_equal(res2.columns,
441-
pd.Index(list(self.frame.columns) + ['qux']))
442-
self.assertEqual(res2.get_value('foobar', 'qux'), 1.5)
439+
assert res2 is not res
440+
tm.assert_index_equal(res2.columns,
441+
pd.Index(list(self.frame.columns) + ['qux']))
442+
assert res2.get_value('foobar', 'qux') == 1.5
443443

444444
def test_fancy_index_misc(self):
445445
# axis = 0

‎pandas/tests/core/sparse/test_indexing.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# pylint: disable-msg=E1101,W0612
22

3-
import pytest # noqa
3+
import pytest
44
import numpy as np
55
import pandas as pd
66
import pandas.util.testing as tm
@@ -578,15 +578,15 @@ def test_reindex(self):
578578
exp = orig.reindex(['A'], level=0).to_sparse()
579579
tm.assert_sp_series_equal(res, exp)
580580

581-
with tm.assertRaises(TypeError):
581+
with pytest.raises(TypeError):
582582
# Incomplete keys are not accepted for reindexing:
583583
sparse.reindex(['A', 'C'])
584584

585585
# "copy" argument:
586586
res = sparse.reindex(sparse.index, copy=True)
587587
exp = orig.reindex(orig.index, copy=True).to_sparse()
588588
tm.assert_sp_series_equal(res, exp)
589-
self.assertIsNot(sparse, res)
589+
assert sparse is not res
590590

591591

592592
class TestSparseDataFrameIndexing(tm.TestCase):

‎pandas/tests/core/sparse/test_series.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -314,9 +314,9 @@ def test_constructor_empty(self):
314314

315315
def test_copy_astype(self):
316316
cop = self.bseries.astype(np.float64)
317-
self.assertIsNot(cop, self.bseries)
318-
self.assertIs(cop.sp_index, self.bseries.sp_index)
319-
self.assertEqual(cop.dtype, np.float64)
317+
assert cop is not self.bseries
318+
assert cop.sp_index is self.bseries.sp_index
319+
assert cop.dtype == np.float64
320320

321321
cop2 = self.iseries.copy()
322322

@@ -325,8 +325,8 @@ def test_copy_astype(self):
325325

326326
# test that data is copied
327327
cop[:5] = 97
328-
self.assertEqual(cop.sp_values[0], 97)
329-
self.assertNotEqual(self.bseries.sp_values[0], 97)
328+
assert cop.sp_values[0] == 97
329+
assert self.bseries.sp_values[0] != 97
330330

331331
# correct fill value
332332
zbcop = self.zbseries.copy()
@@ -338,7 +338,7 @@ def test_copy_astype(self):
338338
# no deep copy
339339
view = self.bseries.copy(deep=False)
340340
view.sp_values[:5] = 5
341-
self.assertTrue((self.bseries.sp_values[:5] == 5).all())
341+
assert (self.bseries.sp_values[:5] == 5).all()
342342

343343
def test_shape(self):
344344
# GH 10452
@@ -639,7 +639,7 @@ def _compare_with_series(sps, new_index):
639639
# special cases
640640
same_index = self.bseries.reindex(self.bseries.index)
641641
tm.assert_sp_series_equal(self.bseries, same_index)
642-
self.assertIsNot(same_index, self.bseries)
642+
assert same_index is not self.bseries
643643

644644
# corner cases
645645
sp = SparseSeries([], index=[])
@@ -650,7 +650,7 @@ def _compare_with_series(sps, new_index):
650650
# with copy=False
651651
reindexed = self.bseries.reindex(self.bseries.index, copy=True)
652652
reindexed.sp_values[:] = 1.
653-
self.assertTrue((self.bseries.sp_values != 1.).all())
653+
assert (self.bseries.sp_values != 1.).all()
654654

655655
reindexed = self.bseries.reindex(self.bseries.index, copy=False)
656656
reindexed.sp_values[:] = 1.
@@ -824,7 +824,7 @@ def test_shift(self):
824824
series = SparseSeries([nan, 1., 2., 3., nan, nan], index=np.arange(6))
825825

826826
shifted = series.shift(0)
827-
self.assertIsNot(shifted, series)
827+
assert shifted is not series
828828
tm.assert_sp_series_equal(shifted, series)
829829

830830
f = lambda s: s.shift(1)

‎pandas/tests/frame/test_axis_select_reindex.py

+30-26
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
from __future__ import print_function
44

5+
import pytest
6+
57
from datetime import datetime
68

79
from numpy import random
@@ -409,33 +411,35 @@ def test_reindex_dups(self):
409411

410412
def test_align(self):
411413
af, bf = self.frame.align(self.frame)
412-
self.assertIsNot(af._data, self.frame._data)
414+
assert af._data is not self.frame._data
413415

414416
af, bf = self.frame.align(self.frame, copy=False)
415-
self.assertIs(af._data, self.frame._data)
417+
assert af._data is self.frame._data
416418

417419
# axis = 0
418420
other = self.frame.iloc[:-5, :3]
419421
af, bf = self.frame.align(other, axis=0, fill_value=-1)
420-
self.assert_index_equal(bf.columns, other.columns)
422+
423+
tm.assert_index_equal(bf.columns, other.columns)
424+
421425
# test fill value
422426
join_idx = self.frame.index.join(other.index)
423427
diff_a = self.frame.index.difference(join_idx)
424428
diff_b = other.index.difference(join_idx)
425429
diff_a_vals = af.reindex(diff_a).values
426430
diff_b_vals = bf.reindex(diff_b).values
427-
self.assertTrue((diff_a_vals == -1).all())
431+
assert (diff_a_vals == -1).all()
428432

429433
af, bf = self.frame.align(other, join='right', axis=0)
430-
self.assert_index_equal(bf.columns, other.columns)
431-
self.assert_index_equal(bf.index, other.index)
432-
self.assert_index_equal(af.index, other.index)
434+
tm.assert_index_equal(bf.columns, other.columns)
435+
tm.assert_index_equal(bf.index, other.index)
436+
tm.assert_index_equal(af.index, other.index)
433437

434438
# axis = 1
435439
other = self.frame.iloc[:-5, :3].copy()
436440
af, bf = self.frame.align(other, axis=1)
437-
self.assert_index_equal(bf.columns, self.frame.columns)
438-
self.assert_index_equal(bf.index, other.index)
441+
tm.assert_index_equal(bf.columns, self.frame.columns)
442+
tm.assert_index_equal(bf.index, other.index)
439443

440444
# test fill value
441445
join_idx = self.frame.index.join(other.index)
@@ -446,42 +450,42 @@ def test_align(self):
446450
# TODO(wesm): unused?
447451
diff_b_vals = bf.reindex(diff_b).values # noqa
448452

449-
self.assertTrue((diff_a_vals == -1).all())
453+
assert (diff_a_vals == -1).all()
450454

451455
af, bf = self.frame.align(other, join='inner', axis=1)
452-
self.assert_index_equal(bf.columns, other.columns)
456+
tm.assert_index_equal(bf.columns, other.columns)
453457

454458
af, bf = self.frame.align(other, join='inner', axis=1, method='pad')
455-
self.assert_index_equal(bf.columns, other.columns)
459+
tm.assert_index_equal(bf.columns, other.columns)
456460

457461
# test other non-float types
458462
af, bf = self.intframe.align(other, join='inner', axis=1, method='pad')
459-
self.assert_index_equal(bf.columns, other.columns)
463+
tm.assert_index_equal(bf.columns, other.columns)
460464

461465
af, bf = self.mixed_frame.align(self.mixed_frame,
462466
join='inner', axis=1, method='pad')
463-
self.assert_index_equal(bf.columns, self.mixed_frame.columns)
467+
tm.assert_index_equal(bf.columns, self.mixed_frame.columns)
464468

465469
af, bf = self.frame.align(other.iloc[:, 0], join='inner', axis=1,
466470
method=None, fill_value=None)
467-
self.assert_index_equal(bf.index, Index([]))
471+
tm.assert_index_equal(bf.index, Index([]))
468472

469473
af, bf = self.frame.align(other.iloc[:, 0], join='inner', axis=1,
470474
method=None, fill_value=0)
471-
self.assert_index_equal(bf.index, Index([]))
475+
tm.assert_index_equal(bf.index, Index([]))
472476

473477
# mixed floats/ints
474478
af, bf = self.mixed_float.align(other.iloc[:, 0], join='inner', axis=1,
475479
method=None, fill_value=0)
476-
self.assert_index_equal(bf.index, Index([]))
480+
tm.assert_index_equal(bf.index, Index([]))
477481

478482
af, bf = self.mixed_int.align(other.iloc[:, 0], join='inner', axis=1,
479483
method=None, fill_value=0)
480-
self.assert_index_equal(bf.index, Index([]))
484+
tm.assert_index_equal(bf.index, Index([]))
481485

482-
# try to align dataframe to series along bad axis
483-
self.assertRaises(ValueError, self.frame.align, af.iloc[0, :3],
484-
join='inner', axis=2)
486+
# Try to align DataFrame to Series along bad axis
487+
with pytest.raises(ValueError):
488+
self.frame.align(af.iloc[0, :3], join='inner', axis=2)
485489

486490
# align dataframe to series with broadcast or not
487491
idx = self.frame.index
@@ -490,7 +494,7 @@ def test_align(self):
490494
left, right = self.frame.align(s, axis=0)
491495
tm.assert_index_equal(left.index, self.frame.index)
492496
tm.assert_index_equal(right.index, self.frame.index)
493-
self.assertTrue(isinstance(right, Series))
497+
assert isinstance(right, Series)
494498

495499
left, right = self.frame.align(s, broadcast_axis=1)
496500
tm.assert_index_equal(left.index, self.frame.index)
@@ -499,17 +503,17 @@ def test_align(self):
499503
expected[c] = s
500504
expected = DataFrame(expected, index=self.frame.index,
501505
columns=self.frame.columns)
502-
assert_frame_equal(right, expected)
506+
tm.assert_frame_equal(right, expected)
503507

504-
# GH 9558
508+
# see gh-9558
505509
df = DataFrame({'a': [1, 2, 3], 'b': [4, 5, 6]})
506510
result = df[df['a'] == 2]
507511
expected = DataFrame([[2, 5]], index=[1], columns=['a', 'b'])
508-
assert_frame_equal(result, expected)
512+
tm.assert_frame_equal(result, expected)
509513

510514
result = df.where(df['a'] == 2, 0)
511515
expected = DataFrame({'a': [0, 2, 0], 'b': [0, 5, 0]})
512-
assert_frame_equal(result, expected)
516+
tm.assert_frame_equal(result, expected)
513517

514518
def _check_align(self, a, b, axis, fill_axis, how, method, limit=None):
515519
aa, ab = a.align(b, axis=axis, join=how, method=method, limit=limit,

‎pandas/tests/frame/test_block_internals.py

+8-7
Original file line numberDiff line numberDiff line change
@@ -41,17 +41,18 @@ def test_cast_internals(self):
4141
def test_consolidate(self):
4242
self.frame['E'] = 7.
4343
consolidated = self.frame._consolidate()
44-
self.assertEqual(len(consolidated._data.blocks), 1)
44+
assert len(consolidated._data.blocks) == 1
4545

4646
# Ensure copy, do I want this?
4747
recons = consolidated._consolidate()
48-
self.assertIsNot(recons, consolidated)
49-
assert_frame_equal(recons, consolidated)
48+
assert recons is not consolidated
49+
tm.assert_frame_equal(recons, consolidated)
5050

5151
self.frame['F'] = 8.
52-
self.assertEqual(len(self.frame._data.blocks), 3)
52+
assert len(self.frame._data.blocks) == 3
53+
5354
self.frame._consolidate(inplace=True)
54-
self.assertEqual(len(self.frame._data.blocks), 1)
55+
assert len(self.frame._data.blocks) == 1
5556

5657
def test_consolidate_deprecation(self):
5758
self.frame['E'] = 7
@@ -343,11 +344,11 @@ def test_no_copy_blocks(self):
343344
def test_copy(self):
344345
cop = self.frame.copy()
345346
cop['E'] = cop['A']
346-
self.assertNotIn('E', self.frame)
347+
assert 'E' not in self.frame
347348

348349
# copy objects
349350
copy = self.mixed_frame.copy()
350-
self.assertIsNot(copy._data, self.mixed_frame._data)
351+
assert copy._data is not self.mixed_frame._data
351352

352353
def test_pickle(self):
353354
unpickled = tm.round_trip_pickle(self.mixed_frame)

‎pandas/tests/frame/test_indexing.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -672,19 +672,19 @@ def test_setitem_ambig(self):
672672
self.assertEqual(dm[2].dtype, np.object_)
673673

674674
def test_setitem_clear_caches(self):
675-
# GH #304
675+
# see gh-304
676676
df = DataFrame({'x': [1.1, 2.1, 3.1, 4.1], 'y': [5.1, 6.1, 7.1, 8.1]},
677677
index=[0, 1, 2, 3])
678678
df.insert(2, 'z', np.nan)
679679

680680
# cache it
681681
foo = df['z']
682-
683682
df.loc[df.index[2:], 'z'] = 42
684683

685684
expected = Series([np.nan, np.nan, 42, 42], index=df.index, name='z')
686-
self.assertIsNot(df['z'], foo)
687-
assert_series_equal(df['z'], expected)
685+
686+
assert df['z'] is not foo
687+
tm.assert_series_equal(df['z'], expected)
688688

689689
def test_setitem_None(self):
690690
# GH #766

‎pandas/tests/frame/test_missing.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -403,18 +403,18 @@ def test_fillna_inplace(self):
403403
df[3][-4:] = np.nan
404404

405405
expected = df.fillna(value=0)
406-
self.assertIsNot(expected, df)
406+
assert expected is not df
407407

408408
df.fillna(value=0, inplace=True)
409-
assert_frame_equal(df, expected)
409+
tm.assert_frame_equal(df, expected)
410410

411411
df[1][:4] = np.nan
412412
df[3][-4:] = np.nan
413413
expected = df.fillna(method='ffill')
414-
self.assertIsNot(expected, df)
414+
assert expected is not df
415415

416416
df.fillna(method='ffill', inplace=True)
417-
assert_frame_equal(df, expected)
417+
tm.assert_frame_equal(df, expected)
418418

419419
def test_fillna_dict_series(self):
420420
df = DataFrame({'a': [nan, 1, 2, nan, nan],

‎pandas/tests/frame/test_timeseries.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
import pandas as pd
1515
import pandas.tseries.offsets as offsets
1616

17-
from pandas.util.testing import (assert_almost_equal,
18-
assert_series_equal,
17+
from pandas.util.testing import (assert_series_equal,
1918
assert_frame_equal,
2019
assertRaisesRegexp)
2120

@@ -355,7 +354,7 @@ def test_asfreq(self):
355354
offset_monthly = self.tsframe.asfreq(offsets.BMonthEnd())
356355
rule_monthly = self.tsframe.asfreq('BM')
357356

358-
assert_almost_equal(offset_monthly['A'], rule_monthly['A'])
357+
tm.assert_almost_equal(offset_monthly['A'], rule_monthly['A'])
359358

360359
filled = rule_monthly.asfreq('B', method='pad') # noqa
361360
# TODO: actually check that this worked.
@@ -366,7 +365,7 @@ def test_asfreq(self):
366365
# test does not blow up on length-0 DataFrame
367366
zero_length = self.tsframe.reindex([])
368367
result = zero_length.asfreq('BM')
369-
self.assertIsNot(result, zero_length)
368+
assert result is not zero_length
370369

371370
def test_asfreq_datetimeindex(self):
372371
df = DataFrame({'A': [1, 2, 3]},

‎pandas/tests/indexes/common.py

+16-12
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,9 @@ def test_hash_error(self):
214214
hash(ind)
215215

216216
def test_copy_name(self):
217-
# Check that "name" argument passed at initialization is honoured
218-
# GH12309
217+
# gh-12309: Check that the "name" argument
218+
# passed at initialization is honored.
219+
219220
for name, index in compat.iteritems(self.indices):
220221
if isinstance(index, MultiIndex):
221222
continue
@@ -224,18 +225,21 @@ def test_copy_name(self):
224225
second = first.__class__(first, copy=False)
225226

226227
# Even though "copy=False", we want a new object.
227-
self.assertIsNot(first, second)
228-
# Not using tm.assert_index_equal() since names differ:
229-
self.assertTrue(index.equals(first))
228+
assert first is not second
230229

231-
self.assertEqual(first.name, 'mario')
232-
self.assertEqual(second.name, 'mario')
230+
# Not using tm.assert_index_equal() since names differ.
231+
assert index.equals(first)
232+
233+
assert first.name == 'mario'
234+
assert second.name == 'mario'
233235

234236
s1 = Series(2, index=first)
235237
s2 = Series(3, index=second[:-1])
236-
if not isinstance(index, CategoricalIndex): # See GH13365
238+
239+
if not isinstance(index, CategoricalIndex):
240+
# See gh-13365
237241
s3 = s1 * s2
238-
self.assertEqual(s3.index.name, 'mario')
242+
assert s3.index.name == 'mario'
239243

240244
def test_ensure_copied_data(self):
241245
# Check the "copy" argument of each Index.__new__ is honoured
@@ -283,11 +287,11 @@ def test_copy_and_deepcopy(self):
283287

284288
for func in (copy, deepcopy):
285289
idx_copy = func(ind)
286-
self.assertIsNot(idx_copy, ind)
287-
self.assertTrue(idx_copy.equals(ind))
290+
assert idx_copy is not ind
291+
assert idx_copy.equals(ind)
288292

289293
new_copy = ind.copy(deep=True, name="banana")
290-
self.assertEqual(new_copy.name, "banana")
294+
assert new_copy.name == "banana"
291295

292296
def test_duplicates(self):
293297
for ind in self.indices.values():

‎pandas/tests/indexes/test_base.py

+10-10
Original file line numberDiff line numberDiff line change
@@ -1851,22 +1851,22 @@ def test_copy_name(self):
18511851
second = first.__class__(first, copy=False)
18521852

18531853
# Even though "copy=False", we want a new object.
1854-
self.assertIsNot(first, second)
1854+
assert first is not second
18551855
# Not using tm.assert_index_equal() since names differ:
1856-
self.assertTrue(idx.equals(first))
1856+
assert idx.equals(first)
18571857

1858-
self.assertEqual(first.name, 'mario')
1859-
self.assertEqual(second.name, 'mario')
1858+
assert first.name == 'mario'
1859+
assert second.name == 'mario'
18601860

18611861
s1 = Series(2, index=first)
18621862
s2 = Series(3, index=second[:-1])
1863-
if PY3:
1864-
with tm.assert_produces_warning(RuntimeWarning):
1865-
# unorderable types
1866-
s3 = s1 * s2
1867-
else:
1863+
1864+
warning_type = RuntimeWarning if PY3 else None
1865+
with tm.assert_produces_warning(warning_type):
1866+
# Python 3: Unorderable types
18681867
s3 = s1 * s2
1869-
self.assertEqual(s3.index.name, 'mario')
1868+
1869+
assert s3.index.name == 'mario'
18701870

18711871
def test_copy_name2(self):
18721872
# Check that adding a "name" parameter to the copy is honored

‎pandas/tests/indexes/test_category.py

+7-5
Original file line numberDiff line numberDiff line change
@@ -536,18 +536,20 @@ def test_identical(self):
536536
self.assertFalse(ci1.identical(ci2))
537537

538538
def test_ensure_copied_data(self):
539-
# Check the "copy" argument of each Index.__new__ is honoured
540-
# GH12309
539+
# gh-12309: Check the "copy" argument of each
540+
# Index.__new__ is honored.
541+
#
541542
# Must be tested separately from other indexes because
542-
# self.value is not an ndarray
543+
# self.value is not an ndarray.
543544
_base = lambda ar: ar if ar.base is None else ar.base
545+
544546
for index in self.indices.values():
545547
result = CategoricalIndex(index.values, copy=True)
546548
tm.assert_index_equal(index, result)
547-
self.assertIsNot(_base(index.values), _base(result.values))
549+
assert _base(index.values) is not _base(result.values)
548550

549551
result = CategoricalIndex(index.values, copy=False)
550-
self.assertIs(_base(index.values), _base(result.values))
552+
assert _base(index.values) is _base(result.values)
551553

552554
def test_equals_categorical(self):
553555
ci1 = CategoricalIndex(['a', 'b'], categories=['a', 'b'], ordered=True)

‎pandas/tests/indexes/test_frozen.py

+15-12
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@ def setUp(self):
4242

4343
def test_shallow_copying(self):
4444
original = self.container.copy()
45-
self.assertIsInstance(self.container.view(), FrozenNDArray)
46-
self.assertFalse(isinstance(
47-
self.container.view(np.ndarray), FrozenNDArray))
48-
self.assertIsNot(self.container.view(), self.container)
49-
self.assert_numpy_array_equal(self.container, original)
50-
# shallow copy should be the same too
51-
self.assertIsInstance(self.container._shallow_copy(), FrozenNDArray)
45+
assert isinstance(self.container.view(), FrozenNDArray)
46+
assert not isinstance(self.container.view(np.ndarray), FrozenNDArray)
47+
assert self.container.view() is not self.container
48+
tm.assert_numpy_array_equal(self.container, original)
49+
50+
# Shallow copy should be the same too
51+
assert isinstance(self.container._shallow_copy(), FrozenNDArray)
5252

5353
# setting should not be allowed
5454
def testit(container):
@@ -59,10 +59,13 @@ def testit(container):
5959
def test_values(self):
6060
original = self.container.view(np.ndarray).copy()
6161
n = original[0] + 15
62+
6263
vals = self.container.values()
63-
self.assert_numpy_array_equal(original, vals)
64-
self.assertIsNot(original, vals)
64+
tm.assert_numpy_array_equal(original, vals)
65+
66+
assert original is not vals
6567
vals[0] = n
66-
self.assertIsInstance(self.container, FrozenNDArray)
67-
self.assert_numpy_array_equal(self.container.values(), original)
68-
self.assertEqual(vals[0], n)
68+
69+
assert isinstance(self.container, FrozenNDArray)
70+
tm.assert_numpy_array_equal(self.container.values(), original)
71+
assert vals[0] == n

‎pandas/tests/indexes/test_interval.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,11 @@ def test_with_nans(self):
165165

166166
def test_copy(self):
167167
actual = self.index.copy()
168-
self.assertTrue(actual.equals(self.index))
168+
assert actual.equals(self.index)
169169

170170
actual = self.index.copy(deep=True)
171-
self.assertTrue(actual.equals(self.index))
172-
self.assertIsNot(actual.left, self.index.left)
171+
assert actual.equals(self.index)
172+
assert actual.left is not self.index.left
173173

174174
def test_ensure_copied_data(self):
175175
# exercise the copy flag in the constructor

‎pandas/tests/indexes/test_multi.py

+11-12
Original file line numberDiff line numberDiff line change
@@ -584,21 +584,20 @@ def test_constructor_mismatched_label_levels(self):
584584
self.index.copy().labels = [[0, 0, 0, 0], [0, 0]]
585585

586586
def assert_multiindex_copied(self, copy, original):
587-
# levels should be (at least, shallow copied)
588-
assert_copy(copy.levels, original.levels)
587+
# Levels should be (at least, shallow copied)
588+
tm.assert_copy(copy.levels, original.levels)
589+
tm.assert_almost_equal(copy.labels, original.labels)
589590

590-
assert_almost_equal(copy.labels, original.labels)
591+
# Labels doesn't matter which way copied
592+
tm.assert_almost_equal(copy.labels, original.labels)
593+
assert copy.labels is not original.labels
591594

592-
# labels doesn't matter which way copied
593-
assert_almost_equal(copy.labels, original.labels)
594-
self.assertIsNot(copy.labels, original.labels)
595+
# Names doesn't matter which way copied
596+
assert copy.names == original.names
597+
assert copy.names is not original.names
595598

596-
# names doesn't matter which way copied
597-
self.assertEqual(copy.names, original.names)
598-
self.assertIsNot(copy.names, original.names)
599-
600-
# sort order should be copied
601-
self.assertEqual(copy.sortorder, original.sortorder)
599+
# Sort order should be copied
600+
assert copy.sortorder == original.sortorder
602601

603602
def test_copy(self):
604603
i_copy = self.index.copy()

‎pandas/tests/series/test_apply.py

+7-7
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,22 @@ class TestSeriesApply(TestData, tm.TestCase):
1818

1919
def test_apply(self):
2020
with np.errstate(all='ignore'):
21-
assert_series_equal(self.ts.apply(np.sqrt), np.sqrt(self.ts))
21+
tm.assert_series_equal(self.ts.apply(np.sqrt), np.sqrt(self.ts))
2222

23-
# elementwise-apply
23+
# element-wise apply
2424
import math
25-
assert_series_equal(self.ts.apply(math.exp), np.exp(self.ts))
25+
tm.assert_series_equal(self.ts.apply(math.exp), np.exp(self.ts))
2626

2727
# empty series
2828
s = Series(dtype=object, name='foo', index=pd.Index([], name='bar'))
2929
rs = s.apply(lambda x: x)
3030
tm.assert_series_equal(s, rs)
3131

3232
# check all metadata (GH 9322)
33-
self.assertIsNot(s, rs)
34-
self.assertIs(s.index, rs.index)
35-
self.assertEqual(s.dtype, rs.dtype)
36-
self.assertEqual(s.name, rs.name)
33+
assert s is not rs
34+
assert s.index is rs.index
35+
assert s.dtype == rs.dtype
36+
assert s.name == rs.name
3737

3838
# index but no data
3939
s = Series(index=[1, 2, 3])

‎pandas/tests/series/test_timeseries.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -240,25 +240,25 @@ def test_asfreq(self):
240240

241241
daily_ts = ts.asfreq('B')
242242
monthly_ts = daily_ts.asfreq('BM')
243-
assert_series_equal(monthly_ts, ts)
243+
tm.assert_series_equal(monthly_ts, ts)
244244

245245
daily_ts = ts.asfreq('B', method='pad')
246246
monthly_ts = daily_ts.asfreq('BM')
247-
assert_series_equal(monthly_ts, ts)
247+
tm.assert_series_equal(monthly_ts, ts)
248248

249249
daily_ts = ts.asfreq(BDay())
250250
monthly_ts = daily_ts.asfreq(BMonthEnd())
251-
assert_series_equal(monthly_ts, ts)
251+
tm.assert_series_equal(monthly_ts, ts)
252252

253253
result = ts[:0].asfreq('M')
254-
self.assertEqual(len(result), 0)
255-
self.assertIsNot(result, ts)
254+
assert len(result) == 0
255+
assert result is not ts
256256

257257
daily_ts = ts.asfreq('D', fill_value=-1)
258258
result = daily_ts.value_counts().sort_index()
259259
expected = Series([60, 1, 1, 1],
260260
index=[-1.0, 2.0, 1.0, 0.0]).sort_index()
261-
assert_series_equal(result, expected)
261+
tm.assert_series_equal(result, expected)
262262

263263
def test_asfreq_datetimeindex_empty_series(self):
264264
# GH 14320

‎pandas/tests/test_generic.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,7 @@ def test_copy_and_deepcopy(self):
687687
lambda x: x.copy(deep=False),
688688
lambda x: x.copy(deep=True)]:
689689
obj_copy = func(obj)
690-
self.assertIsNot(obj_copy, obj)
690+
assert obj_copy is not obj
691691
self._compare(obj_copy, obj)
692692

693693

‎pandas/tests/test_internals.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def test_merge(self):
248248

249249
def test_copy(self):
250250
cop = self.fblock.copy()
251-
self.assertIsNot(cop, self.fblock)
251+
assert cop is not self.fblock
252252
assert_block_equal(self.fblock, cop)
253253

254254
def test_reindex_index(self):

‎pandas/tests/test_panel.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -883,20 +883,20 @@ def test_set_value(self):
883883
for mjr in self.panel.major_axis[::2]:
884884
for mnr in self.panel.minor_axis:
885885
self.panel.set_value(item, mjr, mnr, 1.)
886-
assert_almost_equal(self.panel[item][mnr][mjr], 1.)
886+
tm.assert_almost_equal(self.panel[item][mnr][mjr], 1.)
887887

888888
# resize
889889
res = self.panel.set_value('ItemE', 'foo', 'bar', 1.5)
890-
tm.assertIsInstance(res, Panel)
891-
self.assertIsNot(res, self.panel)
892-
self.assertEqual(res.get_value('ItemE', 'foo', 'bar'), 1.5)
890+
assert isinstance(res, Panel)
891+
assert res is not self.panel
892+
assert res.get_value('ItemE', 'foo', 'bar') == 1.5
893893

894894
res3 = self.panel.set_value('ItemE', 'foobar', 'baz', 5)
895-
self.assertTrue(is_float_dtype(res3['ItemE'].values))
896-
with tm.assertRaisesRegexp(TypeError,
897-
"There must be an argument "
898-
"for each axis"
899-
" plus the value provided"):
895+
assert is_float_dtype(res3['ItemE'].values)
896+
897+
msg = ("There must be an argument for each "
898+
"axis plus the value provided")
899+
with tm.assertRaisesRegexp(TypeError, msg):
900900
self.panel.set_value('a')
901901

902902

‎pandas/tests/test_panel4d.py

+13-13
Original file line numberDiff line numberDiff line change
@@ -587,20 +587,20 @@ def test_set_value(self):
587587
for mjr in self.panel4d.major_axis[::2]:
588588
for mnr in self.panel4d.minor_axis:
589589
self.panel4d.set_value(label, item, mjr, mnr, 1.)
590-
assert_almost_equal(
590+
tm.assert_almost_equal(
591591
self.panel4d[label][item][mnr][mjr], 1.)
592592

593593
res3 = self.panel4d.set_value('l4', 'ItemE', 'foobar', 'baz', 5)
594-
self.assertTrue(is_float_dtype(res3['l4'].values))
594+
assert is_float_dtype(res3['l4'].values)
595595

596596
# resize
597597
res = self.panel4d.set_value('l4', 'ItemE', 'foo', 'bar', 1.5)
598-
tm.assertIsInstance(res, Panel4D)
599-
self.assertIsNot(res, self.panel4d)
600-
self.assertEqual(res.get_value('l4', 'ItemE', 'foo', 'bar'), 1.5)
598+
assert isinstance(res, Panel4D)
599+
assert res is not self.panel4d
600+
assert res.get_value('l4', 'ItemE', 'foo', 'bar') == 1.5
601601

602602
res3 = self.panel4d.set_value('l4', 'ItemE', 'foobar', 'baz', 5)
603-
self.assertTrue(is_float_dtype(res3['l4'].values))
603+
assert is_float_dtype(res3['l4'].values)
604604

605605

606606
class TestPanel4d(tm.TestCase, CheckIndexing, SafeForSparse,
@@ -619,21 +619,21 @@ def test_constructor(self):
619619

620620
with catch_warnings(record=True):
621621
panel4d = Panel4D(self.panel4d._data)
622-
self.assertIs(panel4d._data, self.panel4d._data)
622+
assert panel4d._data is self.panel4d._data
623623

624624
panel4d = Panel4D(self.panel4d._data, copy=True)
625-
self.assertIsNot(panel4d._data, self.panel4d._data)
626-
assert_panel4d_equal(panel4d, self.panel4d)
625+
assert panel4d._data is not self.panel4d._data
626+
tm.assert_panel4d_equal(panel4d, self.panel4d)
627627

628628
vals = self.panel4d.values
629629

630630
# no copy
631631
panel4d = Panel4D(vals)
632-
self.assertIs(panel4d.values, vals)
632+
assert panel4d.values is vals
633633

634634
# copy
635635
panel4d = Panel4D(vals, copy=True)
636-
self.assertIsNot(panel4d.values, vals)
636+
assert panel4d.values is not vals
637637

638638
# GH #8285, test when scalar data is used to construct a Panel4D
639639
# if dtype is not passed, it should be inferred
@@ -645,7 +645,7 @@ def test_constructor(self):
645645
vals = np.empty((2, 3, 4, 5), dtype=dtype)
646646
vals.fill(val)
647647
expected = Panel4D(vals, dtype=dtype)
648-
assert_panel4d_equal(panel4d, expected)
648+
tm.assert_panel4d_equal(panel4d, expected)
649649

650650
# test the case when dtype is passed
651651
panel4d = Panel4D(1, labels=range(2), items=range(
@@ -654,7 +654,7 @@ def test_constructor(self):
654654
vals.fill(1)
655655

656656
expected = Panel4D(vals, dtype='float32')
657-
assert_panel4d_equal(panel4d, expected)
657+
tm.assert_panel4d_equal(panel4d, expected)
658658

659659
def test_constructor_cast(self):
660660
with catch_warnings(record=True):

‎pandas/tests/tools/test_concat.py

+15-17
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@
1212
DatetimeIndex)
1313
from pandas.util import testing as tm
1414
from pandas.util.testing import (assert_frame_equal,
15-
makeCustomDataframe as mkdf,
16-
assert_almost_equal)
15+
makeCustomDataframe as mkdf)
1716

1817
import pytest
1918

@@ -708,51 +707,50 @@ def test_append(self):
708707
end_frame = self.frame.reindex(end_index)
709708

710709
appended = begin_frame.append(end_frame)
711-
assert_almost_equal(appended['A'], self.frame['A'])
710+
tm.assert_almost_equal(appended['A'], self.frame['A'])
712711

713712
del end_frame['A']
714713
partial_appended = begin_frame.append(end_frame)
715-
self.assertIn('A', partial_appended)
714+
assert 'A' in partial_appended
716715

717716
partial_appended = end_frame.append(begin_frame)
718-
self.assertIn('A', partial_appended)
717+
assert 'A' in partial_appended
719718

720719
# mixed type handling
721720
appended = self.mixed_frame[:5].append(self.mixed_frame[5:])
722-
assert_frame_equal(appended, self.mixed_frame)
721+
tm.assert_frame_equal(appended, self.mixed_frame)
723722

724723
# what to test here
725724
mixed_appended = self.mixed_frame[:5].append(self.frame[5:])
726725
mixed_appended2 = self.frame[:5].append(self.mixed_frame[5:])
727726

728727
# all equal except 'foo' column
729-
assert_frame_equal(
728+
tm.assert_frame_equal(
730729
mixed_appended.reindex(columns=['A', 'B', 'C', 'D']),
731730
mixed_appended2.reindex(columns=['A', 'B', 'C', 'D']))
732731

733732
# append empty
734733
empty = DataFrame({})
735734

736735
appended = self.frame.append(empty)
737-
assert_frame_equal(self.frame, appended)
738-
self.assertIsNot(appended, self.frame)
736+
tm.assert_frame_equal(self.frame, appended)
737+
assert appended is not self.frame
739738

740739
appended = empty.append(self.frame)
741-
assert_frame_equal(self.frame, appended)
742-
self.assertIsNot(appended, self.frame)
740+
tm.assert_frame_equal(self.frame, appended)
741+
assert appended is not self.frame
743742

744-
# overlap
745-
self.assertRaises(ValueError, self.frame.append, self.frame,
746-
verify_integrity=True)
743+
# Overlap
744+
with pytest.raises(ValueError):
745+
self.frame.append(self.frame, verify_integrity=True)
747746

748-
# new columns
749-
# GH 6129
747+
# see gh-6129: new columns
750748
df = DataFrame({'a': {'x': 1, 'y': 2}, 'b': {'x': 3, 'y': 4}})
751749
row = Series([5, 6, 7], index=['a', 'b', 'c'], name='z')
752750
expected = DataFrame({'a': {'x': 1, 'y': 2, 'z': 5}, 'b': {
753751
'x': 3, 'y': 4, 'z': 6}, 'c': {'z': 7}})
754752
result = df.append(row)
755-
assert_frame_equal(result, expected)
753+
tm.assert_frame_equal(result, expected)
756754

757755
def test_append_length0_frame(self):
758756
df = DataFrame(columns=['A', 'B', 'C'])

‎pandas/util/testing.py

+10-9
Original file line numberDiff line numberDiff line change
@@ -1043,12 +1043,6 @@ def assertIs(first, second, msg=''):
10431043
assert a is b, "%s: %r is not %r" % (msg.format(a, b), a, b)
10441044

10451045

1046-
def assertIsNot(first, second, msg=''):
1047-
"""Checks that 'first' is not 'second'"""
1048-
a, b = first, second
1049-
assert a is not b, "%s: %r is %r" % (msg.format(a, b), a, b)
1050-
1051-
10521046
def assertIn(first, second, msg=''):
10531047
"""Checks that 'first' is in 'second'"""
10541048
a, b = first, second
@@ -1068,7 +1062,7 @@ def assertIsNone(expr, msg=''):
10681062

10691063
def assertIsNotNone(expr, msg=''):
10701064
"""Checks that 'expr' is not None"""
1071-
return assertIsNot(expr, None, msg)
1065+
assert expr is not None, msg
10721066

10731067

10741068
def assertIsInstance(obj, cls, msg=''):
@@ -1178,10 +1172,17 @@ def assert_numpy_array_equal(left, right, strict_nan=False,
11781172
def _get_base(obj):
11791173
return obj.base if getattr(obj, 'base', None) is not None else obj
11801174

1175+
left_base = _get_base(left)
1176+
right_base = _get_base(right)
1177+
11811178
if check_same == 'same':
1182-
assertIs(_get_base(left), _get_base(right))
1179+
if left_base is not right_base:
1180+
msg = "%r is not %r" % (left_base, right_base)
1181+
raise AssertionError(msg)
11831182
elif check_same == 'copy':
1184-
assertIsNot(_get_base(left), _get_base(right))
1183+
if left_base is right_base:
1184+
msg = "%r is %r" % (left_base, right_base)
1185+
raise AssertionError(msg)
11851186

11861187
def _raise(left, right, err_msg):
11871188
if err_msg is None:

0 commit comments

Comments
 (0)
Please sign in to comment.