Merge pull request loiane#191 from Jeffzholy/improvements/chapter-7-Set

improvements: isSubsetOf function of Set

Author: loiane

src/js/data-structures/set.js

@@ -63,18 +63,8 @@ export default class Set {
   }
 
   isSubsetOf(otherSet) {
-    if (this.size() > otherSet.size()) {
-      return false;
-    }
-    let isSubset = true;
-    this.values().every(value => {
-      if (!otherSet.has(value)) {
-        isSubset = false;
-        return false;
-      }
-      return true;
-    });
-    return isSubset;
+    const values = this.values();
+    return values.every((value) => otherSet.has(value));
   }
 
   isEmpty() {

src/ts/data-structures/set.ts

@@ -75,20 +75,8 @@ export default class Set<T> {
   }
 
   isSubsetOf(otherSet: Set<T>) {
-    if (this.size() > otherSet.size()) {
-      return false;
-    }
-
-    let isSubset = true;
-    this.values().every(value => {
-      if (!otherSet.has(value)) {
-        isSubset = false;
-        return false;
-      }
-      return true;
-    });
-
-    return isSubset;
+    const values = this.values();
+    return values.every((value) => otherSet.has(value));
   }
 
   isEmpty() {