[FIX] Don't require baseUrl (import-js#8)

Fixes import-js#6

Author: bradzacher

dummy.js/index.js

@@ -0,0 +1 @@
+module.exports = 'dummy';

dummy.js/package.json

@@ -1,5 +1,6 @@
 {
     "name": "dummy.js",
     "version": "1.0.0",
+    "main": "index.js",
     "private": true
 }

index.js

@@ -1,51 +1,55 @@
-'use strict'
+'use strict';
 
-const path = require('path')
-const resolve = require('resolve')
-const tsconfigPaths = require('tsconfig-paths')
-const debug = require('debug')
+const path = require('path');
+const resolve = require('resolve');
+const tsconfigPaths = require('tsconfig-paths');
+const debug = require('debug');
 
-const log = debug('eslint-import-resolver-typescript')
+const log = debug('eslint-import-resolver-typescript');
 
 /**
  * @param {string} source the module to resolve; i.e './some-module'
  * @param {string} file the importing file's full path; i.e. '/usr/local/bin/file.js'
  */
 function resolveFile(source, file, config) {
-  log('looking for:', source)
+  log('looking for:', source);
 
   // don't worry about core node modules
   if (resolve.isCore(source)) {
-    log('matched core:', source)
+    log('matched core:', source);
 
     return {
       found: true,
       path: null,
-    }
+    };
   }
 
+  let foundTsPath = null;
+  const extensions = Object.keys(require.extensions).concat(
+    '.ts',
+    '.tsx',
+    '.d.ts',
+  );
+
   // setup tsconfig-paths
-  const searchStart = config.directory || process.cwd()
-  const configLoaderResult = tsconfigPaths.loadConfig(searchStart)
-  if (configLoaderResult.resultType !== 'success') {
-    throw new Error(`Unable to find tsconfig in ${searchStart}: ${configLoaderResult.message}`)
-  }
-  const matchPath = tsconfigPaths.createMatchPath(
-    configLoaderResult.absoluteBaseUrl,
-    configLoaderResult.paths,
-  )
+  const searchStart = config.directory || process.cwd();
+  const configLoaderResult = tsconfigPaths.loadConfig(searchStart);
+  if (configLoaderResult.resultType === 'success') {
+    const matchPath = tsconfigPaths.createMatchPath(
+      configLoaderResult.absoluteBaseUrl,
+      configLoaderResult.paths,
+    );
 
-  // look for files based on setup tsconfig "paths"
-  const extensions = Object.keys(require.extensions).concat('.ts', '.tsx', '.d.ts')
-  const foundTsPath = matchPath(
-    source,
-    undefined,
-    undefined,
-    extensions,
-  )
+    // look for files based on setup tsconfig "paths"
+    foundTsPath = matchPath(source, undefined, undefined, extensions);
 
-  if (foundTsPath) {
-    log('matched ts path:', foundTsPath)
+    if (foundTsPath) {
+      log('matched ts path:', foundTsPath);
+    }
+  } else {
+    log('failed to init tsconfig-paths:', configLoaderResult.message);
+    // this can happen if the user has problems with their tsconfig
+    // or if it's valid, but they don't have baseUrl set
   }
 
   // note that even if we match via tsconfig-paths, we still need to do a final resolve
@@ -54,28 +58,35 @@ function resolveFile(source, file, config) {
     foundNodePath = resolve.sync(foundTsPath || source, {
       extensions,
       basedir: path.dirname(path.resolve(file)),
-    })
+      packageFilter,
+    });
   } catch (err) {
     foundNodePath = null;
   }
 
   if (foundNodePath) {
-    log('matched node path:', foundNodePath)
+    log('matched node path:', foundNodePath);
 
     return {
       found: true,
       path: foundNodePath,
-    }
+    };
   }
 
-  log('didnt find', source)
+  log('didnt find', source);
 
   return {
-    found: false
+    found: false,
+  };
+}
+function packageFilter(pkg) {
+  if (pkg['jsnext:main']) {
+    pkg['main'] = pkg['jsnext:main'];
   }
+  return pkg;
 }
 
 module.exports = {
   interfaceVersion: 2,
   resolve: resolveFile,
-}
+};

package-lock.json

@@ -29,11 +29,12 @@
     "eslint-plugin-import": "*"
   },
   "devDependencies": {
+    "dummy.js": "file:dummy.js",
     "eslint": "^5.6.1",
     "eslint-plugin-import": "^2.14.0",
     "typescript": "^3.1.1"
   },
   "scripts": {
-    "test": "eslint ./tests/index.ts"
+    "test": "eslint ./tests/withPaths/index.ts && eslint ./tests/withoutPaths/index.ts"
   }
 }

package.json

@@ -1,6 +1,6 @@
 const path = require('path')
 
-module.exports = {
+module.exports = (dirname) => ({
     env: {
         es6: true,
     },
@@ -13,13 +13,22 @@ module.exports = {
     ],
     rules: {
         'import/no-unresolved': 'error',
-        'import/extensions': 'error',
+        'import/extensions': [
+            'error',
+            'ignorePackages',
+            {
+                js: 'never',
+                jsx: 'never',
+                ts: 'never',
+                tsx: 'never',
+            },
+        ],
     },
     settings: {
         'import/resolver': {
             [path.resolve(`${__dirname}/../index.js`)]: {
-                directory: __dirname,
+                directory: dirname,
             },
         },
     },
-}
+})

tests/.eslintrc.js tests/baseEslintConfig.js

@@ -0,0 +1 @@
+module.exports = require('../baseEslintConfig')(__dirname)

tests/withPaths/.eslintrc.js

@@ -4,7 +4,7 @@
         "jsx": "react",
         "paths": {
             "folder/*": ["*"],
-            "*": ["../node_modules/*"]
+            "*": ["../../node_modules/*"]
         },
     },
     "files": [

tests/index.ts tests/withPaths/index.ts

@@ -0,0 +1 @@
+module.exports = require('../baseEslintConfig')(__dirname)

tests/subfolder/tsImportee.ts tests/withPaths/subfolder/tsImportee.ts

@@ -0,0 +1,9 @@
+// import relative
+import './tsImportee'
+import './tsxImportee'
+import './subfolder/tsImportee'
+import './subfolder/tsxImportee'
+
+// import from node_module
+import 'typescript'
+import 'dummy.js'

tests/subfolder/tsxImportee.tsx tests/withPaths/subfolder/tsxImportee.tsx

@@ -0,0 +1 @@
+export default 'yes'

tests/tsImportee.ts tests/withPaths/tsImportee.ts

@@ -0,0 +1 @@
+export default 'React Component'

tests/tsconfig.json tests/withPaths/tsconfig.json

@@ -0,0 +1 @@
+export default 'yes'

tests/tsxImportee.tsx tests/withPaths/tsxImportee.tsx

@@ -0,0 +1,10 @@
+{
+    "compilerOptions": {
+        "jsx": "react",
+    },
+    "files": [
+        "index.ts",
+        "tsImportee.ts",
+        "tsxImportee.tsx"
+    ]
+}

tests/withoutPaths/.eslintrc.js

@@ -0,0 +1 @@
+export default 'React Component'