Reorder modifiers to comply with the JLS

See spring-projectsgh-12432

Author: igor-suhorukov

Diff for: spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/context/properties/ConfigurationPropertiesReportEndpointProxyTests.java

@@ -91,7 +91,7 @@ public interface Executor {
 
 	}
 
-	public static abstract class AbstractExecutor implements Executor {
+	public abstract static class AbstractExecutor implements Executor {
 
 	}
 

Diff for: spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/cache/AbstractCacheAutoConfigurationTests.java

@@ -147,7 +147,7 @@ public CacheManagerCustomizer<CaffeineCacheManager> caffeineCacheManagerCustomiz
 
 	}
 
-	static abstract class CacheManagerTestCustomizer<T extends CacheManager>
+	abstract static class CacheManagerTestCustomizer<T extends CacheManager>
 			implements CacheManagerCustomizer<T> {
 
 		T cacheManager;

Diff for: spring-boot-project/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/SilentExitExceptionHandlerTests.java

@@ -76,7 +76,7 @@ public void preventsNonZeroExitCodeWhenAllOtherThreadsAreDaemonThreads() {
 
 	}
 
-	private static abstract class TestThread extends Thread {
+	private abstract static class TestThread extends Thread {
 
 		private Throwable thrown;
 

Diff for: spring-boot-project/spring-boot-parent/src/checkstyle/checkstyle.xml

@@ -129,6 +129,8 @@
 
 		<!-- Modifiers -->
 		<module name="com.puppycrawl.tools.checkstyle.checks.modifier.RedundantModifierCheck" />
+		<module name="com.puppycrawl.tools.checkstyle.checks.modifier.ModifierOrderCheck"/>
+
 
 		<!-- Regexp -->
  		<module name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck">

Diff for: spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/context/AbstractSpringBootTestEmbeddedReactiveWebEnvironmentTests.java

@@ -88,7 +88,7 @@ public void annotationAttributesOverridePropertiesFile() {
 		assertThat(this.value).isEqualTo(123);
 	}
 
-	protected static abstract class AbstractConfig {
+	protected abstract static class AbstractConfig {
 
 		@Value("${server.port:8080}")
 		private int port = 8080;

Diff for: spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/context/AbstractSpringBootTestWebServerWebEnvironmentTests.java

@@ -92,7 +92,7 @@ public void validateWebApplicationContextIsSet() {
 				WebApplicationContextUtils.getWebApplicationContext(this.servletContext));
 	}
 
-	protected static abstract class AbstractConfig {
+	protected abstract static class AbstractConfig {
 
 		@Value("${server.port:8080}")
 		private int port = 8080;

Diff for: spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/json/GsonTesterTests.java

@@ -65,7 +65,7 @@ protected AbstractJsonMarshalTester<Object> createTester(Class<?> resourceLoadCl
 		return new GsonTester<>(resourceLoadClass, type, new GsonBuilder().create());
 	}
 
-	static abstract class InitFieldsBaseClass {
+	abstract static class InitFieldsBaseClass {
 
 		public GsonTester<ExampleObject> base;
 

Diff for: spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/json/JacksonTesterTests.java

@@ -64,7 +64,7 @@ protected AbstractJsonMarshalTester<Object> createTester(Class<?> resourceLoadCl
 		return new JacksonTester<>(resourceLoadClass, type, new ObjectMapper());
 	}
 
-	static abstract class InitFieldsBaseClass {
+	abstract static class InitFieldsBaseClass {
 
 		public JacksonTester<ExampleObject> base;
 

Diff for: spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/json/JsonbTesterTests.java

@@ -66,7 +66,7 @@ protected AbstractJsonMarshalTester<Object> createTester(Class<?> resourceLoadCl
 		return new JsonbTester<>(resourceLoadClass, type, JsonbBuilder.create());
 	}
 
-	static abstract class InitFieldsBaseClass {
+	abstract static class InitFieldsBaseClass {
 
 		public JsonbTester<ExampleObject> base;
 

Diff for: spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/test/java/org/springframework/boot/maven/Verify.java

@@ -167,7 +167,7 @@ public InputStream getEntryContent(String entry) throws IOException {
 
 	}
 
-	private static abstract class AbstractArchiveVerification {
+	private abstract static class AbstractArchiveVerification {
 
 		private final File file;
 

Diff for: spring-boot-project/spring-boot/src/main/java/org/springframework/boot/util/LambdaSafe.java

@@ -100,7 +100,7 @@ public static <C, A> Callbacks<C, A> callbacks(Class<C> callbackType,
 	/**
 	 * Abstract base class for lambda safe callbacks.
 	 */
-	private static abstract class LambdaSafeCallback<C, A, SELF extends LambdaSafeCallback<C, A, SELF>> {
+	private abstract static class LambdaSafeCallback<C, A, SELF extends LambdaSafeCallback<C, A, SELF>> {
 
 		private final Class<C> callbackType;
 

Diff for: spring-boot-project/spring-boot/src/test/java/org/springframework/boot/SpringApplicationTests.java

@@ -1357,7 +1357,7 @@ static class RefreshFailureException extends RuntimeException {
 
 	}
 
-	static abstract class AbstractTestRunner implements ApplicationContextAware, Ordered {
+	abstract static class AbstractTestRunner implements ApplicationContextAware, Ordered {
 
 		private final String[] expectedBefore;
 

Diff for: spring-boot-project/spring-boot/src/test/java/org/springframework/boot/jackson/JsonComponentModuleTests.java

@@ -110,7 +110,7 @@ static class OnlyDeserializer extends NameAndAgeJsonComponent.Deserializer {
 	@JsonComponent
 	static class ComponentWithInnerAbstractClass {
 
-		private static abstract class AbstractSerializer
+		private abstract static class AbstractSerializer
 				extends NameAndAgeJsonComponent.Serializer {
 
 		}