Skip to content

Commit abcff3a

Browse files
rajadilipkolliwilkinsona
authored andcommitted
Use try-with-resources in HttpTunnelPayload
See spring-projectsgh-11779
1 parent 9d3586d commit abcff3a

File tree

1 file changed

+11
-11
lines changed
  • spring-boot-project/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/tunnel/payload

1 file changed

+11
-11
lines changed

spring-boot-project/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/tunnel/payload/HttpTunnelPayload.java

+11-11
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,11 @@ public void assignTo(HttpOutputMessage message) throws IOException {
8484
headers.setContentLength(this.data.remaining());
8585
headers.add(SEQ_HEADER, Long.toString(getSequence()));
8686
headers.setContentType(MediaType.APPLICATION_OCTET_STREAM);
87-
WritableByteChannel body = Channels.newChannel(message.getBody());
88-
while (this.data.hasRemaining()) {
89-
body.write(this.data);
87+
try (WritableByteChannel body = Channels.newChannel(message.getBody())) {
88+
while (this.data.hasRemaining()) {
89+
body.write(this.data);
90+
}
9091
}
91-
body.close();
9292
}
9393

9494
/**
@@ -117,14 +117,14 @@ public static HttpTunnelPayload get(HttpInputMessage message) throws IOException
117117
}
118118
String seqHeader = message.getHeaders().getFirst(SEQ_HEADER);
119119
Assert.state(StringUtils.hasLength(seqHeader), "Missing sequence header");
120-
ReadableByteChannel body = Channels.newChannel(message.getBody());
121-
ByteBuffer payload = ByteBuffer.allocate((int) length);
122-
while (payload.hasRemaining()) {
123-
body.read(payload);
120+
try (ReadableByteChannel body = Channels.newChannel(message.getBody())) {
121+
ByteBuffer payload = ByteBuffer.allocate((int) length);
122+
while (payload.hasRemaining()) {
123+
body.read(payload);
124+
}
125+
payload.flip();
126+
return new HttpTunnelPayload(Long.valueOf(seqHeader), payload);
124127
}
125-
body.close();
126-
payload.flip();
127-
return new HttpTunnelPayload(Long.valueOf(seqHeader), payload);
128128
}
129129

130130
/**

0 commit comments

Comments
 (0)