Skip to content

Commit 1117fdb

Browse files
committed
Make ModifiedClassPathExtension package private
Meta-annotate `ClassPathExclusions` and `ClassPathOverrides` with so that the `ModifiedClassPathExtension` no longer needs to be used directly. See spring-projectsgh-17491
1 parent b6ec133 commit 1117fdb

File tree

40 files changed

+9
-113
lines changed

40 files changed

+9
-113
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/Log4J2MetricsWithLog4jLoggerContextAutoConfigurationTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,11 @@
1919
import io.micrometer.core.instrument.binder.logging.Log4j2Metrics;
2020
import org.apache.logging.log4j.LogManager;
2121
import org.junit.jupiter.api.Test;
22-
import org.junit.jupiter.api.extension.ExtendWith;
2322

2423
import org.springframework.boot.actuate.autoconfigure.metrics.test.MetricsRun;
2524
import org.springframework.boot.autoconfigure.AutoConfigurations;
2625
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2726
import org.springframework.boot.testsupport.runner.classpath.ClassPathOverrides;
28-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
2927
import org.springframework.context.annotation.Bean;
3028
import org.springframework.context.annotation.Configuration;
3129

@@ -36,7 +34,6 @@
3634
*
3735
* @author Andy Wilkinson
3836
*/
39-
@ExtendWith(ModifiedClassPathExtension.class)
4037
@ClassPathOverrides("org.apache.logging.log4j:log4j-core:2.11.1")
4138
class Log4J2MetricsWithLog4jLoggerContextAutoConfigurationTests {
4239

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/MetricsAutoConfigurationWithLog4j2AndLogbackTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,10 @@
1818

1919
import io.micrometer.core.instrument.binder.logging.LogbackMetrics;
2020
import org.junit.jupiter.api.Test;
21-
import org.junit.jupiter.api.extension.ExtendWith;
2221

2322
import org.springframework.boot.autoconfigure.AutoConfigurations;
2423
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2524
import org.springframework.boot.testsupport.runner.classpath.ClassPathOverrides;
26-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
2725

2826
import static org.assertj.core.api.Assertions.assertThat;
2927

@@ -33,7 +31,6 @@
3331
*
3432
* @author Andy Wilkinson
3533
*/
36-
@ExtendWith(ModifiedClassPathExtension.class)
3734
@ClassPathOverrides({ "org.apache.logging.log4j:log4j-core:2.9.0", "org.apache.logging.log4j:log4j-slf4j-impl:2.9.0" })
3835
class MetricsAutoConfigurationWithLog4j2AndLogbackTests {
3936

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/redis/RedisHealthIndicatorAutoConfigurationTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package org.springframework.boot.actuate.autoconfigure.redis;
1818

1919
import org.junit.jupiter.api.Test;
20-
import org.junit.jupiter.api.extension.ExtendWith;
2120

2221
import org.springframework.boot.actuate.autoconfigure.health.HealthIndicatorAutoConfiguration;
2322
import org.springframework.boot.actuate.health.ApplicationHealthIndicator;
@@ -27,7 +26,6 @@
2726
import org.springframework.boot.autoconfigure.data.redis.RedisAutoConfiguration;
2827
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2928
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
30-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
3129

3230
import static org.assertj.core.api.Assertions.assertThat;
3331

@@ -36,7 +34,6 @@
3634
*
3735
* @author Phillip Webb
3836
*/
39-
@ExtendWith(ModifiedClassPathExtension.class)
4037
@ClassPathExclusions({ "reactor-core*.jar", "lettuce-core*.jar" })
4138
class RedisHealthIndicatorAutoConfigurationTests {
4239

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/web/jersey/JerseyChildManagementContextConfigurationTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import org.glassfish.jersey.server.ResourceConfig;
2020
import org.glassfish.jersey.servlet.ServletContainer;
2121
import org.junit.jupiter.api.Test;
22-
import org.junit.jupiter.api.extension.ExtendWith;
2322

2423
import org.springframework.boot.autoconfigure.AutoConfigurations;
2524
import org.springframework.boot.autoconfigure.jersey.ResourceConfigCustomizer;
@@ -28,7 +27,6 @@
2827
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2928
import org.springframework.boot.test.context.runner.WebApplicationContextRunner;
3029
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
31-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
3230
import org.springframework.boot.web.servlet.ServletRegistrationBean;
3331
import org.springframework.context.annotation.Bean;
3432
import org.springframework.context.annotation.Configuration;
@@ -43,7 +41,6 @@
4341
* @author Andy Wilkinson
4442
* @author Madhura Bhave
4543
*/
46-
@ExtendWith(ModifiedClassPathExtension.class)
4744
@ClassPathExclusions("spring-webmvc-*")
4845
class JerseyChildManagementContextConfigurationTests {
4946

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/web/jersey/JerseySameManagementContextConfigurationTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import org.glassfish.jersey.server.ResourceConfig;
1919
import org.glassfish.jersey.servlet.ServletContainer;
2020
import org.junit.jupiter.api.Test;
21-
import org.junit.jupiter.api.extension.ExtendWith;
2221

2322
import org.springframework.boot.autoconfigure.AutoConfigurations;
2423
import org.springframework.boot.autoconfigure.jersey.ResourceConfigCustomizer;
@@ -28,7 +27,6 @@
2827
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2928
import org.springframework.boot.test.context.runner.WebApplicationContextRunner;
3029
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
31-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
3230
import org.springframework.boot.web.servlet.ServletRegistrationBean;
3331
import org.springframework.context.annotation.Bean;
3432
import org.springframework.context.annotation.Configuration;
@@ -42,7 +40,6 @@
4240
*
4341
* @author Madhura Bhave
4442
*/
45-
@ExtendWith(ModifiedClassPathExtension.class)
4643
@ClassPathExclusions("spring-webmvc-*")
4744
class JerseySameManagementContextConfigurationTests {
4845

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/batch/BatchAutoConfigurationWithoutJdbcTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package org.springframework.boot.autoconfigure.batch;
1818

1919
import org.junit.jupiter.api.Test;
20-
import org.junit.jupiter.api.extension.ExtendWith;
2120

2221
import org.springframework.batch.core.configuration.annotation.BatchConfigurer;
2322
import org.springframework.batch.core.configuration.annotation.EnableBatchProcessing;
@@ -29,7 +28,6 @@
2928
import org.springframework.boot.autoconfigure.transaction.TransactionAutoConfiguration;
3029
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
3130
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
32-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
3331
import org.springframework.context.annotation.Configuration;
3432
import org.springframework.transaction.PlatformTransactionManager;
3533

@@ -41,7 +39,6 @@
4139
*
4240
* @author Andy Wilkinson
4341
*/
44-
@ExtendWith(ModifiedClassPathExtension.class)
4542
@ClassPathExclusions("spring-jdbc-*.jar")
4643
class BatchAutoConfigurationWithoutJdbcTests {
4744

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/batch/BatchAutoConfigurationWithoutJpaTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import javax.sql.DataSource;
2020

2121
import org.junit.jupiter.api.Test;
22-
import org.junit.jupiter.api.extension.ExtendWith;
2322

2423
import org.springframework.batch.core.JobParameters;
2524
import org.springframework.batch.core.configuration.annotation.EnableBatchProcessing;
@@ -34,7 +33,6 @@
3433
import org.springframework.boot.jdbc.DataSourceInitializationMode;
3534
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
3635
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
37-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
3836
import org.springframework.jdbc.core.JdbcTemplate;
3937
import org.springframework.transaction.PlatformTransactionManager;
4038

@@ -45,7 +43,6 @@
4543
*
4644
* @author Stephane Nicoll
4745
*/
48-
@ExtendWith(ModifiedClassPathExtension.class)
4946
@ClassPathExclusions("hibernate-jpa-*.jar")
5047
class BatchAutoConfigurationWithoutJpaTests {
5148

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/cache/CacheAutoConfigurationTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import org.infinispan.jcache.embedded.JCachingProvider;
4242
import org.infinispan.spring.embedded.provider.SpringEmbeddedCacheManager;
4343
import org.junit.jupiter.api.Test;
44-
import org.junit.jupiter.api.extension.ExtendWith;
4544

4645
import org.springframework.beans.factory.BeanCreationException;
4746
import org.springframework.beans.factory.config.BeanPostProcessor;
@@ -50,7 +49,6 @@
5049
import org.springframework.boot.autoconfigure.hazelcast.HazelcastAutoConfiguration;
5150
import org.springframework.boot.test.context.assertj.AssertableApplicationContext;
5251
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
53-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
5452
import org.springframework.cache.Cache;
5553
import org.springframework.cache.CacheManager;
5654
import org.springframework.cache.annotation.CachingConfigurerSupport;
@@ -87,7 +85,6 @@
8785
* @author Mark Paluch
8886
* @author Ryon Day
8987
*/
90-
@ExtendWith(ModifiedClassPathExtension.class)
9188
@ClassPathExclusions("hazelcast-client-*.jar")
9289
class CacheAutoConfigurationTests extends AbstractCacheAutoConfigurationTests {
9390

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/cache/EhCache2CacheAutoConfigurationTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,13 @@
1717
package org.springframework.boot.autoconfigure.cache;
1818

1919
import org.junit.jupiter.api.Test;
20-
import org.junit.jupiter.api.extension.ExtendWith;
2120

2221
import org.springframework.boot.autoconfigure.AutoConfigurations;
2322
import org.springframework.boot.autoconfigure.cache.CacheAutoConfigurationTests.DefaultCacheAndCustomizersConfiguration;
2423
import org.springframework.boot.autoconfigure.cache.CacheAutoConfigurationTests.DefaultCacheConfiguration;
2524
import org.springframework.boot.autoconfigure.cache.CacheAutoConfigurationTests.EhCacheCustomCacheManager;
2625
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2726
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
28-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
2927
import org.springframework.cache.ehcache.EhCacheCacheManager;
3028

3129
import static org.assertj.core.api.Assertions.assertThat;
@@ -36,7 +34,6 @@
3634
* @author Stephane Nicoll
3735
* @author Andy Wilkinson
3836
*/
39-
@ExtendWith(ModifiedClassPathExtension.class)
4037
@ClassPathExclusions("ehcache-3*.jar")
4138
class EhCache2CacheAutoConfigurationTests extends AbstractCacheAutoConfigurationTests {
4239

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/cache/EhCache3CacheAutoConfigurationTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,9 @@
1818

1919
import org.ehcache.jsr107.EhcacheCachingProvider;
2020
import org.junit.jupiter.api.Test;
21-
import org.junit.jupiter.api.extension.ExtendWith;
2221

2322
import org.springframework.boot.autoconfigure.cache.CacheAutoConfigurationTests.DefaultCacheConfiguration;
2423
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
25-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
2624
import org.springframework.cache.jcache.JCacheCacheManager;
2725
import org.springframework.core.io.ClassPathResource;
2826
import org.springframework.core.io.Resource;
@@ -35,7 +33,6 @@
3533
* @author Stephane Nicoll
3634
* @author Andy Wilkinson
3735
*/
38-
@ExtendWith(ModifiedClassPathExtension.class)
3936
@ClassPathExclusions("ehcache-2*.jar")
4037
class EhCache3CacheAutoConfigurationTests extends AbstractCacheAutoConfigurationTests {
4138

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnMissingBeanWithFilteredClasspathTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,9 @@
1717
package org.springframework.boot.autoconfigure.condition;
1818

1919
import org.junit.jupiter.api.Test;
20-
import org.junit.jupiter.api.extension.ExtendWith;
2120

2221
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2322
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
24-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
2523
import org.springframework.cache.caffeine.CaffeineCacheManager;
2624
import org.springframework.context.annotation.Bean;
2725
import org.springframework.context.annotation.Configuration;
@@ -35,7 +33,6 @@
3533
* @author Stephane Nicoll
3634
* @author Andy Wilkinson
3735
*/
38-
@ExtendWith(ModifiedClassPathExtension.class)
3936
@ClassPathExclusions("spring-context-support-*.jar")
4037
class ConditionalOnMissingBeanWithFilteredClasspathTests {
4138

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/OnBeanConditionTypeDeductionFailureTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,9 @@
1818

1919
import com.fasterxml.jackson.databind.ObjectMapper;
2020
import org.junit.jupiter.api.Test;
21-
import org.junit.jupiter.api.extension.ExtendWith;
2221

2322
import org.springframework.boot.autoconfigure.condition.OnBeanCondition.BeanTypeDeductionException;
2423
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
25-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
2624
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
2725
import org.springframework.context.annotation.Bean;
2826
import org.springframework.context.annotation.Configuration;
@@ -38,7 +36,6 @@
3836
*
3937
* @author Andy Wilkinson
4038
*/
41-
@ExtendWith(ModifiedClassPathExtension.class)
4239
@ClassPathExclusions("jackson-core-*.jar")
4340
class OnBeanConditionTypeDeductionFailureTests {
4441

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/data/redis/RedisAutoConfigurationJedisTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,12 @@
1717
package org.springframework.boot.autoconfigure.data.redis;
1818

1919
import org.junit.jupiter.api.Test;
20-
import org.junit.jupiter.api.extension.ExtendWith;
2120

2221
import org.springframework.beans.BeansException;
2322
import org.springframework.beans.factory.config.BeanPostProcessor;
2423
import org.springframework.boot.autoconfigure.AutoConfigurations;
2524
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2625
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
27-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
2826
import org.springframework.context.annotation.Bean;
2927
import org.springframework.context.annotation.Configuration;
3028
import org.springframework.data.redis.connection.jedis.JedisClientConfiguration.JedisClientConfigurationBuilder;
@@ -38,7 +36,6 @@
3836
* @author Mark Paluch
3937
* @author Stephane Nicoll
4038
*/
41-
@ExtendWith(ModifiedClassPathExtension.class)
4239
@ClassPathExclusions("lettuce-core-*.jar")
4340
class RedisAutoConfigurationJedisTests {
4441

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/hateoas/HypermediaAutoConfigurationWithoutJacksonTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,11 @@
1717
package org.springframework.boot.autoconfigure.hateoas;
1818

1919
import org.junit.jupiter.api.Test;
20-
import org.junit.jupiter.api.extension.ExtendWith;
2120

2221
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
2322
import org.springframework.boot.autoconfigure.http.HttpMessageConvertersAutoConfiguration;
2423
import org.springframework.boot.autoconfigure.web.servlet.WebMvcAutoConfiguration;
2524
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
26-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
2725
import org.springframework.boot.web.servlet.context.AnnotationConfigServletWebApplicationContext;
2826
import org.springframework.mock.web.MockServletContext;
2927

@@ -32,7 +30,6 @@
3230
*
3331
* @author Andy Wilkinson
3432
*/
35-
@ExtendWith(ModifiedClassPathExtension.class)
3633
@ClassPathExclusions("jackson-*.jar")
3734
class HypermediaAutoConfigurationWithoutJacksonTests {
3835

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/hazelcast/HazelcastAutoConfigurationServerTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,13 @@
2323
import com.hazelcast.core.Hazelcast;
2424
import com.hazelcast.core.HazelcastInstance;
2525
import org.junit.jupiter.api.Test;
26-
import org.junit.jupiter.api.extension.ExtendWith;
2726

2827
import org.springframework.beans.factory.BeanCreationException;
2928
import org.springframework.boot.autoconfigure.AutoConfigurations;
3029
import org.springframework.boot.test.context.assertj.AssertableApplicationContext;
3130
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
3231
import org.springframework.boot.test.context.runner.ContextConsumer;
3332
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
34-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
3533
import org.springframework.context.annotation.Bean;
3634
import org.springframework.context.annotation.Configuration;
3735
import org.springframework.core.io.ClassPathResource;
@@ -43,7 +41,6 @@
4341
*
4442
* @author Stephane Nicoll
4543
*/
46-
@ExtendWith(ModifiedClassPathExtension.class)
4744
@ClassPathExclusions("hazelcast-client-*.jar")
4845
class HazelcastAutoConfigurationServerTests {
4946

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/http/HttpMessageConvertersAutoConfigurationWithoutJacksonTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,10 @@
1717
package org.springframework.boot.autoconfigure.http;
1818

1919
import org.junit.jupiter.api.Test;
20-
import org.junit.jupiter.api.extension.ExtendWith;
2120

2221
import org.springframework.boot.autoconfigure.AutoConfigurations;
2322
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2423
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
25-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
2624

2725
import static org.assertj.core.api.Assertions.assertThat;
2826

@@ -32,7 +30,6 @@
3230
*
3331
* @author Andy Wilkinson
3432
*/
35-
@ExtendWith(ModifiedClassPathExtension.class)
3633
@ClassPathExclusions("jackson-*.jar")
3734
class HttpMessageConvertersAutoConfigurationWithoutJacksonTests {
3835

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/DataSourceBeanCreationFailureAnalyzerTests.java

-3
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,11 @@
1717
package org.springframework.boot.autoconfigure.jdbc;
1818

1919
import org.junit.jupiter.api.Test;
20-
import org.junit.jupiter.api.extension.ExtendWith;
2120

2221
import org.springframework.beans.factory.BeanCreationException;
2322
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
2423
import org.springframework.boot.diagnostics.FailureAnalysis;
2524
import org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions;
26-
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathExtension;
2725
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
2826
import org.springframework.context.annotation.Configuration;
2927
import org.springframework.mock.env.MockEnvironment;
@@ -36,7 +34,6 @@
3634
* @author Andy Wilkinson
3735
* @author Stephane Nicoll
3836
*/
39-
@ExtendWith(ModifiedClassPathExtension.class)
4037
@ClassPathExclusions({ "h2-*.jar", "hsqldb-*.jar" })
4138
class DataSourceBeanCreationFailureAnalyzerTests {
4239

0 commit comments

Comments
 (0)