Skip to content

Commit 32b6225

Browse files
committedJan 24, 2019
refactor PVL unit tests to use test tables & add test cases for remaining cloud providers
1 parent 22fce22 commit 32b6225

File tree

3 files changed

+673
-164
lines changed

3 files changed

+673
-164
lines changed
 

‎plugin/pkg/admission/storage/persistentvolume/label/BUILD

+2-1
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ go_test(
3434
deps = [
3535
"//pkg/apis/core:go_default_library",
3636
"//pkg/kubelet/apis:go_default_library",
37-
"//pkg/volume/util:go_default_library",
3837
"//staging/src/k8s.io/api/core/v1:go_default_library",
38+
"//staging/src/k8s.io/apimachinery/pkg/api/errors:go_default_library",
3939
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
40+
"//staging/src/k8s.io/apimachinery/pkg/runtime/schema:go_default_library",
4041
"//staging/src/k8s.io/apiserver/pkg/admission:go_default_library",
4142
"//staging/src/k8s.io/cloud-provider:go_default_library",
4243
],

‎plugin/pkg/admission/storage/persistentvolume/label/admission.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,8 @@ func (l *persistentVolumeLabel) Admit(a admission.Attributes) (err error) {
158158
if err != nil {
159159
return admission.NewForbidden(a, fmt.Errorf("failed to convert label string for Zone: %s to a Set", v))
160160
}
161-
values = zones.UnsortedList()
161+
// zone values here are sorted for better testability.
162+
values = zones.List()
162163
} else {
163164
values = []string{v}
164165
}

0 commit comments

Comments
 (0)
Please sign in to comment.