Store array/list size in a local variable for performance

ldiqual · ldiqual · commit 0834d179fcd6 · 2014-04-16T11:32:24.000-07:00
diff --git a/library/src/main/java/com/loopj/android/http/RequestParams.java b/library/src/main/java/com/loopj/android/http/RequestParams.java
@@ -512,12 +512,14 @@ private List<BasicNameValuePair> getParamsList(String key, Object value) {
             }
         } else if (value instanceof List) {
             List list = (List) value;
-            for (int nestedValueIndex = 0; nestedValueIndex < list.size(); nestedValueIndex++) {
+            int listSize = list.size();
+            for (int nestedValueIndex = 0; nestedValueIndex < listSize; nestedValueIndex++) {
                 params.addAll(getParamsList(String.format("%s[%d]", key, nestedValueIndex), list.get(nestedValueIndex)));
             }
         } else if (value instanceof Object[]) {
             Object[] array = (Object[]) value;
-            for (int nestedValueIndex = 0; nestedValueIndex < array.length; nestedValueIndex++) {
+            int arrayLength = array.length;
+            for (int nestedValueIndex = 0; nestedValueIndex < arrayLength; nestedValueIndex++) {
                 params.addAll(getParamsList(String.format("%s[%d]", key, nestedValueIndex), array[nestedValueIndex]));
             }
         } else if (value instanceof Set) {

Original file line number	Diff line number	Diff line change
`@@ -512,12 +512,14 @@ private List<BasicNameValuePair> getParamsList(String key, Object value) {`
`512`	`512`	`}`
`513`	`513`	`} else if (value instanceof List) {`
`514`	`514`	`List list = (List) value;`
`515`		`- for (int nestedValueIndex = 0; nestedValueIndex < list.size(); nestedValueIndex++) {`
	`515`	`+ int listSize = list.size();`
	`516`	`+ for (int nestedValueIndex = 0; nestedValueIndex < listSize; nestedValueIndex++) {`
`516`	`517`	`params.addAll(getParamsList(String.format("%s[%d]", key, nestedValueIndex), list.get(nestedValueIndex)));`
`517`	`518`	`}`
`518`	`519`	`} else if (value instanceof Object[]) {`
`519`	`520`	`Object[] array = (Object[]) value;`
`520`		`- for (int nestedValueIndex = 0; nestedValueIndex < array.length; nestedValueIndex++) {`
	`521`	`+ int arrayLength = array.length;`
	`522`	`+ for (int nestedValueIndex = 0; nestedValueIndex < arrayLength; nestedValueIndex++) {`
`521`	`523`	`params.addAll(getParamsList(String.format("%s[%d]", key, nestedValueIndex), array[nestedValueIndex]));`
`522`	`524`	`}`
`523`	`525`	`} else if (value instanceof Set) {`