-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Adding some more HTTP status constants #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@msva Thank you for looking into this. Two issues in your patch though:
|
|
Hi.
But, yes, initially, my idea about making this patch, started from my personal need of 100, 204, 206 and 409 statuses in exact small project ;)
|
|
@msva I insist that we should only add constants actually used :) |
6f51ae9 to
6b6098f
Compare
|
I've removed comments and reduced constants count. |
|
@msva Thanks! I'll look into this :) |
|
Would like to see this in too! We use/will use a few of those as well ( |
src/ngx_http_lua_consts.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line breaks backward-compatibility.
933dbac to
5f1b3fe
Compare
|
@agentzh ping? ;) Can you look into this once again? 😉 |
|
@msva Sorry for the delay on my side. Will you update the document in the file |
|
I almost did it already, but should I also add comments like "first added in XXX release"? ;) If so — I need to know, which release will be next: 0.9.16 or rc2 ;) |
|
anyway, here is next proposition ;) |
|
@msva Cool, thanks! |
|
there was a little mistake (I confused // Btw, I thinking about renaming it to How do you think? |
doc/HttpLuaModule.wiki
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 101 instead of 102, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup. Fixed.
|
ping? Should I drop the codes you've commented above, or it is not that necessarily ;) |
…s Vadim A. Misbakh-Soloviov for the patch in #425.
|
@msva Patch applied to git master. Thanks for your contribution and sorry for the long delay on my side. |
Some usefull status constants + prerequisite for #397