Custom 404, 500, and 403 error pages

Summary:
* Templates in `resources/views/errors/` for error pages
* Partial for error page content as well
* Translation strings for title and body of each error code
* Updated tests to search for status code on relevant pages

Misc:
* Moved the `LoadPages` middleware so it runs on all requests

Resolves T264

Test Plan:
* Go to a URL that doesn't exists, check 404 page
* Go to an unauthorized URL and check 403 page
* Put in an `abort(500)` somewhere to check 500 page

Reviewers: doshitan

Reviewed By: doshitan

Maniphest Tasks: T264

Differential Revision: https://phabricator.opengovfoundation.org/D155

Author: sethetter

app/Http/Kernel.php

@@ -15,6 +15,7 @@ class Kernel extends HttpKernel
      */
     protected $middleware = [
         \Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode::class,
+        \App\Http\Middleware\LoadPages::class,
     ];
 
     /**
@@ -28,7 +29,6 @@ class Kernel extends HttpKernel
             \Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class,
             \Illuminate\Session\Middleware\StartSession::class,
             \Illuminate\View\Middleware\ShareErrorsFromSession::class,
-            \App\Http\Middleware\LoadPages::class,
             \App\Http\Middleware\VerifyCsrfToken::class,
             \Illuminate\Routing\Middleware\SubstituteBindings::class,
         ],

resources/lang/en/messages.php

@@ -437,4 +437,19 @@
             'google_analytics_property_id_help' => 'The UA-XXXXX-Y string identifying which Google Analytics property you wish to track traffic against',
         ],
     ],
+
+    'error' => [
+        '404' => [
+            'title' => 'Not Found (404)',
+            'body' => 'Whatever you were looking for was not found. Try going back and giving it another shot.',
+        ],
+        '403' => [
+            'title' => 'Not Authorized (403)',
+            'body' => 'You are not authorized to perform this action, please go back.',
+        ],
+        '500' => [
+            'title' => 'Something went wrong (500)',
+            'body' => 'There was a problem in our system, we apologize for the inconvenience.',
+        ],
+    ],
 ];

resources/views/errors/403.blade.php

@@ -0,0 +1,7 @@
+@extends('layouts.app')
+
+@section('pageTitle', trans('messages.error.403.title'))
+
+@section('content')
+    @include('errors.partials.error_content', ['status' => '403'])
+@endsection

resources/views/errors/404.blade.php

@@ -0,0 +1,7 @@
+@extends('layouts.app')
+
+@section('pageTitle', trans('messages.error.404.title'))
+
+@section('content')
+    @include('errors.partials.error_content', ['status' => '404'])
+@endsection

resources/views/errors/500.blade.php

@@ -0,0 +1,7 @@
+@extends('layouts.app')
+
+@section('pageTitle', trans('messages.error.500.title'))
+
+@section('content')
+    @include('errors.partials.error_content', ['status' => '500'])
+@endsection

resources/views/errors/partials/error_content.blade.php

@@ -0,0 +1,3 @@
+<h1>@lang('messages.error.' . $status . '.title')</h1>
+<hr>
+<p class="lead">@lang('messages.error.' . $status . '.body')</p>

tests/Browser/AdminTestCase.php

@@ -32,7 +32,7 @@ public function assertNonAdminsDenied($browser, $page)
             ->loginAs($this->user)
             ->visit($page)
             // 403 status
-            ->assertSee('Whoops, looks like something went wrong')
+            ->assertSee('403')
             ;
     }
 }

tests/Browser/Document/Manage/CommentsTest.php

@@ -70,7 +70,7 @@ public function testSponsorCannotEditOtherDocument()
                 ->loginAs($this->sponsorOwner)
                 ->visit(new CommentsPage($otherDocument))
                 // 403 status
-                ->assertSee('Whoops, looks like something went wrong')
+                ->assertSee('403')
                 ;
         });
     }

tests/Browser/Document/Manage/SettingsTest.php

@@ -75,7 +75,7 @@ public function testSponsorCannotEditOtherDocument()
                 ->loginAs($this->sponsorOwner)
                 ->visit(new SettingsPage($otherDocument))
                 // 403 status
-                ->assertSee('Whoops, looks like something went wrong')
+                ->assertSee('403')
                 ;
         });
     }

tests/Browser/DocumentPageTest.php

@@ -175,7 +175,7 @@ public function testCantViewUnpublishedDocument()
         $this->browse(function ($browser) {
             $browser
                 ->visit($this->page)
-                ->assertSee('This action is unauthorized')
+                ->assertSee('403')
                 ;
         });
     }