Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opencontainers/selinux
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.12.0
Choose a base ref
...
head repository: opencontainers/selinux
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.13.0
Choose a head ref
  • 15 commits
  • 10 files changed
  • 4 contributors

Commits on Mar 26, 2025

  1. label: don't capitalize error strings

    This fixes the following linter warnings:
    
    > go-selinux/label/label_linux.go:21:28: ST1005: error strings should not be capitalized (staticcheck)
    > var ErrIncompatibleLabel = errors.New("Bad SELinux option z and Z can not be used together")
    >                            ^
    > go-selinux/label/label_linux.go:55:20: ST1005: error strings should not be capitalized (staticcheck)
    > 				return "", "", fmt.Errorf("Bad label option %q, valid options 'disable' or \n'user, role, level, type, filetype' followed by ':' and a value", opt)
    > 				               ^
    > go-selinux/label/label_linux.go:59:20: ST1005: error strings should not be capitalized (staticcheck)
    > 				return "", "", fmt.Errorf("Bad label option %q, valid options 'disable, user, role, level, type, filetype'", con[0])
    > 				               ^
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Mar 26, 2025
    Configuration menu
    Copy the full SHA
    36bf233 View commit details
    Browse the repository at this point in the history
  2. ci: switch to golangci-lint v2

    The configuration was migrated using golangci-lint migrate and when
    tweaked manually trying to minimize it.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Mar 26, 2025
    Configuration menu
    Copy the full SHA
    0a30d59 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #230 from kolyshkin/golangci-v2

    Switch to golangci-lint v2
    kolyshkin authored Mar 26, 2025
    Configuration menu
    Copy the full SHA
    cf2eadf View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2025

  1. build(deps): bump actions/checkout from 4 to 5

    Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@v4...v5)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-version: '5'
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Aug 12, 2025
    Configuration menu
    Copy the full SHA
    1c8c970 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2025

  1. Merge pull request #233 from opencontainers/dependabot/github_actions…

    …/actions/checkout-5
    
    build(deps): bump actions/checkout from 4 to 5
    rhatdan authored Sep 4, 2025
    Configuration menu
    Copy the full SHA
    f911cf6 View commit details
    Browse the repository at this point in the history
  2. build(deps): bump actions/setup-go from 5 to 6

    Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5 to 6.
    - [Release notes](https://github.com/actions/setup-go/releases)
    - [Commits](actions/setup-go@v5...v6)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-go
      dependency-version: '6'
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Sep 4, 2025
    Configuration menu
    Copy the full SHA
    3c1bd9a View commit details
    Browse the repository at this point in the history
  3. Merge pull request #234 from opencontainers/dependabot/github_actions…

    …/actions/setup-go-6
    
    build(deps): bump actions/setup-go from 5 to 6
    rhatdan authored Sep 4, 2025
    Configuration menu
    Copy the full SHA
    879a755 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2025

  1. keyring: fix typo in EACCES check

    Commit 965323e ("SetKeyLabel: add thread group leader requirement")
    added verification that the caller of SetKeyLabel is the thread-group
    leader, however the check had a typo in it, which would almost always
    cause all errors to be treated as ErrNotTGLeader.
    
    It's a bit of a shame that os.Getuid() and os.Getpid() are untyped, as a
    one-character typo like this can really easily cause bugs without type
    checking...
    
    Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    cyphar committed Oct 7, 2025
    Configuration menu
    Copy the full SHA
    6ec194b View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2025

  1. Merge pull request #235 from cyphar/fix-keyring-err-check

    keyring: fix typo in EACCES check
    rhatdan authored Oct 8, 2025
    Configuration menu
    Copy the full SHA
    74393ea View commit details
    Browse the repository at this point in the history
  2. all: format sources with latest gofumpt

    A new rule was introduced in gofumpt v0.9.0 to "clothe" naked returns.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 8, 2025
    Configuration menu
    Copy the full SHA
    b42e5c8 View commit details
    Browse the repository at this point in the history
  3. ci: bump golangci-lint to v2.5

    Also, bump golangci-lint-action to v8.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 8, 2025
    Configuration menu
    Copy the full SHA
    916cab9 View commit details
    Browse the repository at this point in the history
  4. ci: add go 1.25

    Switch from go 1.24 to go 1.25 where we use a single go version.
    
    Drop go 1.23, add go 1.25 to the test matrix.
    
    (Note most testing is done in a VM job which uses whatever Go version is
    shipped with a distro).
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 8, 2025
    Configuration menu
    Copy the full SHA
    648ce7f View commit details
    Browse the repository at this point in the history
  5. Merge pull request #236 from kolyshkin/modernize-ci

    Add Go 1.25, drop go 1.23, bump golangci-lint
    rhatdan authored Oct 8, 2025
    Configuration menu
    Copy the full SHA
    f2424d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2025

  1. selinux: migrate to pathrs-lite procfs API

    The previous isProcHandle approach introduced in 03b517d ("selinux:
    verify that writes to /proc/... are on procfs") was a fairly naive
    solution to CVE-2019-16884 style bugs, as it only checked that the
    target was a procfs file without any verification what exact procfs file
    it is.
    
    A far more insidious attack (as discussed at the time) would be to
    instead bind-mount something like /proc/self/sched on top of
    /proc/self/attr/... which would not be detectable using a simple
    filesystem type check.
    
    The new pathrs-lite API (provided by filepath-securejoin) can correctly
    detect this and includes many other hardenings to avoid attacks of this
    kind.
    
    Fixes: CVE-2025-52881
    Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    cyphar committed Nov 5, 2025
    Configuration menu
    Copy the full SHA
    c8cfa6f View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2025

  1. Merge pull request #237 from cyphar/selinux-safe-procfs

    selinux: migrate to pathrs-lite procfs API
    rhatdan authored Nov 6, 2025
    Configuration menu
    Copy the full SHA
    4be9937 View commit details
    Browse the repository at this point in the history
Loading