-
Notifications
You must be signed in to change notification settings - Fork 70
Comparing changes
Open a pull request
base repository: opencontainers/selinux
base: v1.12.0
head repository: opencontainers/selinux
compare: v1.13.0
- 15 commits
- 10 files changed
- 4 contributors
Commits on Mar 26, 2025
-
label: don't capitalize error strings
This fixes the following linter warnings: > go-selinux/label/label_linux.go:21:28: ST1005: error strings should not be capitalized (staticcheck) > var ErrIncompatibleLabel = errors.New("Bad SELinux option z and Z can not be used together") > ^ > go-selinux/label/label_linux.go:55:20: ST1005: error strings should not be capitalized (staticcheck) > return "", "", fmt.Errorf("Bad label option %q, valid options 'disable' or \n'user, role, level, type, filetype' followed by ':' and a value", opt) > ^ > go-selinux/label/label_linux.go:59:20: ST1005: error strings should not be capitalized (staticcheck) > return "", "", fmt.Errorf("Bad label option %q, valid options 'disable, user, role, level, type, filetype'", con[0]) > ^ Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>Configuration menu - View commit details
-
Copy full SHA for 36bf233 - Browse repository at this point
Copy the full SHA 36bf233View commit details -
ci: switch to golangci-lint v2
The configuration was migrated using golangci-lint migrate and when tweaked manually trying to minimize it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0a30d59 - Browse repository at this point
Copy the full SHA 0a30d59View commit details -
Merge pull request #230 from kolyshkin/golangci-v2
Switch to golangci-lint v2
Configuration menu - View commit details
-
Copy full SHA for cf2eadf - Browse repository at this point
Copy the full SHA cf2eadfView commit details
Commits on Aug 12, 2025
-
build(deps): bump actions/checkout from 4 to 5
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 1c8c970 - Browse repository at this point
Copy the full SHA 1c8c970View commit details
Commits on Sep 4, 2025
-
Merge pull request #233 from opencontainers/dependabot/github_actions…
…/actions/checkout-5 build(deps): bump actions/checkout from 4 to 5
Configuration menu - View commit details
-
Copy full SHA for f911cf6 - Browse repository at this point
Copy the full SHA f911cf6View commit details -
build(deps): bump actions/setup-go from 5 to 6
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5 to 6. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 3c1bd9a - Browse repository at this point
Copy the full SHA 3c1bd9aView commit details -
Merge pull request #234 from opencontainers/dependabot/github_actions…
…/actions/setup-go-6 build(deps): bump actions/setup-go from 5 to 6
Configuration menu - View commit details
-
Copy full SHA for 879a755 - Browse repository at this point
Copy the full SHA 879a755View commit details
Commits on Oct 7, 2025
-
keyring: fix typo in EACCES check
Commit 965323e ("SetKeyLabel: add thread group leader requirement") added verification that the caller of SetKeyLabel is the thread-group leader, however the check had a typo in it, which would almost always cause all errors to be treated as ErrNotTGLeader. It's a bit of a shame that os.Getuid() and os.Getpid() are untyped, as a one-character typo like this can really easily cause bugs without type checking... Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for 6ec194b - Browse repository at this point
Copy the full SHA 6ec194bView commit details
Commits on Oct 8, 2025
-
Merge pull request #235 from cyphar/fix-keyring-err-check
keyring: fix typo in EACCES check
Configuration menu - View commit details
-
Copy full SHA for 74393ea - Browse repository at this point
Copy the full SHA 74393eaView commit details -
all: format sources with latest gofumpt
A new rule was introduced in gofumpt v0.9.0 to "clothe" naked returns. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b42e5c8 - Browse repository at this point
Copy the full SHA b42e5c8View commit details -
ci: bump golangci-lint to v2.5
Also, bump golangci-lint-action to v8. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 916cab9 - Browse repository at this point
Copy the full SHA 916cab9View commit details -
Switch from go 1.24 to go 1.25 where we use a single go version. Drop go 1.23, add go 1.25 to the test matrix. (Note most testing is done in a VM job which uses whatever Go version is shipped with a distro). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 648ce7f - Browse repository at this point
Copy the full SHA 648ce7fView commit details -
Merge pull request #236 from kolyshkin/modernize-ci
Add Go 1.25, drop go 1.23, bump golangci-lint
Configuration menu - View commit details
-
Copy full SHA for f2424d8 - Browse repository at this point
Copy the full SHA f2424d8View commit details
Commits on Nov 5, 2025
-
selinux: migrate to pathrs-lite procfs API
The previous isProcHandle approach introduced in 03b517d ("selinux: verify that writes to /proc/... are on procfs") was a fairly naive solution to CVE-2019-16884 style bugs, as it only checked that the target was a procfs file without any verification what exact procfs file it is. A far more insidious attack (as discussed at the time) would be to instead bind-mount something like /proc/self/sched on top of /proc/self/attr/... which would not be detectable using a simple filesystem type check. The new pathrs-lite API (provided by filepath-securejoin) can correctly detect this and includes many other hardenings to avoid attacks of this kind. Fixes: CVE-2025-52881 Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for c8cfa6f - Browse repository at this point
Copy the full SHA c8cfa6fView commit details
Commits on Nov 6, 2025
-
Merge pull request #237 from cyphar/selinux-safe-procfs
selinux: migrate to pathrs-lite procfs API
Configuration menu - View commit details
-
Copy full SHA for 4be9937 - Browse repository at this point
Copy the full SHA 4be9937View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.12.0...v1.13.0