Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add constructor for Earth gravity model that doesn't require defining a directory #175

Closed
kyle-cochran opened this issue Oct 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@kyle-cochran
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When defining an Earth gravity model, we have a required directory/aDataDirectory argument. This argument is meant to allow defining gravity model files manually. (e.g. the data underlying the EGM2008). If the argument is set to Undefined, OSTk will manage the files automatically.

In 99% of cases, we pass in Directory::Undefined(). Being required to do this every time is a pain (and looks kinda ugly).

Describe the solution you'd like
We should allow this to be optional, and default it to Undefined. Either by converting existing constructor to make the aDataDirectory argument optional, or adding a new constructor without it.

@kyle-cochran kyle-cochran added the enhancement New feature or request label Oct 4, 2023
@kyle-cochran kyle-cochran moved this to 🆕 New in Up For Grabs Oct 4, 2023
@kyle-cochran
Copy link
Contributor Author

Solved in #256

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Up For Grabs Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant