Empty collection not working - #58

Author: sandrokeil

src/Builder/ClassBuilderCollection.php

@@ -35,6 +35,8 @@ public static function emptyList(): self
 
     private function __construct(ClassBuilder ...$classBuilders)
     {
+        $this->items = [];
+
         foreach ($classBuilders as $classBuilder) {
             $this->items[$this->identifier($classBuilder)] = $classBuilder;
         }

src/Builder/FileCollection.php

@@ -32,6 +32,8 @@ public static function emptyList(): self
 
     private function __construct(File ...$files)
     {
+        $this->items = [];
+
         foreach ($files as $file) {
             $this->items[$this->identifier($file)] = $file;
         }

tests/Builder/ClassBuilderCollectionTest.php

@@ -84,4 +84,15 @@ public function it_adds_anonymous_class_builder(): void
         $items = $cut->items();
         $this->assertArrayHasKey(\spl_object_hash($classBuilder), $items);
     }
+
+    /**
+     * @test
+     */
+    public function it_can_be_empty(): void
+    {
+        $cut = ClassBuilderCollection::emptyList();
+        $this->assertCount(0, $cut);
+
+        $this->assertSame([], $cut->items());
+    }
 }

tests/Builder/FileCollectionTest.php

@@ -0,0 +1,98 @@
+<?php
+
+/**
+ * @see       https://github.com/open-code-modeling/php-code-ast for the canonical source repository
+ * @copyright https://github.com/open-code-modeling/php-code-ast/blob/master/COPYRIGHT.md
+ * @license   https://github.com/open-code-modeling/php-code-ast/blob/master/LICENSE.md MIT License
+ */
+
+declare(strict_types=1);
+
+namespace OpenCodeModelingTest\CodeAst\Builder;
+
+use OpenCodeModeling\CodeAst\Builder\ClassBuilder;
+use OpenCodeModeling\CodeAst\Builder\FileCollection;
+use PHPUnit\Framework\TestCase;
+
+final class FileCollectionTest extends TestCase
+{
+    /**
+     * @test
+     */
+    public function it_adds_same_class_builder_not_twice(): void
+    {
+        $classBuilder = ClassBuilder::fromScratch('MyClass');
+        $cut = FileCollection::fromItems($classBuilder);
+        $this->assertCount(1, $cut);
+
+        $cut->add($classBuilder);
+        $this->assertCount(1, $cut);
+
+        $items = $cut->items();
+        $this->assertArrayHasKey('\\MyClass', $items);
+    }
+
+    /**
+     * @test
+     */
+    public function it_adds_and_removes_class_builder(): void
+    {
+        $classBuilderWithoutNamespace = ClassBuilder::fromScratch('MyClass');
+        $classBuilderNamespace = ClassBuilder::fromScratch('MyClass', 'MyNamespace');
+
+        $cut = FileCollection::fromItems($classBuilderWithoutNamespace);
+        $this->assertCount(1, $cut);
+
+        $cut->add($classBuilderNamespace);
+        $this->assertCount(2, $cut);
+
+        $items = $cut->items();
+        $this->assertArrayHasKey('\\MyClass', $items);
+        $this->assertArrayHasKey('\\MyNamespace\\MyClass', $items);
+
+        $i = 0;
+
+        foreach ($cut as $item) {
+            $this->assertInstanceOf(ClassBuilder::class, $item);
+            if ($i === 0) {
+                $this->assertSame('MyClass', $item->getName());
+                $this->assertNull($item->getNamespace());
+            } else {
+                $this->assertSame('MyClass', $item->getName());
+                $this->assertSame('MyNamespace', $item->getNamespace());
+            }
+            $i++;
+        }
+
+        $cut->remove($classBuilderNamespace);
+        $this->assertCount(1, $cut);
+
+        $items = $cut->items();
+        $this->assertArrayHasKey('\\MyClass', $items);
+    }
+
+    /**
+     * @test
+     */
+    public function it_adds_anonymous_class_builder(): void
+    {
+        $classBuilder = ClassBuilder::fromScratch(null);
+
+        $cut = FileCollection::fromItems($classBuilder);
+        $this->assertCount(1, $cut);
+
+        $items = $cut->items();
+        $this->assertArrayHasKey(\spl_object_hash($classBuilder), $items);
+    }
+
+    /**
+     * @test
+     */
+    public function it_can_be_empty(): void
+    {
+        $cut = FileCollection::emptyList();
+        $this->assertCount(0, $cut);
+
+        $this->assertSame([], $cut->items());
+    }
+}