Remove ucfirst() call because the filter must do the job

Author: sandrokeil

src/ValueObject/EnumFactory.php

@@ -275,7 +275,7 @@ public function methodFromString(string $argumentName): MethodGenerator
 
     private function throwExceptionLine(string $argumentName): string
     {
-        $name = ($this->constValueFilter)($argumentName);
+        $name = \ucfirst(($this->constValueFilter)($argumentName));
 
         return 'throw Invalid' . $name . '::for' . $name . '($' . $argumentName . ');';
     }
@@ -362,7 +362,7 @@ public function methodMagicToString(string $argumentName): MethodGenerator
     public function methodEnumNamedConstructor(string $enumValue): MethodGenerator
     {
         $method = new MethodGenerator(
-            \lcfirst(($this->constValueFilter)($enumValue)),
+            ($this->constValueFilter)($enumValue),
             [],
             MethodGenerator::FLAG_PUBLIC | MethodGenerator::FLAG_STATIC,
             new BodyGenerator($this->parser, \sprintf('return new self(self::%s);', ($this->constNameFilter)($enumValue)))

tests/ValueObject/BaseTestCase.php

@@ -45,6 +45,7 @@ public function setUp(): void
         $filterConstValue->attach(new Filter\Word\SeparatorToSeparator(' ', '-'));
         $filterConstValue->attach(new Filter\Word\UnderscoreToCamelCase());
         $filterConstValue->attach(new Filter\Word\DashToCamelCase());
+        $filterConstValue->attach(function(string $value) { return \lcfirst($value); });
 
         $this->filterConstValue = $filterConstValue;