Make TotalHits return 0 even if SearchResult is nil (#1473)

qilingzhao · web-flow · commit 233b88339beb · 2021-03-25T14:33:48.000+01:00
This will make it even more robust.

Co-authored-by: qilingzhao &lt;qilingzhao@tencent.com&gt;
diff --git a/search.go b/search.go
@@ -669,7 +669,7 @@ type SearchResultCluster struct {
 // a search result. The return value might not be accurate, unless
 // track_total_hits parameter has set to true.
 func (r *SearchResult) TotalHits() int64 {
-	if r.Hits != nil && r.Hits.TotalHits != nil {
+	if r != nil && r.Hits != nil && r.Hits.TotalHits != nil {
 		return r.Hits.TotalHits.Value
 	}
 	return 0

Original file line number	Diff line number	Diff line change
`@@ -669,7 +669,7 @@ type SearchResultCluster struct {`
`669`	`669`	`// a search result. The return value might not be accurate, unless`
`670`	`670`	`// track_total_hits parameter has set to true.`
`671`	`671`	`func (r *SearchResult) TotalHits() int64 {`
`672`		`- if r.Hits != nil && r.Hits.TotalHits != nil {`
	`672`	`+ if r != nil && r.Hits != nil && r.Hits.TotalHits != nil {`
`673`	`673`	`return r.Hits.TotalHits.Value`
`674`	`674`	`}`
`675`	`675`	`return 0`