Fix YubiKey feature detection logics

Author: mssun

pass/AppDelegate.swift

@@ -35,9 +35,6 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
             }
         }
         UNUserNotificationCenter.current().delegate = NotificationCenterDispatcher.shared
-        #if !targetEnvironment(simulator)
-            _ = passKit.YubiKeyConnection.shared
-        #endif
         return true
     }
 

pass/Controllers/PasswordDetailTableViewController.swift

@@ -101,7 +101,7 @@ class PasswordDetailTableViewController: UITableViewController, UIGestureRecogni
     }
 
     private func decryptThenShowPassword() {
-        if Defaults.isYubiKeyEnabled {
+        if Defaults.isYubiKeyEnabled, YubiKitDeviceCapabilities.supportsISO7816NFCTags {
             decryptThenShowPasswordYubiKey()
         } else {
             decryptThenShowPasswordLocalKey()

pass/Controllers/SettingsTableViewController.swift

@@ -185,7 +185,7 @@ class SettingsTableViewController: UITableViewController, UITabBarControllerDele
             )
         }
 
-        if YubiKitDeviceCapabilities.supportsMFIAccessoryKey {
+        if YubiKitDeviceCapabilities.supportsISO7816NFCTags {
             optionMenu.addAction(
                 UIAlertAction(title: Defaults.isYubiKeyEnabled ? "✓ YubiKey" : "YubiKey", style: .default) { _ in
                     Defaults.isYubiKeyEnabled.toggle()

passKit/Helpers/YubiKeyConnection.swift

@@ -18,7 +18,7 @@ public class YubiKeyConnection: NSObject {
 
     override init() {
         super.init()
-        if YubiKitDeviceCapabilities.supportsMFIAccessoryKey {
+        if YubiKitDeviceCapabilities.supportsISO7816NFCTags {
             YubiKitManager.shared.delegate = self
             YubiKitManager.shared.startAccessoryConnection()
         }