add ci; clean up

Author: obalunenko

.golangci.yml

@@ -0,0 +1,89 @@
+linters:
+  enable-all: true
+  disable:
+    - gochecknoglobals
+
+linters-settings:
+  errcheck:
+
+  gofmt:
+    simplify: true
+  govet:
+    check-shadowing: true
+  golint:
+    min-confidence: 0
+  gocyclo:
+    min-complexity: 10
+  maligned:
+    suggest-new: true
+  dupl:
+    threshold: 100
+  goconst:
+    min-len: 2
+    min-occurrences: 2
+  misspell:
+    locale: US
+  lll:
+    line-length: 120
+  goimports:
+    local-prefixes: github.com/oleg-balunenko/leetcode_problems/
+  unparam:
+    algo: cha
+    check-exported: false
+  prealloc:
+    simple: true
+    range-loops: true # Report preallocation suggestions on range loops, true by default
+    for-loops: false # Report preallocation suggestions on for loops, false by default
+  gocritic:
+    enabled-checks:
+      - docStub
+      - rangeValCopy
+      - yodaStyleExpr
+      - appendAssign
+      - appendCombine
+      - caseOrder
+      - badCond
+      - commentedOutCode
+      - commentFormatting
+      - commentedOutImport
+      - dupArg
+      - dupBranchBody
+      - elseif
+      - emptyStringTest
+      - indexAlloc
+      - initClause
+      - captlocal
+      - weakCond
+      - deprecatedComment
+      - flagDeref
+      - flagName
+      - hugeParam
+      - ifElseChain
+      - nilValReturn
+      - rangeExprCopy
+      - ptrToRefParam
+      - underef
+      - unnecessaryBlock
+      - valSwap
+    settings: # settings passed to gocritic
+      captLocal: # must be valid enabled check name
+        paramsOnly: true
+      rangeValCopy:
+        sizeThreshold: 320
+      hugeParam:
+        sizeThreshold: 500
+      rangeExprCopy:
+        skipTestFuncs: true
+      underef:
+        skipRecvDeref: true
+
+
+run:
+
+
+  skip-dirs:
+    - vendor/
+
+output:
+  format: colored-line-number
+

.travis.yml

@@ -0,0 +1,27 @@
+language: go
+dist: trusty
+sudo: false
+install: true
+env:
+  global:
+    - MYAPP=leetcode_problems
+    - MYEMAIL=oleg.balunenko@gmail.com
+    - GOPROXY=https://gocenter.io
+
+jobs:
+  include:
+    - stage: Unit Tests, Vet
+      go:
+        - 1.13.x
+      os:
+        - linux
+      install:
+        - go mod tidy -v
+        - curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin
+
+
+      script:
+        - echo "Run unit tests..."
+        - go vet $(go list ./...)
+        - go test -v -race $(go list ./...)
+        - golangci-lint run

go.mod

@@ -0,0 +1,5 @@
+module github.com/oleg-balunenko/leetcode_problems
+
+go 1.12
+
+require github.com/stretchr/testify v1.4.0

go.sum

@@ -0,0 +1,11 @@
+github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
+github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
+github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
+github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
+github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
+github.com/stretchr/testify v1.4.0 h1:2E4SXV/wtOkTonXsotYi4li6zVWxYlZuYNCXe9XRJyk=
+github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4=
+gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
+gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
+gopkg.in/yaml.v2 v2.2.2 h1:ZCJp+EgiOT7lHqUV2J862kp8Qj64Jo6az82+3Td9dZw=
+gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=

hamming_distance/hamming_test.go

@@ -1,67 +1,58 @@
-package hamming_distance
+package main
 
 import (
 	"fmt"
 	"testing"
-)
-
-type TestCase struct {
-	id             int
-	description    string
-	input          Input
-	expectedResult int
-}
 
-type Input struct {
-	a int
-	b int
-}
+	"github.com/stretchr/testify/assert"
+)
 
-type TestSuite []TestCase
+func TestHamming(t *testing.T) {
+	type args struct {
+		a int
+		b int
+	}
 
-var ts = TestSuite{
-	TestCase{
-		id:          1,
-		description: "test case from task - different numbers",
-		input: Input{
-			a: 1,
-			b: 4,
+	var tests = []struct {
+		id             int
+		description    string
+		input          args
+		expectedResult int
+	}{
+		{
+			id:          1,
+			description: "test case from task - different numbers",
+			input: args{
+				a: 1,
+				b: 4,
+			},
+			expectedResult: 2,
 		},
-		expectedResult: 2,
-	},
-	TestCase{
-		id:          2,
-		description: "Diggerent length of binary",
-		input: Input{
-			a: 1,
-			b: 136,
+		{
+			id:          2,
+			description: "Diggerent length of binary",
+			input: args{
+				a: 1,
+				b: 136,
+			},
+			expectedResult: 3,
 		},
-		expectedResult: 3,
-	},
-	TestCase{
-		id:          3,
-		description: "Same numbers",
-		input: Input{
-			a: 136,
-			b: 136,
+		{
+			id:          3,
+			description: "Same numbers",
+			input: args{
+				a: 136,
+				b: 136,
+			},
+			expectedResult: 0,
 		},
-		expectedResult: 0,
-	},
-}
-
-func TestHamming(t *testing.T) {
+	}
 
-	for _, tc := range ts {
+	for _, tc := range tests {
+		tc := tc
 		t.Run(fmt.Sprintf("Test%d", tc.id), func(t *testing.T) {
-
 			actualResult := hammingDistance(tc.input.a, tc.input.b)
-
-			if actualResult != tc.expectedResult {
-				fmt.Printf(" - Got: %d\n - Expected: %d\n", actualResult, tc.expectedResult)
-				t.Fail()
-			}
-
+			assert.Equal(t, tc.expectedResult, actualResult)
 		})
 	}
-
 }

hamming_distance/main.go

@@ -1,49 +1,40 @@
-package hamming_distance
+package main
 
 import (
-	"fmt"
 	"strconv"
 )
 
 func hammingDistance(x int, y int) int {
-	var result int
+	var (
+		result  int
+		diffLen int
+	)
+
 	binX := strconv.FormatInt(int64(x), 2)
 	binY := strconv.FormatInt(int64(y), 2)
 
-	fmt.Printf("Before diff fix:\n - X: %s\n - Y: %s\n", binX, binY)
-	var diffLen int
-
-	switch {
-	case len(binX) < len(binY):
+	if len(binX) < len(binY) {
 		diffLen = len(binY) - len(binX)
 		binX = addLeadZeros(binX, diffLen)
-
-	case len(binX) > len(binY):
+	} else {
 		diffLen = len(binX) - len(binY)
 		binY = addLeadZeros(binY, diffLen)
 	}
 
-	fmt.Printf("After diff fix\n - X: %s\n - Y: %s\n", binX, binY)
 	for index, digit := range binX {
 		if string([]rune(binY)[index]) != string(digit) {
-
 			result++
-
 		}
 	}
 
 	return result
 }
 
 func addLeadZeros(bin string, diff int) string {
-	//fmt.Printf("Diff is %d\n", diff)
-	//fmt.Printf("string is %s\n", bin)
-
 	var tmp string
 	for i := 0; i < diff; i++ {
 		tmp += "0"
-		//fmt.Printf("Step[%d]: tmp is [%s]\n", i, tmp)
 	}
-	bin = tmp + bin
-	return bin
+
+	return tmp + bin
 }