Skip to content

fix(angular): update ng-packagr executors to support browserlist version ranges #8783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leosvelperez
Copy link
Member

Current Behavior

A recent version of caniuse-lite that's used by browserlist changed to report version ranges instead of single versions for all browsers. This breaks the ng-packagr processing of the stylesheets and therefore the library build fails.

Expected Behavior

Libraries should build successfully.

Related Issue(s)

Fixes #8768

@leosvelperez leosvelperez requested a review from Coly010 January 31, 2022 12:21
@leosvelperez leosvelperez self-assigned this Jan 31, 2022
@vercel
Copy link

vercel bot commented Jan 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/BnBq4xHJBHnfMfD36UKgxvmbrWHu
✅ Preview: Canceled

[Deployment for 15639c6 canceled]

@leosvelperez
Copy link
Member Author

@Coly010 the e2e tests are failing because the application builds are currently failing until angular/angular-cli#22610 is merged and released.

@leosvelperez leosvelperez force-pushed the fix-ng-packagr-browserlist-range-versions branch from 625b388 to 15639c6 Compare February 1, 2022 08:13
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit 5f3ca78 into nrwl:master Feb 1, 2022
@leosvelperez leosvelperez deleted the fix-ng-packagr-browserlist-range-versions branch February 1, 2022 11:14
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular production build error in nx version 13.7.1
2 participants