Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rescript-lang/rescript-vscode
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: nojaf/rescript-vscode
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: additional-completion-tests
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
2 contributors

Commits on Nov 5, 2024

  1. wip complete pipeable functions from dot completion on record when re… 

    …cord is type t of module
    @zth
    zth committed Nov 5, 2024
    Copy the full SHA
    c92c269 View commit details

Commits on Nov 6, 2024

  1. correctly insert completion item text removing the dot when selecting… 

    … a pipe function
    @zth
    zth committed Nov 6, 2024
    Copy the full SHA
    17c52a8 View commit details

  2. add experimental mainTypeForModule annotation

    @zth
    zth committed Nov 6, 2024
    Copy the full SHA
    2263d4c View commit details

Commits on Nov 7, 2024

  1. complete modules in payload of mainTypeForModule

    @zth
    zth committed Nov 7, 2024
    Copy the full SHA
    78f5779 View commit details

Commits on Nov 12, 2024

  1. rename attribute

    @zth
    zth committed Nov 12, 2024
    Copy the full SHA
    4726065 View commit details

  2. hover for new decorator

    @zth
    zth committed Nov 12, 2024
    Copy the full SHA
    e704def View commit details

Commits on Nov 13, 2024

  1. allow extra module completions also for pipe

    @zth
    zth committed Nov 13, 2024
    Copy the full SHA
    70cfb21 View commit details

Commits on Nov 14, 2024

  1. make sure completions work across files

    @zth
    zth committed Nov 14, 2024
    Copy the full SHA
    06d2a92 View commit details

  2. filter pipe completions to only applicable functions

    @zth
    zth committed Nov 14, 2024
    Copy the full SHA
    88a20bc View commit details

Commits on Nov 16, 2024

  1. pipe complete only for functions that take the expected type as the f… 

    …irst argument
    @zth
    zth committed Nov 16, 2024
    Copy the full SHA
    a881b26 View commit details

Commits on Nov 20, 2024

  1. start refactoring dot completion everywhere

    @zth
    zth committed Nov 20, 2024
    Copy the full SHA
    90d3b3b View commit details

Commits on Nov 28, 2024

  1. refactor dot completion

    @zth
    zth committed Nov 28, 2024
    Copy the full SHA
    7a167c5 View commit details

  2. add a few more synthetic

    @zth
    zth committed Nov 28, 2024
    Copy the full SHA
    0d0989a View commit details

  3. disable verbose log

    @zth
    zth committed Nov 28, 2024
    Copy the full SHA
    9af643f View commit details

  4. cleanup

    @zth
    zth committed Nov 28, 2024
    Copy the full SHA
    ab851a0 View commit details

  5. pipe dot completion for builtins

    @zth
    zth committed Nov 28, 2024
    Copy the full SHA
    7892e51 View commit details

Commits on Nov 29, 2024

  1. Add example case (#1058)

    @nojaf
    nojaf authored Nov 29, 2024
    Copy the full SHA
    ec9dab9 View commit details

Commits on Dec 19, 2024

  1. Add Rxjs completion test

    @nojaf
    nojaf committed Dec 19, 2024
    Copy the full SHA
    bd87ecd View commit details

  2. Add Rxjs binding example

    @nojaf
    nojaf committed Dec 19, 2024
    Copy the full SHA
    ef4e6a0 View commit details

  3. Extend Rxjs test with fully qualified access

    @nojaf
    nojaf committed Dec 19, 2024
    Copy the full SHA
    34b2430 View commit details

  4. Add@editor.completeFrom and incomplete test output

    @nojaf
    nojaf committed Dec 19, 2024
    Copy the full SHA
    cd771f0 View commit details

  5. Add passing test for property completion

    @nojaf
    nojaf committed Dec 19, 2024
    Copy the full SHA
    9765485 View commit details

  6. Test still works when types are not named t.

    @nojaf
    nojaf committed Dec 19, 2024
    Copy the full SHA
    a874b21 View commit details

  7. Add test for @editor.completeFrom

    @nojaf
    nojaf committed Dec 19, 2024
    Copy the full SHA
    9a8b960 View commit details
Showing with 1,591 additions and 309 deletions.
  1. +321 −128 analysis/src/CompletionBackEnd.ml
  2. +5 −0 analysis/src/CompletionDecorators.ml
  3. +77 −21 analysis/src/CompletionFrontEnd.ml
  4. +16 −0 analysis/src/ProcessAttributes.ml
  5. +20 −2 analysis/src/Protocol.ml
  6. +15 −4 analysis/src/SharedTypes.ml
  7. +95 −2 analysis/src/TypeUtils.ml
  8. +1 −0 analysis/tests/src/CompletePrioritize1.res
  9. +44 −0 analysis/tests/src/CompletionFromModule.res
  10. +14 −0 analysis/tests/src/CompletionFromModule2.res
  11. +2 −2 analysis/tests/src/CompletionInferValues.res
  12. +22 −0 analysis/tests/src/CompletionMultipleEditorCompleteFrom.res
  13. +9 −0 analysis/tests/src/CompletionPipeChain.res
  14. +23 −0 analysis/tests/src/CompletionPipeProperty.res
  15. +4 −1 analysis/tests/src/CompletionPipeSubmodules.res
  16. +87 −0 analysis/tests/src/DotCompletionEverywhere.res
  17. +51 −0 analysis/tests/src/Rxjs.res
  18. +39 −0 analysis/tests/src/RxjsCompletion.res
  19. +4 −4 analysis/tests/src/expected/CompletePrioritize1.res.txt
  20. +12 −0 analysis/tests/src/expected/Completion.res.txt
  21. +3 −0 analysis/tests/src/expected/CompletionExpressions.res.txt
  22. +128 −0 analysis/tests/src/expected/CompletionFromModule.res.txt
  23. +113 −0 analysis/tests/src/expected/CompletionFromModule2.res.txt
  24. +18 −15 analysis/tests/src/expected/CompletionInferValues.res.txt
  25. +0 −24 analysis/tests/src/expected/CompletionJsx.res.txt
  26. +14 −0 analysis/tests/src/expected/CompletionMultipleEditorCompleteFrom.res.txt
  27. +24 −72 analysis/tests/src/expected/CompletionPipeChain.res.txt
  28. +50 −0 analysis/tests/src/expected/CompletionPipeProperty.res.txt
  29. +32 −34 analysis/tests/src/expected/CompletionPipeSubmodules.res.txt
  30. +274 −0 analysis/tests/src/expected/DotCompletionEverywhere.res.txt
  31. +9 −0 analysis/tests/src/expected/Hover.res.txt
  32. +3 −0 analysis/tests/src/expected/RecordCompletion.res.txt
  33. 0 analysis/tests/src/expected/Rxjs.res.txt
  34. +62 −0 analysis/tests/src/expected/RxjsCompletion.res.txt
Loading