lib,test: update unhandled rejections link#41195
Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
Closed
lib,test: update unhandled rejections link#41195cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig wants to merge 1 commit intonodejs:masterfrom
Conversation
The link in the warning printed on unhandled rejection is no longer valid. This commit updates the URL to the correct target.
nodejs-github-bot
added
needs-ci
DerekNonGeneric
approved these changes
Dec 16, 2021
Contributor
DerekNonGeneric
left a comment
DerekNonGeneric
left a comment
There was a problem hiding this comment.
They actually both seem to be functional links pointing to the same place:
- https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode
- https://nodejs.org/api/cli.html#--unhandled-rejectionsmode
I think I prefer the one you are proposing tho (it looks a bit better/cleaner/easier to read).
Contributor
Author
|
Hm, maybe this is a Chrome issue or something with my local machine. Both links work for me in Firefox. I'm going to close this - no need go changing things for no reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link in the warning printed on unhandled rejection is no longer valid. This commit updates the URL to the correct target.